From: "Arınç ÜNAL" <arinc.unal@arinc9.com>
To: Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Sean Wang <sean.wang@mediatek.com>,
Landen Chao <Landen.Chao@mediatek.com>,
DENG Qingfang <dqfext@gmail.com>,
Frank Wunderlich <frank-w@public-files.de>,
Luiz Angelo Daros de Luca <luizluca@gmail.com>,
Sander Vanheule <sander@svanheule.net>,
Daniel Golle <daniel@makrotopia.org>,
erkin.bozoglu@xeront.com,
Sergio Paracuellos <sergio.paracuellos@gmail.com>
Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
"Arınç ÜNAL" <arinc.unal@arinc9.com>
Subject: [PATCH v5 5/7] dt-bindings: net: dsa: mediatek,mt7530: define port binding per switch
Date: Wed, 24 Aug 2022 13:40:38 +0300 [thread overview]
Message-ID: <20220824104040.17527-6-arinc.unal@arinc9.com> (raw)
In-Reply-To: <20220824104040.17527-1-arinc.unal@arinc9.com>
Define DSA port binding per switch model as each switch model requires
different values for certain properties.
Define reg property on $defs as it's the same for all switch models.
Remove unnecessary lines as they are already included from the referred
dsa.yaml.
Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com>
---
.../bindings/net/dsa/mediatek,mt7530.yaml | 55 +++++++++++--------
1 file changed, 33 insertions(+), 22 deletions(-)
diff --git a/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml b/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml
index 8dfc307e6e1b..a6003db87113 100644
--- a/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml
+++ b/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml
@@ -127,37 +127,45 @@ properties:
ethsys.
maxItems: 1
-patternProperties:
- "^(ethernet-)?ports$":
- type: object
-
- patternProperties:
- "^(ethernet-)?port@[0-9]+$":
- type: object
- description: Ethernet switch ports
-
- unevaluatedProperties: false
+required:
+ - compatible
+ - reg
- properties:
- reg:
- description:
- Port address described must be 5 or 6 for CPU port and from 0
- to 5 for user ports.
+$defs:
+ dsa-port-reg:
+ properties:
+ reg:
+ description:
+ Port address described must be 5 or 6 for CPU port and from 0 to 5 for
+ user ports.
- allOf:
- - $ref: dsa-port.yaml#
- - if:
+ mt7530-dsa-port:
+ patternProperties:
+ "^(ethernet-)?ports$":
+ patternProperties:
+ "^(ethernet-)?port@[0-9]+$":
+ $ref: "#/$defs/dsa-port-reg"
+ if:
properties:
label:
const: cpu
then:
required:
- - reg
- phy-mode
-required:
- - compatible
- - reg
+ mt7531-dsa-port:
+ patternProperties:
+ "^(ethernet-)?ports$":
+ patternProperties:
+ "^(ethernet-)?port@[0-9]+$":
+ $ref: "#/$defs/dsa-port-reg"
+ if:
+ properties:
+ label:
+ const: cpu
+ then:
+ required:
+ - phy-mode
allOf:
- $ref: dsa.yaml#
@@ -180,6 +188,7 @@ allOf:
compatible:
const: mediatek,mt7530
then:
+ $ref: "#/$defs/mt7530-dsa-port"
required:
- core-supply
- io-supply
@@ -189,6 +198,7 @@ allOf:
compatible:
const: mediatek,mt7531
then:
+ $ref: "#/$defs/mt7531-dsa-port"
properties:
mediatek,mcm: false
@@ -197,6 +207,7 @@ allOf:
compatible:
const: mediatek,mt7621
then:
+ $ref: "#/$defs/mt7530-dsa-port"
required:
- mediatek,mcm
--
2.34.1
next prev parent reply other threads:[~2022-08-24 10:44 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-24 10:40 [PATCH v5 0/7] completely rework mediatek,mt7530 binding Arınç ÜNAL
2022-08-24 10:40 ` [PATCH v5 1/7] dt-bindings: net: dsa: mediatek,mt7530: make trivial changes Arınç ÜNAL
2022-08-24 19:44 ` Rob Herring
2022-08-24 20:08 ` Arınç ÜNAL
2022-08-25 6:15 ` Krzysztof Kozlowski
2022-08-24 10:40 ` [PATCH v5 2/7] dt-bindings: net: dsa: mediatek,mt7530: fix description of mediatek,mcm Arınç ÜNAL
2022-08-25 6:15 ` Krzysztof Kozlowski
2022-08-24 10:40 ` [PATCH v5 3/7] dt-bindings: net: dsa: mediatek,mt7530: fix reset lines Arınç ÜNAL
2022-08-25 6:16 ` Krzysztof Kozlowski
2022-08-24 10:40 ` [PATCH v5 4/7] dt-bindings: net: dsa: mediatek,mt7530: update examples Arınç ÜNAL
2022-08-24 10:40 ` Arınç ÜNAL [this message]
2022-08-25 6:18 ` [PATCH v5 5/7] dt-bindings: net: dsa: mediatek,mt7530: define port binding per switch Krzysztof Kozlowski
2022-08-24 10:40 ` [PATCH v5 6/7] dt-bindings: net: dsa: mediatek,mt7530: define phy-mode for switch models Arınç ÜNAL
2022-08-24 10:40 ` [PATCH v5 7/7] dt-bindings: net: dsa: mediatek,mt7530: update binding description Arınç ÜNAL
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220824104040.17527-6-arinc.unal@arinc9.com \
--to=arinc.unal@arinc9.com \
--cc=Landen.Chao@mediatek.com \
--cc=andrew@lunn.ch \
--cc=daniel@makrotopia.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dqfext@gmail.com \
--cc=edumazet@google.com \
--cc=erkin.bozoglu@xeront.com \
--cc=f.fainelli@gmail.com \
--cc=frank-w@public-files.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=luizluca@gmail.com \
--cc=matthias.bgg@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=robh+dt@kernel.org \
--cc=sander@svanheule.net \
--cc=sean.wang@mediatek.com \
--cc=sergio.paracuellos@gmail.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).