From: Jakub Kicinski <kuba@kernel.org>
To: Eric Dumazet <edumazet@google.com>
Cc: Menglong Dong <menglong8.dong@gmail.com>,
Steven Rostedt <rostedt@goodmis.org>,
Ingo Molnar <mingo@redhat.com>,
David Miller <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>,
Neil Horman <nhorman@tuxdriver.com>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
Martin KaFai Lau <kafai@fb.com>, Song Liu <songliubraving@fb.com>,
Yonghong Song <yhs@fb.com>,
John Fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@kernel.org>,
Menglong Dong <imagedong@tencent.com>,
David Ahern <dsahern@kernel.org>,
Talal Ahmad <talalahmad@google.com>,
Kees Cook <keescook@chromium.org>,
LKML <linux-kernel@vger.kernel.org>,
netdev <netdev@vger.kernel.org>, bpf <bpf@vger.kernel.org>
Subject: Re: [PATCH net-next v4 2/3] net: skb: use auto-generation to convert skb drop reason to string
Date: Wed, 24 Aug 2022 18:10:40 -0700 [thread overview]
Message-ID: <20220824181040.57ec009e@kernel.org> (raw)
In-Reply-To: <CANn89i+bx0ybvE55iMYf5GJM48WwV1HNpdm9Q6t-HaEstqpCSA@mail.gmail.com>
On Wed, 24 Aug 2022 17:45:15 -0700 Eric Dumazet wrote:
> After this patch, I no longer have strings added after the reason: tag
Hm, using a kernel address (drop_reasons) as an argument to TP_printk()
definitely does not look right, but how to tickle whatever magic
__print_symbolic was providing I do not know :S
TP_printk("skbaddr=%p protocol=%u location=%p reason: %s",
__entry->skbaddr, __entry->protocol, __entry->location,
- __print_symbolic(__entry->reason,
- TRACE_SKB_DROP_REASON))
+ drop_reasons[__entry->reason])
next prev parent reply other threads:[~2022-08-25 1:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-06 2:24 [PATCH net-next v4 0/3] reorganize the code of the enum skb_drop_reason menglong8.dong
2022-06-06 2:24 ` [PATCH net-next v4 1/3] net: skb: move enum skb_drop_reason to standalone header file menglong8.dong
2022-06-06 2:24 ` [PATCH net-next v4 2/3] net: skb: use auto-generation to convert skb drop reason to string menglong8.dong
2022-08-25 0:45 ` Eric Dumazet
2022-08-25 1:10 ` Jakub Kicinski [this message]
2022-08-25 2:29 ` Menglong Dong
2022-06-06 2:24 ` [PATCH net-next v4 3/3] net: dropreason: reformat the comment fo skb drop reasons menglong8.dong
2022-06-07 11:10 ` [PATCH net-next v4 0/3] reorganize the code of the enum skb_drop_reason patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220824181040.57ec009e@kernel.org \
--to=kuba@kernel.org \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=imagedong@tencent.com \
--cc=john.fastabend@gmail.com \
--cc=kafai@fb.com \
--cc=keescook@chromium.org \
--cc=kpsingh@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=menglong8.dong@gmail.com \
--cc=mingo@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=pabeni@redhat.com \
--cc=rostedt@goodmis.org \
--cc=songliubraving@fb.com \
--cc=talalahmad@google.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).