From: Xuewen Yan <xuewen.yan@unisoc.com>
To: <viresh.kumar@linaro.org>, <lukasz.luba@arm.com>,
<amit.kachhap@gmail.com>, <daniel.lezcano@linaro.org>,
<rafael@kernel.org>
Cc: <amitk@kernel.org>, <rui.zhang@intel.com>,
<linux-pm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<xuewen.yan94@gmail.com>, <di.shen@unisoc.com>
Subject: [PATCH] thermal: Check the policy first in cpufreq_cooling_register
Date: Thu, 25 Aug 2022 19:40:17 +0800 [thread overview]
Message-ID: <20220825114018.1715-1-xuewen.yan@unisoc.com> (raw)
Since the policy needs to be accessed first when obtaining cpu devices,
first check whether the policy is legal before this.
Signed-off-by: Xuewen Yan <xuewen.yan@unisoc.com>
---
drivers/thermal/cpufreq_cooling.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/thermal/cpufreq_cooling.c b/drivers/thermal/cpufreq_cooling.c
index b76293cc989c..7838b6e2dba5 100644
--- a/drivers/thermal/cpufreq_cooling.c
+++ b/drivers/thermal/cpufreq_cooling.c
@@ -501,17 +501,17 @@ __cpufreq_cooling_register(struct device_node *np,
struct thermal_cooling_device_ops *cooling_ops;
char *name;
+ if (IS_ERR_OR_NULL(policy)) {
+ pr_err("%s: cpufreq policy isn't valid: %p\n", __func__, policy);
+ return ERR_PTR(-EINVAL);
+ }
+
dev = get_cpu_device(policy->cpu);
if (unlikely(!dev)) {
pr_warn("No cpu device for cpu %d\n", policy->cpu);
return ERR_PTR(-ENODEV);
}
- if (IS_ERR_OR_NULL(policy)) {
- pr_err("%s: cpufreq policy isn't valid: %p\n", __func__, policy);
- return ERR_PTR(-EINVAL);
- }
-
i = cpufreq_table_count_valid_entries(policy);
if (!i) {
pr_debug("%s: CPUFreq table not found or has no valid entries\n",
--
2.25.1
next reply other threads:[~2022-08-25 11:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-25 11:40 Xuewen Yan [this message]
2022-08-29 6:28 ` [PATCH] thermal: Check the policy first in cpufreq_cooling_register Xuewen Yan
2022-08-30 5:34 ` Viresh Kumar
2022-09-03 18:09 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220825114018.1715-1-xuewen.yan@unisoc.com \
--to=xuewen.yan@unisoc.com \
--cc=amit.kachhap@gmail.com \
--cc=amitk@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=di.shen@unisoc.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=rafael@kernel.org \
--cc=rui.zhang@intel.com \
--cc=viresh.kumar@linaro.org \
--cc=xuewen.yan94@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).