From: Jakub Kicinski <kuba@kernel.org>
To: Vladimir Oltean <olteanv@gmail.com>
Cc: Paolo Abeni <pabeni@redhat.com>,
Oleksij Rempel <o.rempel@pengutronix.de>,
Woojung Huh <woojung.huh@microchip.com>,
UNGLinuxDriver@microchip.com, Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
kernel@pengutronix.de, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org,
Arun Ramadoss <arun.ramadoss@microchip.com>
Subject: Re: [PATCH net-next v3 00/17] net: dsa: microchip: add error handling and register access validation
Date: Thu, 25 Aug 2022 15:57:56 -0700 [thread overview]
Message-ID: <20220825155756.142c07a5@kernel.org> (raw)
In-Reply-To: <20220825214424.u6oawi5n47zyn7rd@skbuf>
On Fri, 26 Aug 2022 00:44:24 +0300 Vladimir Oltean wrote:
> On Thu, Aug 25, 2022 at 11:00:44AM +0200, Paolo Abeni wrote:
> > On Tue, 2022-08-23 at 10:02 +0200, Oleksij Rempel wrote:
> > > changes v3:
> > > - fix build error in the middle of the patch stack.
> >
> > The series looks reasonable to me, let's see the comments from the DSA
> > crew;)
>
> Patch set looks ok from my side, won't leave review tags for each of the
> 17 patches, just here
>
> Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
Thanks a lot!
Oleksij there are quite a few checkpatch annoyances here, please fix up:
-------------------------------------------------------------------------------------------
Commit 0ef2f8617176 ("net: dsa: microchip: do per-port Gbit detection instead of per-chip")
-------------------------------------------------------------------------------------------
WARNING: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#12:
ksz9477_switch_init() function. Which is using undocumented REG_GLOBAL_OPTIONS
total: 0 errors, 1 warnings, 0 checks, 144 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
Commit 0ef2f8617176 ("net: dsa: microchip: do per-port Gbit detection instead of per-chip") has style problems, please review.
-------------------------------------------------------------------------------------------------------
Commit 06c98e1faaa7 ("net: dsa: microchip: don't announce extended register support on non Gbit chips")
-------------------------------------------------------------------------------------------------------
CHECK: Please don't use multiple blank lines
#29: FILE: drivers/net/dsa/microchip/ksz9477.c:267:
+
total: 0 errors, 0 warnings, 1 checks, 32 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
Commit 06c98e1faaa7 ("net: dsa: microchip: don't announce extended register support on non Gbit chips") has style problems, please review.
------------------------------------------------------------------------------------------------------
Commit 872fff3049d3 ("net: dsa: microchip: forward error value on all ksz_pread/ksz_pwrite functions")
------------------------------------------------------------------------------------------------------
CHECK: Alignment should match open parenthesis
#28: FILE: drivers/net/dsa/microchip/ksz_common.h:397:
+static inline int ksz_pread8(struct ksz_device *dev, int port, int offset,
u8 *data)
CHECK: Alignment should match open parenthesis
#36: FILE: drivers/net/dsa/microchip/ksz_common.h:403:
+static inline int ksz_pread16(struct ksz_device *dev, int port, int offset,
u16 *data)
CHECK: Alignment should match open parenthesis
#44: FILE: drivers/net/dsa/microchip/ksz_common.h:409:
+static inline int ksz_pread32(struct ksz_device *dev, int port, int offset,
u32 *data)
CHECK: Alignment should match open parenthesis
#52: FILE: drivers/net/dsa/microchip/ksz_common.h:415:
+static inline int ksz_pwrite8(struct ksz_device *dev, int port, int offset,
u8 data)
CHECK: Alignment should match open parenthesis
#60: FILE: drivers/net/dsa/microchip/ksz_common.h:421:
+static inline int ksz_pwrite16(struct ksz_device *dev, int port, int offset,
u16 data)
CHECK: Alignment should match open parenthesis
#69: FILE: drivers/net/dsa/microchip/ksz_common.h:428:
+static inline int ksz_pwrite32(struct ksz_device *dev, int port, int offset,
u32 data)
total: 0 errors, 0 warnings, 6 checks, 58 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
Commit 872fff3049d3 ("net: dsa: microchip: forward error value on all ksz_pread/ksz_pwrite functions") has style problems, please review.
-----------------------------------------------------------------------------------------------------------------
Commit a615f4ad0116 ("net: dsa: microchip: KSZ9893: do not write to not supported Output Clock Control Register")
-----------------------------------------------------------------------------------------------------------------
WARNING: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#8:
KSZ9893 compatible chips do not have "Output Clock Control Register 0x0103".
total: 0 errors, 1 warnings, 0 checks, 15 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
Commit a615f4ad0116 ("net: dsa: microchip: KSZ9893: do not write to not supported Output Clock Control Register") has style problems, please review.
---------------------------------------------------------------------------------
Commit d1abab8b5762 ("net: dsa: microchip: add support for regmap_access_tables")
---------------------------------------------------------------------------------
WARNING: unnecessary whitespace before a quoted newline
#43: FILE: drivers/net/dsa/microchip/ksz_common.h:338:
+ dev_err(dev->dev, "can't read 8bit reg: 0x%x %pe \n", reg,
WARNING: unnecessary whitespace before a quoted newline
#56: FILE: drivers/net/dsa/microchip/ksz_common.h:351:
+ dev_err(dev->dev, "can't read 16bit reg: 0x%x %pe \n", reg,
WARNING: unnecessary whitespace before a quoted newline
#69: FILE: drivers/net/dsa/microchip/ksz_common.h:364:
+ dev_err(dev->dev, "can't read 32bit reg: 0x%x %pe \n", reg,
WARNING: unnecessary whitespace before a quoted newline
#84: FILE: drivers/net/dsa/microchip/ksz_common.h:378:
+ dev_err(dev->dev, "can't read 64bit reg: 0x%x %pe \n", reg,
WARNING: unnecessary whitespace before a quoted newline
#99: FILE: drivers/net/dsa/microchip/ksz_common.h:392:
+ dev_err(dev->dev, "can't write 8bit reg: 0x%x %pe \n", reg,
WARNING: unnecessary whitespace before a quoted newline
#112: FILE: drivers/net/dsa/microchip/ksz_common.h:404:
+ dev_err(dev->dev, "can't write 16bit reg: 0x%x %pe \n", reg,
WARNING: unnecessary whitespace before a quoted newline
#125: FILE: drivers/net/dsa/microchip/ksz_common.h:416:
+ dev_err(dev->dev, "can't write 32bit reg: 0x%x %pe \n", reg,
total: 0 errors, 7 warnings, 0 checks, 123 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
Commit d1abab8b5762 ("net: dsa: microchip: add support for regmap_access_tables") has style problems, please review.
----------------------------------------------------------------------------------------------------
Commit 39a148ccc56c ("net: dsa: microchip: ksz9477: remove MII_CTRL1000 check from ksz9477_w_phy()")
----------------------------------------------------------------------------------------------------
WARNING: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#11:
With proper regmap_ranges provided for all chips we will be able to catch this
total: 0 errors, 1 warnings, 0 checks, 14 lines checked
next prev parent reply other threads:[~2022-08-25 22:58 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-23 8:02 [PATCH net-next v3 00/17] net: dsa: microchip: add error handling and register access validation Oleksij Rempel
2022-08-23 8:02 ` [PATCH net-next v3 01/17] net: dsa: microchip: add separate struct ksz_chip_data for KSZ8563 chip Oleksij Rempel
2022-08-23 8:02 ` [PATCH net-next v3 02/17] net: dsa: microchip: do per-port Gbit detection instead of per-chip Oleksij Rempel
2022-08-23 8:02 ` [PATCH net-next v3 03/17] net: dsa: microchip: don't announce extended register support on non Gbit chips Oleksij Rempel
2022-08-23 8:02 ` [PATCH net-next v3 04/17] net: dsa: microchip: allow to pass return values for PHY read/write accesses Oleksij Rempel
2022-08-23 8:02 ` [PATCH net-next v3 05/17] net: dsa: microchip: forward error value on all ksz_pread/ksz_pwrite functions Oleksij Rempel
2022-08-23 8:02 ` [PATCH net-next v3 06/17] net: dsa: microchip: ksz9477: add error handling to ksz9477_r/w_phy Oleksij Rempel
2022-08-23 8:02 ` [PATCH net-next v3 07/17] net: dsa: microchip: ksz8795: add error handling to ksz8_r/w_phy Oleksij Rempel
2022-08-23 8:02 ` [PATCH net-next v3 08/17] net: dsa: microchip: KSZ9893: do not write to not supported Output Clock Control Register Oleksij Rempel
2022-08-23 8:02 ` [PATCH net-next v3 09/17] net: dsa: microchip: add support for regmap_access_tables Oleksij Rempel
2022-08-23 8:02 ` [PATCH net-next v3 10/17] net: dsa: microchip: add regmap_range for KSZ8563 chip Oleksij Rempel
2022-08-23 8:02 ` [PATCH net-next v3 11/17] net: dsa: microchip: ksz9477: remove MII_CTRL1000 check from ksz9477_w_phy() Oleksij Rempel
2022-08-23 8:02 ` [PATCH net-next v3 12/17] net: dsa: microchip: add regmap_range for KSZ9477 chip Oleksij Rempel
2022-08-23 8:02 ` [PATCH net-next v3 13/17] net: dsa: microchip: ksz9477: use internal_phy instead of phy_port_cnt Oleksij Rempel
2022-08-23 8:02 ` [PATCH net-next v3 14/17] net: dsa: microchip: remove unused port phy variable Oleksij Rempel
2022-08-23 8:02 ` [PATCH net-next v3 15/17] net: dsa: microchip: ksz9477: remove unused "on" variable Oleksij Rempel
2022-08-25 20:54 ` Vladimir Oltean
2022-08-26 7:51 ` Oleksij Rempel
2022-08-23 8:02 ` [PATCH net-next v3 16/17] net: dsa: microchip: remove unused sgmii variable Oleksij Rempel
2022-08-23 8:02 ` [PATCH net-next v3 17/17] net: dsa: microchip: remove IS_9893 flag Oleksij Rempel
2022-08-25 9:00 ` [PATCH net-next v3 00/17] net: dsa: microchip: add error handling and register access validation Paolo Abeni
2022-08-25 21:44 ` Vladimir Oltean
2022-08-25 22:57 ` Jakub Kicinski [this message]
2022-08-26 10:56 Oleksij Rempel
2022-08-31 8:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220825155756.142c07a5@kernel.org \
--to=kuba@kernel.org \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=arun.ramadoss@microchip.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=vivien.didelot@gmail.com \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).