From: sunliming <sunliming@kylinos.cn>
To: wim@linux-watchdog.org, arnd@arndb.de
Cc: linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org,
kelulanainsley@gmail.com, sunliming <sunliming@kylinos.cn>,
kernel test robot <lkp@intel.com>,
Guenter Roeck <linux@roeck-us.net>
Subject: [PATCH RESEND] watchdog: sa1100: make variable sa1100dog_driver static
Date: Fri, 26 Aug 2022 16:52:43 +0800 [thread overview]
Message-ID: <20220826085243.95997-1-sunliming@kylinos.cn> (raw)
This symbol is not used outside of sa1100_wdt.c, so marks it static.
Fixes the following warning:
>> drivers/watchdog/sa1100_wdt.c:241:24: sparse: sparse: symbol 'sa1100dog_driver'
was not declared. Should it be static?
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: sunliming <sunliming@kylinos.cn>
Acked-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
---
drivers/watchdog/sa1100_wdt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/watchdog/sa1100_wdt.c b/drivers/watchdog/sa1100_wdt.c
index 2d0a06a158a8..82ac5d19f519 100644
--- a/drivers/watchdog/sa1100_wdt.c
+++ b/drivers/watchdog/sa1100_wdt.c
@@ -238,7 +238,7 @@ static int sa1100dog_remove(struct platform_device *pdev)
return 0;
}
-struct platform_driver sa1100dog_driver = {
+static struct platform_driver sa1100dog_driver = {
.driver.name = "sa1100_wdt",
.probe = sa1100dog_probe,
.remove = sa1100dog_remove,
--
2.25.1
reply other threads:[~2022-08-26 8:52 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220826085243.95997-1-sunliming@kylinos.cn \
--to=sunliming@kylinos.cn \
--cc=arnd@arndb.de \
--cc=kelulanainsley@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lkp@intel.com \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).