From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33A16ECAAD1 for ; Sat, 27 Aug 2022 17:36:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234299AbiH0RgW (ORCPT ); Sat, 27 Aug 2022 13:36:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44118 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231362AbiH0RgU (ORCPT ); Sat, 27 Aug 2022 13:36:20 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E5BF532D86 for ; Sat, 27 Aug 2022 10:36:15 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 7C4BCB80958 for ; Sat, 27 Aug 2022 17:36:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0622DC433C1; Sat, 27 Aug 2022 17:36:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1661621773; bh=NxjUwOXrobHmp8ZbfT88vTxMT5BPopThAMotW8ZMdBY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=eI18Q9T+RDTBR/wNRos+mpBNOICZ/yzJ4hd2u56mwb3Bfj/8kXo/3xcnZtaEPpc+P k8JyH+EdObuMBO+k9cC2NK1RO1+pvB+p4jBV0sBECovkoszUQtl238O1OSa0YrR2YD CKFSPcp0p/tEWB1rI5CPEaiBnVtEJDMfjdOtlbx0sDC6q5PhgqbJc4DvW9BCCsBcgg 4+XEEee6APJbuAUlRXPlP35aLP8sC+SyNcok3GEyrtLZ53Ss+Jp3lixPzvB63LpItr VzPmlpSuquffr4h4Zh9wMMpiSC8cDqevASsSJHbRL1WMcimLzEisWwY9Q4EiT+zqMT yU2p2jZUclohg== Received: by pali.im (Postfix) id 32F6EC7A; Sat, 27 Aug 2022 19:36:10 +0200 (CEST) Date: Sat, 27 Aug 2022 19:36:10 +0200 From: Pali =?utf-8?B?Um9ow6Fy?= To: Christophe Leroy Cc: Michael Ellerman , Joel Stanley , Benjamin Herrenschmidt , Paul Mackerras , "linuxppc-dev@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v2] powerpc/boot: Don't always pass -mcpu=powerpc when building 32-bit uImage Message-ID: <20220827173610.7bdp7zychwu2u5i6@pali> References: <20220820105200.30425-1-pali@kernel.org> <20220827133900.16634-1-pali@kernel.org> <63f4bce4-7965-9bc6-2104-42e26acd0208@csgroup.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <63f4bce4-7965-9bc6-2104-42e26acd0208@csgroup.eu> User-Agent: NeoMutt/20180716 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Saturday 27 August 2022 17:31:10 Christophe Leroy wrote: > Le 27/08/2022 à 15:39, Pali Rohár a écrit : > > For 32-bit uImage try to use CONFIG_TARGET_CPU option for -mcpu. This fixes > > following compiler error when building kernel with powerpc e500 SPE capable > > cross compilers: > > > > BOOTAS arch/powerpc/boot/crt0.o > > powerpc-linux-gnuspe-gcc: error: unrecognized argument in option ‘-mcpu=powerpc’ > > powerpc-linux-gnuspe-gcc: note: valid arguments to ‘-mcpu=’ are: 8540 8548 native > > make[1]: *** [arch/powerpc/boot/Makefile:231: arch/powerpc/boot/crt0.o] Error 1 > > > > For 64-bit uImage and 64-bit kernels with 32-bit uImage wrapper there is no > > change. > > > > Similar change was already introduced for the main powerpc Makefile in > > commit 446cda1b21d9 ("powerpc/32: Don't always pass -mcpu=powerpc to the > > compiler"). > > > > Fixes: 40a75584e526 ("powerpc/boot: Build wrapper for an appropriate CPU") > > Cc: stable@vger.kernel.org > > Signed-off-by: Pali Rohár > > --- > > arch/powerpc/boot/Makefile | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > > > diff --git a/arch/powerpc/boot/Makefile b/arch/powerpc/boot/Makefile > > index a9cd2ea4a861..f56a5f90a5d8 100644 > > --- a/arch/powerpc/boot/Makefile > > +++ b/arch/powerpc/boot/Makefile > > @@ -44,8 +44,16 @@ else > > BOOTCFLAGS += -m64 -mcpu=powerpc64 > > endif > > else > > +ifdef CONFIG_PPC32 > > +ifdef CONFIG_TARGET_CPU_BOOL > > +BOOTCFLAGS += -m32 -mcpu=$(CONFIG_TARGET_CPU) > > +else > > +BOOTCFLAGS += -m32 -mcpu=powerpc > > You can't do that. You get here only if user has selected > TOOLCHAIN_DEFAULT_CPU, in which case you don't want to for -mcpu=powerpc. So do I understand it correctly that in this branch I should omit -mcpu=powerpc? > -mcpu=powerpc is set when user selects CONFIG_POWERPC_CPU, in which case > CONFIG_TARGET_CPU_BOOL is set as well. > > > +endif > > +else > > BOOTCFLAGS += -m32 -mcpu=powerpc > > Same, for PPC64 I think you don't want that either, unless the > CONFIG_GENERIC_CPU has been selected in which case > CONFIG_TARGET_CPU_BOOL is not set. > > When CONFIG_TARGET_CPU_BOOL is set for PPC64 you also want > -mcpu=$(CONFIG_TARGET_CPU) I understand that this branch is called for PPC64 build with 32-bit uImage wrapper. So in this case should not be used TARGET_CPU as it would be 64-bit and not 32-bit as requited for 32-bit uImage wrapper. Anyway, in this change I'm touching only PPC32 build, so all PPC64 stay as it was before. > > endif > > +endif > > > > BOOTCFLAGS += -isystem $(shell $(BOOTCC) -print-file-name=include) > >