From: "Pali Rohár" <pali@kernel.org>
To: Christophe Leroy <christophe.leroy@csgroup.eu>
Cc: Michael Ellerman <mpe@ellerman.id.au>,
Joel Stanley <joel@jms.id.au>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] powerpc/boot: Don't always pass -mcpu=powerpc when building 32-bit uImage
Date: Sat, 27 Aug 2022 20:36:08 +0200 [thread overview]
Message-ID: <20220827183608.ezljs2houkd32764@pali> (raw)
In-Reply-To: <1da78077-a050-a391-a002-9e25eabc89d1@csgroup.eu>
On Saturday 27 August 2022 18:32:42 Christophe Leroy wrote:
> Le 27/08/2022 à 19:36, Pali Rohár a écrit :
> > On Saturday 27 August 2022 17:31:10 Christophe Leroy wrote:
> >> Le 27/08/2022 à 15:39, Pali Rohár a écrit :
> >>> For 32-bit uImage try to use CONFIG_TARGET_CPU option for -mcpu. This fixes
> >>> following compiler error when building kernel with powerpc e500 SPE capable
> >>> cross compilers:
> >>>
> >>> BOOTAS arch/powerpc/boot/crt0.o
> >>> powerpc-linux-gnuspe-gcc: error: unrecognized argument in option ‘-mcpu=powerpc’
> >>> powerpc-linux-gnuspe-gcc: note: valid arguments to ‘-mcpu=’ are: 8540 8548 native
> >>> make[1]: *** [arch/powerpc/boot/Makefile:231: arch/powerpc/boot/crt0.o] Error 1
> >>>
> >>> For 64-bit uImage and 64-bit kernels with 32-bit uImage wrapper there is no
> >>> change.
> >>>
> >>> Similar change was already introduced for the main powerpc Makefile in
> >>> commit 446cda1b21d9 ("powerpc/32: Don't always pass -mcpu=powerpc to the
> >>> compiler").
> >>>
> >>> Fixes: 40a75584e526 ("powerpc/boot: Build wrapper for an appropriate CPU")
> >>> Cc: stable@vger.kernel.org
> >>> Signed-off-by: Pali Rohár <pali@kernel.org>
> >>> ---
> >>> arch/powerpc/boot/Makefile | 8 ++++++++
> >>> 1 file changed, 8 insertions(+)
> >>>
> >>> diff --git a/arch/powerpc/boot/Makefile b/arch/powerpc/boot/Makefile
> >>> index a9cd2ea4a861..f56a5f90a5d8 100644
> >>> --- a/arch/powerpc/boot/Makefile
> >>> +++ b/arch/powerpc/boot/Makefile
> >>> @@ -44,8 +44,16 @@ else
> >>> BOOTCFLAGS += -m64 -mcpu=powerpc64
> >>> endif
> >>> else
> >>> +ifdef CONFIG_PPC32
> >>> +ifdef CONFIG_TARGET_CPU_BOOL
> >>> +BOOTCFLAGS += -m32 -mcpu=$(CONFIG_TARGET_CPU)
> >>> +else
> >>> +BOOTCFLAGS += -m32 -mcpu=powerpc
> >>
> >> You can't do that. You get here only if user has selected
> >> TOOLCHAIN_DEFAULT_CPU, in which case you don't want to for -mcpu=powerpc.
> >
> > So do I understand it correctly that in this branch I should omit -mcpu=powerpc?
>
> Correct.
Ok, I will fix it in v3.
> >
> >> -mcpu=powerpc is set when user selects CONFIG_POWERPC_CPU, in which case
> >> CONFIG_TARGET_CPU_BOOL is set as well.
> >>
> >>> +endif
> >>> +else
> >>> BOOTCFLAGS += -m32 -mcpu=powerpc
> >>
> >> Same, for PPC64 I think you don't want that either, unless the
> >> CONFIG_GENERIC_CPU has been selected in which case
> >> CONFIG_TARGET_CPU_BOOL is not set.
> >>
> >> When CONFIG_TARGET_CPU_BOOL is set for PPC64 you also want
> >> -mcpu=$(CONFIG_TARGET_CPU)
> >
> > I understand that this branch is called for PPC64 build with 32-bit
> > uImage wrapper. So in this case should not be used TARGET_CPU as it
> > would be 64-bit and not 32-bit as requited for 32-bit uImage wrapper.
>
> Why ?
>
> -mcpu=e6500 -m32 works as far as I can see.
Hm... I did not know that. Ok, if you want I will put it into
-m32 -mcpu=$(CONFIG_TARGET_CPU) branch too.
> >
> > Anyway, in this change I'm touching only PPC32 build, so all PPC64 stay
> > as it was before.
> >
> >>> endif
> >>> +endif
> >>>
> >>> BOOTCFLAGS += -isystem $(shell $(BOOTCC) -print-file-name=include)
> >>>
next prev parent reply other threads:[~2022-08-27 18:36 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-20 10:52 [PATCH] powerpc/boot: Fix compilation of uImage for e500 platforms Pali Rohár
2022-08-23 16:57 ` Christophe Leroy
2022-08-24 12:02 ` Pali Rohár
2022-08-27 13:39 ` [PATCH v2] powerpc/boot: Don't always pass -mcpu=powerpc when building 32-bit uImage Pali Rohár
2022-08-27 17:31 ` Christophe Leroy
2022-08-27 17:36 ` Pali Rohár
2022-08-27 18:32 ` Christophe Leroy
2022-08-27 18:36 ` Pali Rohár [this message]
2022-08-27 19:00 ` Pali Rohár
2022-08-28 7:23 ` Christophe Leroy
2022-08-28 9:19 ` Pali Rohár
2022-08-28 9:56 ` [PATCH v3] " Pali Rohár
2022-08-28 17:33 ` Christophe Leroy
2022-08-28 17:39 ` Christophe Leroy
2022-08-28 17:41 ` Pali Rohár
2022-08-28 17:43 ` Christophe Leroy
2022-08-29 8:54 ` Pali Rohár
2022-10-09 11:06 ` Pali Rohár
2022-11-01 22:12 ` Pali Rohár
2022-11-02 14:05 ` Christophe Leroy
2022-11-26 16:30 ` Pali Rohár
2022-12-07 13:39 ` Christophe Leroy
2022-12-08 19:16 ` Pali Rohár
2022-12-08 19:16 ` Pali Rohár
2022-12-08 19:57 ` Christophe Leroy
2022-12-24 17:44 ` Pali Rohár
2023-01-22 11:19 ` Pali Rohár
2023-01-25 7:41 ` Christophe Leroy
2023-02-20 7:28 ` Christophe Leroy
2023-02-20 8:08 ` Pali Rohár
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220827183608.ezljs2houkd32764@pali \
--to=pali@kernel.org \
--cc=benh@kernel.crashing.org \
--cc=christophe.leroy@csgroup.eu \
--cc=joel@jms.id.au \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).