From: Sascha Hauer <s.hauer@pengutronix.de>
To: Marco Felsch <m.felsch@pengutronix.de>
Cc: linux-gpio@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>,
linux-kernel@vger.kernel.org, kernel@pengutronix.de,
Bartosz Golaszewski <brgl@bgdev.pl>
Subject: Re: [PATCH 1/2] gpio: Add gpio latch driver
Date: Mon, 29 Aug 2022 16:21:35 +0200 [thread overview]
Message-ID: <20220829142135.GB24324@pengutronix.de> (raw)
In-Reply-To: <20220826055306.tdsmdambl6fjoiop@pengutronix.de>
Hi Marco,
On Fri, Aug 26, 2022 at 07:53:07AM +0200, Marco Felsch wrote:
> Hi Sascha,
>
> nice patche, please see inline.
>
> On 22-08-25, Sascha Hauer wrote:
> > This driver implements a GPIO multiplexer based on latches connected to
> > other GPIOs. A set of data GPIOs is connected to the data input of
> > multiple latches. The clock input of each latch is driven by another
> > set of GPIOs. With two 8-bit latches 10 GPIOs can be multiplexed into
> > 16 GPIOs. GPOs might be a better term as in fact the multiplexed pins
> > are output only.
> >
[snip]
> > +
> > +static void __gpio_latch_set(struct gpio_latch_priv *priv, unsigned int offset, int val)
> > +{
> > + int latch = offset / priv->n_pins;
> > + int i;
> > +
> > + if (val)
> > + priv->shadow[latch] |= BIT(offset % priv->n_pins);
> > + else
> > + priv->shadow[latch] &= ~BIT(offset % priv->n_pins);
> > +
> > + for (i = 0; i < priv->n_pins; i++)
> > + gpiod_set_value(priv->data_gpios->desc[i], priv->shadow[latch] & BIT(i));
> > +
> > + gpiod_set_value(priv->clk_gpios->desc[latch], 1);
> > + gpiod_set_value(priv->clk_gpios->desc[latch], 0);
>
> Your have two access function for _can_sleep and "can not sleep" but
> here you don't resepect it.
I thought the gpio framework would pick the right implementation
automatically. Apparently it doesn't. Will fix in v2.
Sascha
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2022-08-29 14:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-25 9:41 [PATCH 0/2] gpio: Add gpio-latch driver Sascha Hauer
2022-08-25 9:41 ` [PATCH 1/2] gpio: Add gpio latch driver Sascha Hauer
2022-08-26 5:53 ` Marco Felsch
2022-08-29 14:21 ` Sascha Hauer [this message]
2022-08-26 13:41 ` Linus Walleij
2022-08-25 9:41 ` [PATCH 2/2] dt-bindings: gpio: Add gpio-latch binding document Sascha Hauer
2022-08-26 13:37 ` Linus Walleij
2022-08-29 14:40 ` Sascha Hauer
2022-08-31 12:40 ` Linus Walleij
2022-09-01 7:53 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220829142135.GB24324@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=brgl@bgdev.pl \
--cc=kernel@pengutronix.de \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.felsch@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).