From: Bjorn Andersson <andersson@kernel.org>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>,
Qiang Zhao <qiang.zhao@nxp.com>, Li Yang <leoyang.li@nxp.com>
Cc: linux-kernel@vger.kernel.org, Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
linuxppc-dev@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH] soc: move from strlcpy with unused retval to strscpy
Date: Mon, 29 Aug 2022 16:32:15 -0500 [thread overview]
Message-ID: <20220829213215.lw233zzbvhevaqrm@builder.lan> (raw)
In-Reply-To: <20220818210106.7349-1-wsa+renesas@sang-engineering.com>
On Thu, Aug 18, 2022 at 11:01:06PM +0200, Wolfram Sang wrote:
> Follow the advice of the below link and prefer 'strscpy' in this
> subsystem. Conversion is 1:1 because the return value is not used.
> Generated by a coccinelle script.
>
> Link: https://lore.kernel.org/r/CAHk-=wgfRnXz0W3D37d01q3JFkr_i_uTL=V6A6G1oUZcprmknw@mail.gmail.com/
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
> drivers/soc/fsl/qe/qe.c | 4 ++--
Qiang, Li, would you like to merge this patch? Or could I perhaps get an
Acked-by from either of you so that I could take the patch through the
Qualcomm tree?
If you prefer:
Acked-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Regards,
Bjorn
> drivers/soc/qcom/smp2p.c | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/soc/fsl/qe/qe.c b/drivers/soc/fsl/qe/qe.c
> index b3c226eb5292..58746e570d14 100644
> --- a/drivers/soc/fsl/qe/qe.c
> +++ b/drivers/soc/fsl/qe/qe.c
> @@ -524,7 +524,7 @@ int qe_upload_firmware(const struct qe_firmware *firmware)
> * saved microcode information and put in the new.
> */
> memset(&qe_firmware_info, 0, sizeof(qe_firmware_info));
> - strlcpy(qe_firmware_info.id, firmware->id, sizeof(qe_firmware_info.id));
> + strscpy(qe_firmware_info.id, firmware->id, sizeof(qe_firmware_info.id));
> qe_firmware_info.extended_modes = be64_to_cpu(firmware->extended_modes);
> memcpy(qe_firmware_info.vtraps, firmware->vtraps,
> sizeof(firmware->vtraps));
> @@ -599,7 +599,7 @@ struct qe_firmware_info *qe_get_firmware_info(void)
> /* Copy the data into qe_firmware_info*/
> sprop = of_get_property(fw, "id", NULL);
> if (sprop)
> - strlcpy(qe_firmware_info.id, sprop,
> + strscpy(qe_firmware_info.id, sprop,
> sizeof(qe_firmware_info.id));
>
> of_property_read_u64(fw, "extended-modes",
> diff --git a/drivers/soc/qcom/smp2p.c b/drivers/soc/qcom/smp2p.c
> index d9c28a8a7cbf..e9c8030d50ee 100644
> --- a/drivers/soc/qcom/smp2p.c
> +++ b/drivers/soc/qcom/smp2p.c
> @@ -422,7 +422,7 @@ static int qcom_smp2p_outbound_entry(struct qcom_smp2p *smp2p,
> char buf[SMP2P_MAX_ENTRY_NAME] = {};
>
> /* Allocate an entry from the smem item */
> - strlcpy(buf, entry->name, SMP2P_MAX_ENTRY_NAME);
> + strscpy(buf, entry->name, SMP2P_MAX_ENTRY_NAME);
> memcpy(out->entries[out->valid_entries].name, buf, SMP2P_MAX_ENTRY_NAME);
>
> /* Make the logical entry reference the physical value */
> --
> 2.35.1
>
next prev parent reply other threads:[~2022-08-29 21:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-18 21:01 [PATCH] soc: move from strlcpy with unused retval to strscpy Wolfram Sang
2022-08-29 21:32 ` Bjorn Andersson [this message]
2022-10-18 3:15 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220829213215.lw233zzbvhevaqrm@builder.lan \
--to=andersson@kernel.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=konrad.dybcio@somainline.org \
--cc=leoyang.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=qiang.zhao@nxp.com \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).