From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0006FC0502C for ; Tue, 30 Aug 2022 06:21:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229538AbiH3GVK (ORCPT ); Tue, 30 Aug 2022 02:21:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51270 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229507AbiH3GVI (ORCPT ); Tue, 30 Aug 2022 02:21:08 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C90EB73323; Mon, 29 Aug 2022 23:21:05 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 52C6761407; Tue, 30 Aug 2022 06:21:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 93272C433D7; Tue, 30 Aug 2022 06:21:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1661840464; bh=4pblfYpA63CrE4rMWyeeR7WMMlRkZGVcfIrjeRiiXz4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=X0lVDNWwDs0piYuKSZk4VHLRFseVcxbpP6HucMF7+eCB2612CLy1kIWMwmnBeIs+c T7ibHa1Qym3Ik7wZocYQ9/Cfz//5yURLwjqVPrKFdEpjnib54SOGZb385BPqwLkloO p8CwTCO/wu1uGyVYhP8/IpHlPzNDo/3IdtlscjGpKhPMk1EpOOVSgMRWHbDbbQeicK 1ndJU+IIYlJ3giv8NHI/IIaKKK5JluMNfgJCZOHHf3cM2ntiRdc78d5eZ0dSbSEuKN s2iFapYfReXT0fu07fzYUgfe58nQLzXfRbeTn2mxzkBc4CV5TcS2Vp8UdPpFwgBLQ+ NkEEediBSO2Rg== Date: Tue, 30 Aug 2022 11:50:50 +0530 From: Manivannan Sadhasivam To: Viresh Kumar Cc: Bjorn Andersson , Bjorn Andersson , Andy Gross , Krzysztof Kozlowski , "Rafael J. Wysocki" , Rob Herring , Vincent Guittot , Johan Hovold , devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org Subject: Re: [RFC PATCH 0/4] cpufreq: qcom-hw: Move clocks to CPU node Message-ID: <20220830062050.GA7066@workstation> References: <20220715160933.GD12197@workstation> <20220718015742.uwskqo55qd67jx2w@vireshk-i7> <20220801023756.76jswkbwivuntqof@vireshk-i7> <20220830032456.z4olnogsyg32vhiz@builder.lan> <20220830054042.akj7pf366inelvpo@vireshk-i7> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220830054042.akj7pf366inelvpo@vireshk-i7> User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 30, 2022 at 11:10:42AM +0530, Viresh Kumar wrote: > On 29-08-22, 22:24, Bjorn Andersson wrote: > > Conceptually, it sounds like a good idea to express the clock feeding > > the CPU clusters, which is controlled by the OSM/EPSS. But do you > > expect the OPP framework to actually do something with the clock, or > > just to ensure that the relationship is properly described? > > No, the OPP core will never try to set the clock rate in your case, > though it will do clk_get(). > Okay. Then I think it is a fair argument to make qcom-cpufreq-hw as the clock provider for CPUs. I will send the RFC soon. Thanks, Mani > > FWIW, the possible discrepancy between the requested frequency and the > > actual frequency comes from the fact that OSM/EPSS throttles the cluster > > frequency based on a number of different factors (thermal, voltages > > ...). > > This is reported back to the kernel using the thermal pressure > > interface. It would be quite interesting to see some investigation in > > how efficient the kernel is at making use of this feedback. > > -- > viresh