From: Horatiu Vultur <horatiu.vultur@microchip.com>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>,
<UNGLinuxDriver@microchip.com>
Subject: Re: [PATCH v2 2/2] nvmem: lan9662-otp: add support.
Date: Tue, 30 Aug 2022 22:07:02 +0200 [thread overview]
Message-ID: <20220830200702.noefi7q5syrsgh52@soft-dev3-1.localhost> (raw)
In-Reply-To: <4788e399-b292-9da7-3d62-75bb0312d4b9@linaro.org>
The 08/30/2022 13:08, Srinivas Kandagatla wrote:
>
> > +static inline void lan9662_writel(void __iomem *addr, u32 val)
> > +{
> > + writel(val, addr);
> > +}
> > +
> > +static inline u32 lan9662_readl(void __iomem *addr)
> > +{
> > + return readl(addr);
> > +}
> > +
>
> Why these boiler plate functions?
It was more for the style purpose. I will remove these ones.
>
> > +static inline void lan9662_clrbits(void __iomem *addr, u32 clear)
> > +{
> > + writel(readl(addr) & ~clear, addr);
> > +}
> > +
> > +static inline void lan9662_setbits(void __iomem *addr, u32 set)
> > +{
> > + writel(readl(addr) | set, addr);
> > +}
>
> These two functions are called just once and I see no point in having a
> wrapper function for this, instead you could use them directly or use
> ./include/linux/bitfield.h helper macros.
I will remove also these ones and use them directly.
>
> > +
> > +static bool lan9662_otp_wait_flag_clear(void __iomem *reg, u32 flag)
> > +{
> > + u32 val;
> > +
> > + return readl_poll_timeout(reg, val, !(val & flag),
> > + OTP_SLEEP_US, OTP_TIMEOUT_US);
> > +}
> > +
> > +static int lan9662_otp_power(struct lan9662_otp *otp, bool up)
> > +{
> > + if (up) {
> > + lan9662_clrbits(OTP_OTP_PWR_DN(otp->base),
> > + OTP_OTP_PWR_DN_OTP_PWRDN_N);
> > + if (lan9662_otp_wait_flag_clear(OTP_OTP_STATUS(otp->base),
> > + OTP_OTP_STATUS_OTP_CPUMPEN))
> > + return -ETIMEDOUT;
> > + } else {
> > + lan9662_setbits(OTP_OTP_PWR_DN(otp->base),
> > + OTP_OTP_PWR_DN_OTP_PWRDN_N);
> > + }
> > +
> > + return 0;
> > +}
> > +
> > +static int lan9662_otp_execute(struct lan9662_otp *otp)
> > +{
> > + if (lan9662_otp_wait_flag_clear(OTP_OTP_CMD_GO(otp->base),
> > + OTP_OTP_CMD_GO_OTP_GO))
> > + return -ETIMEDOUT;
> > +
> > + if (lan9662_otp_wait_flag_clear(OTP_OTP_STATUS(otp->base),
> > + OTP_OTP_STATUS_OTP_BUSY))
> > + return -ETIMEDOUT;
> > +
> > + return 0;
> > +}
> > +
> > +static void lan9662_otp_set_address(struct lan9662_otp *otp, u32 offset)
> > +{
> > + WARN_ON(offset >= OTP_MEM_SIZE);
> > +
> would we ever hit this condition? looks like unecessary check.
That is not the case. I will remove it.
>
>
>
--
/Horatiu
prev parent reply other threads:[~2022-08-30 20:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-25 20:40 [PATCH v2 0/2] nvmem: lan9662-otpc: add support Horatiu Vultur
2022-08-25 20:40 ` [PATCH v2 1/2] dt-bindings: lan9662-otpc: document Lan9662 OTPC Horatiu Vultur
2022-08-26 6:42 ` Krzysztof Kozlowski
2022-08-26 7:31 ` Horatiu Vultur
2022-08-26 17:37 ` Krzysztof Kozlowski
2022-08-29 6:35 ` Horatiu Vultur
2022-08-30 10:10 ` Krzysztof Kozlowski
2022-08-26 16:05 ` Rob Herring
2022-08-25 20:40 ` [PATCH v2 2/2] nvmem: lan9662-otp: add support Horatiu Vultur
2022-08-26 6:43 ` Krzysztof Kozlowski
2022-08-30 12:08 ` Srinivas Kandagatla
2022-08-30 20:07 ` Horatiu Vultur [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220830200702.noefi7q5syrsgh52@soft-dev3-1.localhost \
--to=horatiu.vultur@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).