From: Guo Zhi <qtxuning1999@sjtu.edu.cn>
To: eperezma@redhat.com, jasowang@redhat.com, sgarzare@redhat.com,
mst@redhat.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kvm@vger.kernel.org, virtualization@lists.linux-foundation.org,
Guo Zhi <qtxuning1999@sjtu.edu.cn>
Subject: [RFC v3 3/7] vsock: batch buffers in tx
Date: Thu, 1 Sep 2022 13:54:30 +0800 [thread overview]
Message-ID: <20220901055434.824-4-qtxuning1999@sjtu.edu.cn> (raw)
In-Reply-To: <20220901055434.824-1-qtxuning1999@sjtu.edu.cn>
Vsock uses buffers in order, and for tx driver doesn't have to
know the length of the buffer. So we can do a batch for vsock if
in order negotiated, only write one used ring for a batch of buffers
Signed-off-by: Guo Zhi <qtxuning1999@sjtu.edu.cn>
---
drivers/vhost/vsock.c | 12 ++++++++++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/drivers/vhost/vsock.c b/drivers/vhost/vsock.c
index 368330417bde..e08fbbb5439e 100644
--- a/drivers/vhost/vsock.c
+++ b/drivers/vhost/vsock.c
@@ -497,7 +497,7 @@ static void vhost_vsock_handle_tx_kick(struct vhost_work *work)
struct vhost_vsock *vsock = container_of(vq->dev, struct vhost_vsock,
dev);
struct virtio_vsock_pkt *pkt;
- int head, pkts = 0, total_len = 0;
+ int head, pkts = 0, total_len = 0, add = 0;
unsigned int out, in;
bool added = false;
@@ -551,10 +551,18 @@ static void vhost_vsock_handle_tx_kick(struct vhost_work *work)
else
virtio_transport_free_pkt(pkt);
- vhost_add_used(vq, head, 0);
+ if (!vhost_has_feature(vq, VIRTIO_F_IN_ORDER)) {
+ vhost_add_used(vq, head, 0);
+ } else {
+ vq->heads[add].id = head;
+ vq->heads[add++].len = 0;
+ }
added = true;
} while(likely(!vhost_exceeds_weight(vq, ++pkts, total_len)));
+ /* If in order feature negotiaged, we can do a batch to increase performance */
+ if (vhost_has_feature(vq, VIRTIO_F_IN_ORDER) && added)
+ vhost_add_used_n(vq, vq->heads, add);
no_more_replies:
if (added)
vhost_signal(&vsock->dev, vq);
--
2.17.1
next prev parent reply other threads:[~2022-09-01 5:55 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-01 5:54 [RFC v3 0/7] In order support for virtio_ring, vhost and vsock Guo Zhi
2022-09-01 5:54 ` [RFC v3 1/7] vhost: expose used buffers Guo Zhi
2022-09-01 8:55 ` Eugenio Perez Martin
2022-09-07 4:21 ` Jason Wang
2022-09-08 8:43 ` Guo Zhi
2022-09-01 5:54 ` [RFC v3 2/7] vhost_test: batch used buffer Guo Zhi
2022-09-01 5:54 ` Guo Zhi [this message]
2022-09-01 9:00 ` [RFC v3 3/7] vsock: batch buffers in tx Eugenio Perez Martin
2022-09-07 4:27 ` Jason Wang
2022-09-08 8:41 ` Guo Zhi
2022-09-01 5:54 ` [RFC v3 4/7] vsock: announce VIRTIO_F_IN_ORDER in vsock Guo Zhi
2022-09-01 5:54 ` [RFC v3 5/7] virtio: unmask F_NEXT flag in desc_extra Guo Zhi
2022-09-01 6:07 ` Xuan Zhuo
2022-09-01 6:14 ` Guo Zhi
2022-09-01 5:54 ` [RFC v3 6/7] virtio: in order support for virtio_ring Guo Zhi
2022-09-01 6:10 ` Xuan Zhuo
2022-09-07 5:38 ` Jason Wang
2022-09-08 8:47 ` Guo Zhi
2022-09-08 9:36 ` Guo Zhi
2022-10-03 11:32 ` Guo Zhi
2022-09-01 5:54 ` [RFC v3 7/7] virtio: announce VIRTIO_F_IN_ORDER support Guo Zhi
2022-09-07 4:13 ` [RFC v3 0/7] In order support for virtio_ring, vhost and vsock Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220901055434.824-4-qtxuning1999@sjtu.edu.cn \
--to=qtxuning1999@sjtu.edu.cn \
--cc=eperezma@redhat.com \
--cc=jasowang@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=sgarzare@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).