From: kernel test robot <lkp@intel.com>
To: Abel Vesa <abel.vesa@linaro.org>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Amol Maheshwari <amahesh@qti.qualcomm.com>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Ekansh Gupta <quic_ekagupt@quicinc.com>
Cc: kbuild-all@lists.01.org, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-arm-msm@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
devicetree@vger.kernel.org
Subject: Re: [PATCH v2 07/10] misc: fastrpc: Add support for audiopd
Date: Sat, 3 Sep 2022 10:36:55 +0800 [thread overview]
Message-ID: <202209031027.5XvVp3U8-lkp@intel.com> (raw)
In-Reply-To: <20220902154900.3404524-8-abel.vesa@linaro.org>
Hi Abel,
I love your patch! Perhaps something to improve:
[auto build test WARNING on char-misc/char-misc-testing]
[also build test WARNING on robh/for-next linus/master v6.0-rc3 next-20220901]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Abel-Vesa/misc-fastrpc-Add-audiopd-support/20220902-235842
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git 4ec7ac90ff399b7d9af81cc8afd430a22786c61b
config: mips-randconfig-r035-20220902 (https://download.01.org/0day-ci/archive/20220903/202209031027.5XvVp3U8-lkp@intel.com/config)
compiler: mipsel-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/7036272dbe486564afd86e31ca0abf48aa1535ed
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Abel-Vesa/misc-fastrpc-Add-audiopd-support/20220902-235842
git checkout 7036272dbe486564afd86e31ca0abf48aa1535ed
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=mips SHELL=/bin/bash drivers/misc/
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
In file included from include/linux/printk.h:573,
from include/asm-generic/bug.h:22,
from arch/mips/include/asm/bug.h:42,
from include/linux/bug.h:5,
from include/linux/thread_info.h:13,
from include/asm-generic/preempt.h:5,
from ./arch/mips/include/generated/asm/preempt.h:1,
from include/linux/preempt.h:78,
from include/linux/spinlock.h:55,
from include/linux/swait.h:7,
from include/linux/completion.h:12,
from drivers/misc/fastrpc.c:5:
drivers/misc/fastrpc.c: In function 'fastrpc_init_create_static_process':
>> drivers/misc/fastrpc.c:1249:48: warning: format '%x' expects argument of type 'unsigned int', but argument 7 has type 'struct qcom_scm_vmperm *' [-Wformat=]
1249 | dev_dbg(fl->sctx->dev, "Assinging memory with phys 0x%llx size 0x%llx perms 0x%x, vmperms %x, vmcount %x\n",
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/dynamic_debug.h:134:29: note: in definition of macro '__dynamic_func_call'
134 | func(&id, ##__VA_ARGS__); \
| ^~~~~~~~~~~
include/linux/dynamic_debug.h:166:9: note: in expansion of macro '_dynamic_func_call'
166 | _dynamic_func_call(fmt,__dynamic_dev_dbg, \
| ^~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:155:9: note: in expansion of macro 'dynamic_dev_dbg'
155 | dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~
include/linux/dev_printk.h:155:30: note: in expansion of macro 'dev_fmt'
155 | dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~
drivers/misc/fastrpc.c:1249:25: note: in expansion of macro 'dev_dbg'
1249 | dev_dbg(fl->sctx->dev, "Assinging memory with phys 0x%llx size 0x%llx perms 0x%x, vmperms %x, vmcount %x\n",
| ^~~~~~~
drivers/misc/fastrpc.c:1249:116: note: format string is defined here
1249 | dev_dbg(fl->sctx->dev, "Assinging memory with phys 0x%llx size 0x%llx perms 0x%x, vmperms %x, vmcount %x\n",
| ~^
| |
| unsigned int
vim +1249 drivers/misc/fastrpc.c
1198
1199 static int fastrpc_init_create_static_process(struct fastrpc_user *fl,
1200 char __user *argp)
1201 {
1202 struct fastrpc_init_create_static init;
1203 struct fastrpc_invoke_args *args;
1204 struct fastrpc_phy_page pages[1];
1205 char *name;
1206 int err;
1207 struct {
1208 int pgid;
1209 u32 namelen;
1210 u32 pageslen;
1211 } inbuf;
1212 u32 sc;
1213
1214 args = kcalloc(FASTRPC_CREATE_STATIC_PROCESS_NARGS, sizeof(*args), GFP_KERNEL);
1215 if (!args)
1216 return -ENOMEM;
1217
1218 if (copy_from_user(&init, argp, sizeof(init))) {
1219 err = -EFAULT;
1220 goto err;
1221 }
1222
1223 if (init.namelen > INIT_FILE_NAMELEN_MAX) {
1224 err = -EINVAL;
1225 goto err;
1226 }
1227
1228 name = kzalloc(init.namelen, GFP_KERNEL);
1229 if (!name) {
1230 err = -ENOMEM;
1231 goto err;
1232 }
1233
1234 if (copy_from_user(name, (void __user *)(uintptr_t)init.name, init.namelen)) {
1235 err = -EFAULT;
1236 goto err_name;
1237 }
1238
1239 if (!fl->cctx->remote_heap) {
1240 err = fastrpc_remote_heap_alloc(fl, fl->sctx->dev, init.memlen,
1241 &fl->cctx->remote_heap);
1242 if (err)
1243 goto err_name;
1244
1245 /* Map if we have any heap VMIDs associated with this ADSP Static Process. */
1246 if (fl->cctx->vmcount) {
1247 unsigned int perms = BIT(QCOM_SCM_VMID_HLOS);
1248
> 1249 dev_dbg(fl->sctx->dev, "Assinging memory with phys 0x%llx size 0x%llx perms 0x%x, vmperms %x, vmcount %x\n",
1250 fl->cctx->remote_heap->phys, fl->cctx->remote_heap->size,
1251 perms, fl->cctx->vmperms, fl->cctx->vmcount);
1252 err = qcom_scm_assign_mem(fl->cctx->remote_heap->phys,
1253 (u64)fl->cctx->remote_heap->size, &perms,
1254 fl->cctx->vmperms, fl->cctx->vmcount);
1255 if (err) {
1256 dev_err(fl->sctx->dev, "Failed to assign memory with phys 0x%llx size 0x%llx err %d",
1257 fl->cctx->remote_heap->phys, fl->cctx->remote_heap->size, err);
1258 goto err_map;
1259 }
1260 }
1261 }
1262
1263 inbuf.pgid = fl->tgid;
1264 inbuf.namelen = init.namelen;
1265 inbuf.pageslen = 0;
1266 fl->pd = USER_PD;
1267
1268 args[0].ptr = (u64)(uintptr_t)&inbuf;
1269 args[0].length = sizeof(inbuf);
1270 args[0].fd = -1;
1271
1272 args[1].ptr = (u64)(uintptr_t)name;
1273 args[1].length = inbuf.namelen;
1274 args[1].fd = -1;
1275
1276 pages[0].addr = fl->cctx->remote_heap->phys;
1277 pages[0].size = fl->cctx->remote_heap->size;
1278
1279 args[2].ptr = (u64)(uintptr_t) pages;
1280 args[2].length = sizeof(*pages);
1281 args[2].fd = -1;
1282
1283 sc = FASTRPC_SCALARS(FASTRPC_RMID_INIT_CREATE_STATIC, 3, 0);
1284
1285 err = fastrpc_internal_invoke(fl, true, FASTRPC_INIT_HANDLE,
1286 sc, args);
1287 if (err)
1288 goto err_invoke;
1289
1290 kfree(args);
1291
1292 return 0;
1293 err_invoke:
1294 err_map:
1295 fastrpc_buf_free(fl->cctx->remote_heap);
1296 err_name:
1297 kfree(name);
1298 err:
1299 kfree(args);
1300
1301 return err;
1302 }
1303
--
0-DAY CI Kernel Test Service
https://01.org/lkp
next prev parent reply other threads:[~2022-09-03 2:38 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-02 15:48 [PATCH v2 00/10] misc: fastrpc: Add audiopd support Abel Vesa
2022-09-02 15:48 ` [PATCH v2 01/10] misc: fastrpc: Rename audio protection domain to root Abel Vesa
2022-09-02 15:48 ` [PATCH v2 02/10] misc: fastrpc: Add reserved mem support Abel Vesa
2022-09-02 15:48 ` [PATCH v2 03/10] dt-bindings: misc: fastrpc: Document memory-region property Abel Vesa
2022-09-04 19:29 ` Krzysztof Kozlowski
2022-09-05 7:53 ` Abel Vesa
2022-09-02 15:48 ` [PATCH v2 04/10] misc: fastrpc: Add fastrpc_remote_heap_alloc Abel Vesa
2022-09-02 15:48 ` [PATCH v2 05/10] misc: fastrpc: Use fastrpc_map_put in fastrpc_map_create on fail Abel Vesa
2022-09-06 14:10 ` Srinivas Kandagatla
2022-09-02 15:48 ` [PATCH v2 06/10] misc: fastrpc: Rework fastrpc_req_munmap Abel Vesa
2022-09-02 15:48 ` [PATCH v2 07/10] misc: fastrpc: Add support for audiopd Abel Vesa
2022-09-03 2:36 ` kernel test robot [this message]
2022-09-03 3:18 ` kernel test robot
2022-09-06 14:10 ` Srinivas Kandagatla
2022-09-02 15:48 ` [PATCH v2 08/10] misc: fastrpc: Safekeep mmaps on interrupted invoke Abel Vesa
2022-09-06 14:10 ` Srinivas Kandagatla
2022-09-02 15:48 ` [PATCH v2 09/10] misc: fastrpc: Add mmap request assigning for static PD pool Abel Vesa
2022-09-02 15:49 ` [PATCH v2 10/10] misc: fastrpc: Add dma_mask to fastrpc_channel_ctx Abel Vesa
2022-09-06 14:12 ` [PATCH v2 00/10] misc: fastrpc: Add audiopd support Srinivas Kandagatla
2022-09-07 10:01 ` Abel Vesa
2022-11-25 7:13 [PATCH v2 00/10] misc: fastrpc: patches for 6.2 Srinivas Kandagatla
2022-11-25 7:14 ` [PATCH v2 07/10] misc: fastrpc: Add support for audiopd Srinivas Kandagatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202209031027.5XvVp3U8-lkp@intel.com \
--to=lkp@intel.com \
--cc=abel.vesa@linaro.org \
--cc=agross@kernel.org \
--cc=amahesh@qti.qualcomm.com \
--cc=andersson@kernel.org \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=kbuild-all@lists.01.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzk@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_ekagupt@quicinc.com \
--cc=robh@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).