From: Mauro Carvalho Chehab <mchehab@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Lee Jones <lee@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Yu Chen <chenyu56@huawei.com>,
Binghui Wang <wangbinghui@hisilicon.com>,
Kishon Vijay Abraham I <kishon@ti.com>,
Vinod Koul <vkoul@kernel.org>, Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Carvalho Chehab <mchehab+huawei@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org, linux-phy@lists.infradead.org,
linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org
Subject: Re: [PATCH 1/4] dt-bindings: phy: hisilicon,hi3660-usb3: simplify example
Date: Mon, 5 Sep 2022 08:21:07 +0200 [thread overview]
Message-ID: <20220905082107.7ff83539@coco.lan> (raw)
In-Reply-To: <20220817142246.828762-2-krzysztof.kozlowski@linaro.org>
Em Wed, 17 Aug 2022 17:22:43 +0300
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> escreveu:
> syscon and simple-mfd cannot be used without device specific compatible,
> so simplify the example to fix this.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> .../bindings/phy/hisilicon,hi3660-usb3.yaml | 22 +++++--------------
> 1 file changed, 6 insertions(+), 16 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/phy/hisilicon,hi3660-usb3.yaml b/Documentation/devicetree/bindings/phy/hisilicon,hi3660-usb3.yaml
> index c2e073e26190..20b79e2e8b82 100644
> --- a/Documentation/devicetree/bindings/phy/hisilicon,hi3660-usb3.yaml
> +++ b/Documentation/devicetree/bindings/phy/hisilicon,hi3660-usb3.yaml
> @@ -41,20 +41,10 @@ additionalProperties: false
>
> examples:
> - |
> - bus {
> - #address-cells = <2>;
> - #size-cells = <2>;
> -
> - usb3_otg_bc: usb3_otg_bc@ff200000 {
> - compatible = "syscon", "simple-mfd";
> - reg = <0x0 0xff200000 0x0 0x1000>;
> -
> - usb-phy {
> - compatible = "hisilicon,hi3660-usb-phy";
> - #phy-cells = <0>;
> - hisilicon,pericrg-syscon = <&crg_ctrl>;
> - hisilicon,pctrl-syscon = <&pctrl>;
> - hisilicon,eye-diagram-param = <0x22466e4>;
> - };
> - };
> + usb-phy {
> + compatible = "hisilicon,hi3660-usb-phy";
> + #phy-cells = <0>;
> + hisilicon,pericrg-syscon = <&crg_ctrl>;
> + hisilicon,pctrl-syscon = <&pctrl>;
> + hisilicon,eye-diagram-param = <0x22466e4>;
> };
Acked-by: Mauro Carvalho Chehab <mchehab@kernel.org>
Thanks,
Mauro
next prev parent reply other threads:[~2022-09-05 6:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-17 14:22 [PATCH 0/4] mfd/phy/remoteproc: dt-bindings: syscon: be specific Krzysztof Kozlowski
2022-08-17 14:22 ` [PATCH 1/4] dt-bindings: phy: hisilicon,hi3660-usb3: simplify example Krzysztof Kozlowski
2022-09-02 17:25 ` Vinod Koul
2022-09-05 6:21 ` Mauro Carvalho Chehab [this message]
2022-08-17 14:22 ` [PATCH 2/4] dt-bindings: phy: hisilicon,hi3670-usb3: " Krzysztof Kozlowski
2022-09-02 17:26 ` Vinod Koul
2022-09-05 6:19 ` Mauro Carvalho Chehab
2022-08-17 14:22 ` [PATCH 3/4] dt-bindings: remoteproc: qcom,pil-info: add missing imem compatible Krzysztof Kozlowski
2022-08-17 14:22 ` [PATCH 4/4] dt-bindings: mfd: syscon: require specific compatible also for simple-mfd Krzysztof Kozlowski
2022-09-05 14:40 ` Lee Jones
2022-09-12 18:29 ` [PATCH 0/4] mfd/phy/remoteproc: dt-bindings: syscon: be specific Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220905082107.7ff83539@coco.lan \
--to=mchehab@kernel.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=chenyu56@huawei.com \
--cc=devicetree@vger.kernel.org \
--cc=kishon@ti.com \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=lee@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=mchehab+huawei@kernel.org \
--cc=robh+dt@kernel.org \
--cc=vkoul@kernel.org \
--cc=wangbinghui@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).