linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: "Gustavo A. R. Silva" <gustavoars@kernel.org>
Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org,
	linux-kernel@vger.kernel.org, Kees Cook <keescook@chromium.org>,
	Nathan Chancellor <nathan@kernel.org>
Subject: arch/powerpc/platforms/85xx/mpc85xx_cds.c:161:3: warning: unannotated fall-through between switch labels
Date: Tue, 6 Sep 2022 12:39:23 +0800	[thread overview]
Message-ID: <202209061224.KxORRGVg-lkp@intel.com> (raw)

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   53e99dcff61e1523ec1c3628b2d564ba15d32eb7
commit: dee2b702bcf067d7b6b62c18bdd060ff0810a800 kconfig: Add support for -Wimplicit-fallthrough
date:   10 months ago
config: powerpc-randconfig-r004-20220906 (https://download.01.org/0day-ci/archive/20220906/202209061224.KxORRGVg-lkp@intel.com/config)
compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project c55b41d5199d2394dd6cdb8f52180d8b81d809d4)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install powerpc cross compiling tool for clang build
        # apt-get install binutils-powerpc-linux-gnu
        # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=dee2b702bcf067d7b6b62c18bdd060ff0810a800
        git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
        git fetch --no-tags linus master
        git checkout dee2b702bcf067d7b6b62c18bdd060ff0810a800
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=powerpc SHELL=/bin/bash arch/powerpc/platforms/85xx/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> arch/powerpc/platforms/85xx/mpc85xx_cds.c:161:3: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough]
                   default:
                   ^
   arch/powerpc/platforms/85xx/mpc85xx_cds.c:161:3: note: insert 'break;' to avoid fall-through
                   default:
                   ^
                   break; 
   arch/powerpc/platforms/85xx/mpc85xx_cds.c:184:6: warning: no previous prototype for function 'mpc85xx_cds_fixup_bus' [-Wmissing-prototypes]
   void mpc85xx_cds_fixup_bus(struct pci_bus *bus)
        ^
   arch/powerpc/platforms/85xx/mpc85xx_cds.c:184:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   void mpc85xx_cds_fixup_bus(struct pci_bus *bus)
   ^
   static 
   2 warnings generated.


vim +161 arch/powerpc/platforms/85xx/mpc85xx_cds.c

7120438e5d82f4 Andrey Smirnov 2016-07-28  125  
7120438e5d82f4 Andrey Smirnov 2016-07-28  126  
749e80810d26c8 Roy Zang       2007-06-01  127  static void __init mpc85xx_cds_pci_irq_fixup(struct pci_dev *dev)
591f0a4287d0de Andy Fleming   2006-04-02  128  {
591f0a4287d0de Andy Fleming   2006-04-02  129  	u_char c;
749e80810d26c8 Roy Zang       2007-06-01  130  	if (dev->vendor == PCI_VENDOR_ID_VIA) {
749e80810d26c8 Roy Zang       2007-06-01  131  		switch (dev->device) {
749e80810d26c8 Roy Zang       2007-06-01  132  		case PCI_DEVICE_ID_VIA_82C586_1:
591f0a4287d0de Andy Fleming   2006-04-02  133  			/*
591f0a4287d0de Andy Fleming   2006-04-02  134  			 * U-Boot does not set the enable bits
591f0a4287d0de Andy Fleming   2006-04-02  135  			 * for the IDE device. Force them on here.
591f0a4287d0de Andy Fleming   2006-04-02  136  			 */
591f0a4287d0de Andy Fleming   2006-04-02  137  			pci_read_config_byte(dev, 0x40, &c);
591f0a4287d0de Andy Fleming   2006-04-02  138  			c |= 0x03; /* IDE: Chip Enable Bits */
591f0a4287d0de Andy Fleming   2006-04-02  139  			pci_write_config_byte(dev, 0x40, c);
591f0a4287d0de Andy Fleming   2006-04-02  140  
591f0a4287d0de Andy Fleming   2006-04-02  141  			/*
591f0a4287d0de Andy Fleming   2006-04-02  142  			 * Since only primary interface works, force the
591f0a4287d0de Andy Fleming   2006-04-02  143  			 * IDE function to standard primary IDE interrupt
591f0a4287d0de Andy Fleming   2006-04-02  144  			 * w/ 8259 offset
591f0a4287d0de Andy Fleming   2006-04-02  145  			 */
591f0a4287d0de Andy Fleming   2006-04-02  146  			dev->irq = 14;
591f0a4287d0de Andy Fleming   2006-04-02  147  			pci_write_config_byte(dev, PCI_INTERRUPT_LINE, dev->irq);
749e80810d26c8 Roy Zang       2007-06-01  148  			break;
591f0a4287d0de Andy Fleming   2006-04-02  149  		/*
591f0a4287d0de Andy Fleming   2006-04-02  150  		 * Force legacy USB interrupt routing
591f0a4287d0de Andy Fleming   2006-04-02  151  		 */
749e80810d26c8 Roy Zang       2007-06-01  152  		case PCI_DEVICE_ID_VIA_82C586_2:
749e80810d26c8 Roy Zang       2007-06-01  153  		/* There are two USB controllers.
749e80810d26c8 Roy Zang       2007-06-01  154  		 * Identify them by functon number
749e80810d26c8 Roy Zang       2007-06-01  155  		 */
8d7bc8f9d1c23f Randy Vinson   2007-07-19  156  			if (PCI_FUNC(dev->devfn) == 3)
749e80810d26c8 Roy Zang       2007-06-01  157  				dev->irq = 11;
749e80810d26c8 Roy Zang       2007-06-01  158  			else
591f0a4287d0de Andy Fleming   2006-04-02  159  				dev->irq = 10;
749e80810d26c8 Roy Zang       2007-06-01  160  			pci_write_config_byte(dev, PCI_INTERRUPT_LINE, dev->irq);
749e80810d26c8 Roy Zang       2007-06-01 @161  		default:
749e80810d26c8 Roy Zang       2007-06-01  162  			break;
591f0a4287d0de Andy Fleming   2006-04-02  163  		}
591f0a4287d0de Andy Fleming   2006-04-02  164  	}
591f0a4287d0de Andy Fleming   2006-04-02  165  }
ddd64159eb0d09 Andy Fleming   2006-08-17  166  

:::::: The code at line 161 was first introduced by commit
:::::: 749e80810d26c8d522b089718f22bb92d7834a37 [POWERPC] Remove redundant pci_read_irq_line() function for 85xx platform

:::::: TO: Roy Zang <tie-fei.zang@freescale.com>
:::::: CC: Kumar Gala <galak@kernel.crashing.org>

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

                 reply	other threads:[~2022-09-06  4:40 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202209061224.KxORRGVg-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=gustavoars@kernel.org \
    --cc=kbuild-all@lists.01.org \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=llvm@lists.linux.dev \
    --cc=nathan@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).