From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B11C3ECAAA1 for ; Fri, 9 Sep 2022 23:07:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231756AbiIIXHF (ORCPT ); Fri, 9 Sep 2022 19:07:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48296 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231365AbiIIXGh (ORCPT ); Fri, 9 Sep 2022 19:06:37 -0400 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E5E07113C5E for ; Fri, 9 Sep 2022 16:06:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1662764795; x=1694300795; h=from:to:cc:subject:date:message-id:in-reply-to: references; bh=ph2e/rZv3NU9Gpgu/xHvmk0/dbumZf1WgNIx8DuCq7c=; b=b/Is0rM6YF9A6hHBaYOwsZnTaTsPDi76V8P6+bwPKkgqqll8/ebKFPry nx2Nywzi4FSbnPMTARQIxoNRO4AlQ8LZj/RxUldX2RB5Dex8+uOTwBsTE edjW2qprm9vReGgZvMkyvudrtWTPOxz/NT4S/TKIHvkYx3mu0ndhN5QbI blpLG5SjvFhXaKPPj3iH6aVtpEOb//Nk7odww8XxA0B33iHdYA8CuKq83 p9N6UkYuhbVyUacRRr6iTGZYPygyGMlVDftoG/IU1tC9HV5RM/AHTiQyR s6dhMlHCn3YjOtim96wHmnLyOK3SL6+DJuoeEsEp/kJVeW8n73CJoB7tf g==; X-IronPort-AV: E=McAfee;i="6500,9779,10465"; a="298386913" X-IronPort-AV: E=Sophos;i="5.93,304,1654585200"; d="scan'208";a="298386913" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Sep 2022 16:06:34 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,304,1654585200"; d="scan'208";a="677355003" Received: from ranerica-svr.sc.intel.com ([172.25.110.23]) by fmsmga008.fm.intel.com with ESMTP; 09 Sep 2022 16:06:33 -0700 From: Ricardo Neri To: "Peter Zijlstra (Intel)" , Juri Lelli , Vincent Guittot Cc: Ricardo Neri , "Ravi V. Shankar" , Ben Segall , Daniel Bristot de Oliveira , Dietmar Eggemann , Len Brown , Mel Gorman , "Rafael J. Wysocki" , Srinivas Pandruvada , Steven Rostedt , Tim Chen , Valentin Schneider , x86@kernel.org, linux-kernel@vger.kernel.org, Ricardo Neri , "Tim C . Chen" Subject: [RFC PATCH 10/23] sched/fair: Use classes of tasks when selecting a busiest runqueue Date: Fri, 9 Sep 2022 16:11:52 -0700 Message-Id: <20220909231205.14009-11-ricardo.neri-calderon@linux.intel.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20220909231205.14009-1-ricardo.neri-calderon@linux.intel.com> References: <20220909231205.14009-1-ricardo.neri-calderon@linux.intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org For two runqueues of equal priority and equal number of running of tasks, select the one whose current task would have the highest task class score if placed on the destination CPU. Cc: Ben Segall Cc: Daniel Bristot de Oliveira Cc: Dietmar Eggemann Cc: Len Brown Cc: Mel Gorman Cc: Rafael J. Wysocki Cc: Srinivas Pandruvada Cc: Steven Rostedt Cc: Tim C. Chen Cc: Valentin Schneider Cc: x86@kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Ricardo Neri --- kernel/sched/fair.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 7368a0b453ee..085b1f75d90b 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -10009,6 +10009,7 @@ static struct rq *find_busiest_queue(struct lb_env *env, int i; for_each_cpu_and(i, sched_group_span(group), env->cpus) { + int busiest_class_delta_score = INT_MIN; unsigned long capacity, load, util; unsigned int nr_running; enum fbq_type rt; @@ -10118,6 +10119,20 @@ static struct rq *find_busiest_queue(struct lb_env *env, if (busiest_nr < nr_running) { busiest_nr = nr_running; busiest = rq; + } else if (sched_task_classes_enabled() && + busiest_nr == nr_running) { + int curr_class_delta_score; + + curr_class_delta_score = arch_get_task_class_score(rq->curr->class, + env->dst_cpu) - + arch_get_task_class_score(rq->curr->class, + cpu_of(rq)); + + if (busiest_class_delta_score < curr_class_delta_score) { + busiest_class_delta_score = curr_class_delta_score; + busiest_nr = nr_running; + busiest = rq; + } } break; -- 2.25.1