linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH -next] clk: davinci: cfgchip: Use dev_err_probe() helper
@ 2022-09-13  3:22 Yang Yingliang
  2022-09-13 15:12 ` David Lechner
  2022-09-30 20:47 ` Stephen Boyd
  0 siblings, 2 replies; 3+ messages in thread
From: Yang Yingliang @ 2022-09-13  3:22 UTC (permalink / raw)
  To: linux-kernel, linux-clk; +Cc: david, nsekhar, mturquette, sboyd

dev_err() can be replace with dev_err_probe() which will check if error
code is -EPROBE_DEFER.

Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
 drivers/clk/davinci/da8xx-cfgchip.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/clk/davinci/da8xx-cfgchip.c b/drivers/clk/davinci/da8xx-cfgchip.c
index 77d18276bfe8..4103d605e804 100644
--- a/drivers/clk/davinci/da8xx-cfgchip.c
+++ b/drivers/clk/davinci/da8xx-cfgchip.c
@@ -510,8 +510,7 @@ da8xx_cfgchip_register_usb0_clk48(struct device *dev,
 
 	fck_clk = devm_clk_get(dev, "fck");
 	if (IS_ERR(fck_clk)) {
-		if (PTR_ERR(fck_clk) != -EPROBE_DEFER)
-			dev_err(dev, "Missing fck clock\n");
+		dev_err_probe(dev, PTR_ERR(fck_clk), "Missing fck clock\n");
 		return ERR_CAST(fck_clk);
 	}
 
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH -next] clk: davinci: cfgchip: Use dev_err_probe() helper
  2022-09-13  3:22 [PATCH -next] clk: davinci: cfgchip: Use dev_err_probe() helper Yang Yingliang
@ 2022-09-13 15:12 ` David Lechner
  2022-09-30 20:47 ` Stephen Boyd
  1 sibling, 0 replies; 3+ messages in thread
From: David Lechner @ 2022-09-13 15:12 UTC (permalink / raw)
  To: Yang Yingliang, linux-kernel, linux-clk; +Cc: nsekhar, mturquette, sboyd

On 9/12/22 10:22 PM, Yang Yingliang wrote:
> dev_err() can be replace with dev_err_probe() which will check if error
> code is -EPROBE_DEFER.
> 
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---

Reviewed-by: David Lechner <david@lechnology.com>



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH -next] clk: davinci: cfgchip: Use dev_err_probe() helper
  2022-09-13  3:22 [PATCH -next] clk: davinci: cfgchip: Use dev_err_probe() helper Yang Yingliang
  2022-09-13 15:12 ` David Lechner
@ 2022-09-30 20:47 ` Stephen Boyd
  1 sibling, 0 replies; 3+ messages in thread
From: Stephen Boyd @ 2022-09-30 20:47 UTC (permalink / raw)
  To: Yang Yingliang, linux-clk, linux-kernel; +Cc: david, nsekhar, mturquette

Quoting Yang Yingliang (2022-09-12 20:22:28)
> dev_err() can be replace with dev_err_probe() which will check if error
> code is -EPROBE_DEFER.
> 
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---

Applied to clk-next

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-09-30 20:47 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-13  3:22 [PATCH -next] clk: davinci: cfgchip: Use dev_err_probe() helper Yang Yingliang
2022-09-13 15:12 ` David Lechner
2022-09-30 20:47 ` Stephen Boyd

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).