From: Rob Herring <robh@kernel.org>
To: Alex Helms <alexander.helms.jy@renesas.com>
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-clk@vger.kernel.org, sboyd@kernel.org,
mturquette@baylibre.com, geert+renesas@glider.be
Subject: Re: [PATCH 1/2] dt-bindings: clock: Add bindings for Renesas ProXO
Date: Thu, 15 Sep 2022 07:08:44 -0500 [thread overview]
Message-ID: <20220915120844.GA996386-robh@kernel.org> (raw)
In-Reply-To: <20220914211809.22500-2-alexander.helms.jy@renesas.com>
On Wed, Sep 14, 2022 at 02:18:08PM -0700, Alex Helms wrote:
> Add dt bindings for the Renesas ProXO oscillator.
>
> Signed-off-by: Alex Helms <alexander.helms.jy@renesas.com>
> ---
> .../bindings/clock/renesas,proxo.yaml | 50 +++++++++++++++++++
> MAINTAINERS | 5 ++
> 2 files changed, 55 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/clock/renesas,proxo.yaml
>
> diff --git a/Documentation/devicetree/bindings/clock/renesas,proxo.yaml b/Documentation/devicetree/bindings/clock/renesas,proxo.yaml
> new file mode 100644
> index 000000000..2ae131431
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/renesas,proxo.yaml
> @@ -0,0 +1,50 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/clock/renesas,versaclock7.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Renesas ProXO Oscillator Device Tree Bindings
> +
> +maintainers:
> + - Alex Helms <alexander.helms.jy@renesas.com>
> +
> +description: |
Don't need '|' if no formatting to preserve.
> + Renesas ProXO is a family of programmable ultra-low phase noise
> + quartz-based oscillators.
Are they all the same from a s/w standpoint. If not you need specific
compatibles for the differences.
> +
> +properties:
> + '#clock-cells':
> + const: 0
> +
> + compatible:
> + enum:
> + - renesas,proxo-xp
> +
> + reg:
> + maxItems: 1
> +
> + renesas,xtal:
> + description: Internal crystal frequency, default is 50000000 (50MHz)
> + $ref: /schemas/types.yaml#/definitions/uint32
Use 'clock-frequency'.
> +
> +required:
> + - '#clock-cells'
> + - compatible
> + - reg
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + i2c@0 {
i2c {
> + reg = <0x0 0x100>;
Drop
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + proxo: proxo@55 {
clock-controller@55
> + compatible = "renesas,proxo-xp";
> + reg = <0x55>;
> + #clock-cells = <0>;
> + };
> + };
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 350102355..d52a8a5d2 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -16080,6 +16080,11 @@ S: Supported
> F: Documentation/devicetree/bindings/iio/adc/renesas,rzg2l-adc.yaml
> F: drivers/iio/adc/rzg2l_adc.c
>
> +RENESAS PROXO CLOCK DRIVER
> +M: Alex Helms <alexander.helms.jy@renesas.com>
> +S: Maintained
> +F: Documentation/devicetree/bindings/clock/renesas,proxo.yaml
> +
> RESET CONTROLLER FRAMEWORK
> M: Philipp Zabel <p.zabel@pengutronix.de>
> S: Maintained
> --
> 2.30.2
>
>
next prev parent reply other threads:[~2022-09-15 12:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-14 21:18 [PATCH 0/2] Add support for Renesas ProXO XP oscillator Alex Helms
2022-09-14 21:18 ` [PATCH 1/2] dt-bindings: clock: Add bindings for Renesas ProXO Alex Helms
2022-09-15 9:36 ` Krzysztof Kozlowski
2022-09-15 12:08 ` Rob Herring [this message]
2022-09-22 18:06 ` Alex Helms
2022-10-28 23:55 ` Krzysztof Kozlowski
2022-09-14 21:18 ` [PATCH 2/2] clk: Add support for Renesas ProXO oscillator Alex Helms
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220915120844.GA996386-robh@kernel.org \
--to=robh@kernel.org \
--cc=alexander.helms.jy@renesas.com \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).