From: Vincent Guittot <vincent.guittot@linaro.org>
To: mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com,
dietmar.eggemann@arm.com, rostedt@goodmis.org,
bsegall@google.com, mgorman@suse.de, bristot@redhat.com,
vschneid@redhat.com, linux-kernel@vger.kernel.org,
parth@linux.ibm.com
Cc: qais.yousef@arm.com, chris.hyser@oracle.com,
valentin.schneider@arm.com, patrick.bellasi@matbug.net,
David.Laight@aculab.com, pjt@google.com, pavel@ucw.cz,
tj@kernel.org, qperret@google.com, tim.c.chen@linux.intel.com,
joshdon@google.com, Vincent Guittot <vincent.guittot@linaro.org>
Subject: [PATCH v4 4/8] sched/core: Add permission checks for setting the latency_nice value
Date: Fri, 16 Sep 2022 10:03:01 +0200 [thread overview]
Message-ID: <20220916080305.29574-5-vincent.guittot@linaro.org> (raw)
In-Reply-To: <20220916080305.29574-1-vincent.guittot@linaro.org>
From: Parth Shah <parth@linux.ibm.com>
Since the latency_nice uses the similar infrastructure as NICE, use the
already existing CAP_SYS_NICE security checks for the latency_nice. This
should return -EPERM for the non-root user when trying to set the task
latency_nice value to any lower than the current value.
Signed-off-by: Parth Shah <parth@linux.ibm.com>
[rebase]
Signed-off-by: Vincent Guittot <vincent.guittot@linaro.org>
---
kernel/sched/core.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index 2015e7d1f8b2..3c79c5419d1b 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -7444,6 +7444,10 @@ static int __sched_setscheduler(struct task_struct *p,
return -EINVAL;
if (attr->sched_latency_nice < MIN_LATENCY_NICE)
return -EINVAL;
+ /* Use the same security checks as NICE */
+ if (attr->sched_latency_nice < p->latency_nice &&
+ !capable(CAP_SYS_NICE))
+ return -EPERM;
}
if (pi)
--
2.17.1
next prev parent reply other threads:[~2022-09-16 8:04 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-16 8:02 [PATCH v4 0/8] Add latency priority for CFS class Vincent Guittot
2022-09-16 8:02 ` [PATCH v4 1/8] sched: Introduce latency-nice as a per-task attribute Vincent Guittot
2022-09-16 8:02 ` [PATCH v4 2/8] sched/core: Propagate parent task's latency requirements to the child task Vincent Guittot
2022-09-16 8:03 ` [PATCH v4 3/8] sched: Allow sched_{get,set}attr to change latency_nice of the task Vincent Guittot
2022-09-16 8:03 ` Vincent Guittot [this message]
2022-09-19 8:52 ` [PATCH v4 4/8] sched/core: Add permission checks for setting the latency_nice value timj
2022-09-19 8:52 ` timj
2022-09-19 12:41 ` Vincent Guittot
2022-09-20 10:18 ` Tim Janik
2022-09-20 14:56 ` Vincent Guittot
2022-09-21 16:11 ` Vincent Guittot
2022-09-16 8:03 ` [PATCH v4 5/8] sched/fair: Take into account latency priority at wakeup Vincent Guittot
[not found] ` <20220916120245.2951-1-hdanton@sina.com>
2022-09-16 13:36 ` Vincent Guittot
[not found] ` <20220917225819.817-1-hdanton@sina.com>
2022-09-18 10:46 ` Vincent Guittot
[not found] ` <20220920113238.1176-1-hdanton@sina.com>
2022-09-20 15:17 ` Vincent Guittot
2022-09-19 10:05 ` Dietmar Eggemann
2022-09-19 15:39 ` Vincent Guittot
2022-09-20 13:18 ` Dietmar Eggemann
2022-09-20 15:49 ` Vincent Guittot
2022-09-21 22:41 ` Dietmar Eggemann
2022-09-22 7:12 ` Vincent Guittot
2022-09-22 16:50 ` Dietmar Eggemann
2022-09-23 6:01 ` Vincent Guittot
2022-09-16 8:03 ` [PATCH v4 6/8] sched/fair: Add sched group latency support Vincent Guittot
2022-09-19 11:55 ` Dietmar Eggemann
2022-09-19 15:49 ` Vincent Guittot
2022-09-19 17:34 ` Tejun Heo
2022-09-20 7:03 ` Vincent Guittot
2022-09-21 16:07 ` Qais Yousef
2022-09-21 16:48 ` Tejun Heo
2022-09-21 17:02 ` Vincent Guittot
2022-09-21 17:12 ` Tejun Heo
2022-09-22 6:40 ` Vincent Guittot
2022-09-22 10:49 ` Qais Yousef
2022-09-20 18:17 ` Dietmar Eggemann
2022-09-21 7:48 ` Vincent Guittot
2022-09-19 17:34 ` Tejun Heo
2022-09-20 7:02 ` Vincent Guittot
2022-09-16 8:03 ` [PATCH v4 7/8] sched/core: support latency priority with sched core Vincent Guittot
2022-09-16 8:03 ` [PATCH v4 8/8] sched/fair: Add latency list Vincent Guittot
2022-09-21 16:08 ` [PATCH v4 0/8] Add latency priority for CFS class Qais Yousef
2022-09-22 7:19 ` Vincent Guittot
2022-09-22 11:00 ` Qais Yousef
2022-09-22 13:03 ` Vincent Guittot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220916080305.29574-5-vincent.guittot@linaro.org \
--to=vincent.guittot@linaro.org \
--cc=David.Laight@aculab.com \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=chris.hyser@oracle.com \
--cc=dietmar.eggemann@arm.com \
--cc=joshdon@google.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=parth@linux.ibm.com \
--cc=patrick.bellasi@matbug.net \
--cc=pavel@ucw.cz \
--cc=peterz@infradead.org \
--cc=pjt@google.com \
--cc=qais.yousef@arm.com \
--cc=qperret@google.com \
--cc=rostedt@goodmis.org \
--cc=tim.c.chen@linux.intel.com \
--cc=tj@kernel.org \
--cc=valentin.schneider@arm.com \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).