From: Raul E Rangel <rrangel@chromium.org>
To: linux-acpi@vger.kernel.org, linux-input@vger.kernel.org
Cc: timvp@google.com, hdegoede@redhat.com,
andriy.shevchenko@linux.intel.com, rafael@kernel.org,
mario.limonciello@amd.com, jingle.wu@emc.com.tw,
mika.westerberg@linux.intel.com, dmitry.torokhov@gmail.com,
linus.walleij@linaro.org, Raul E Rangel <rrangel@chromium.org>,
linux-kernel@vger.kernel.org
Subject: [PATCH v4 11/13] Input: elan_i2c - Don't set wake_capable and wake_irq
Date: Mon, 19 Sep 2022 09:59:13 -0600 [thread overview]
Message-ID: <20220919095504.v4.11.I7309b8f322082437b93581c6e2953886eeb998d7@changeid> (raw)
In-Reply-To: <20220919155916.1044219-1-rrangel@chromium.org>
The i2c-core will now handle setting the wake_irq and wake capability
for DT and ACPI systems.
Signed-off-by: Raul E Rangel <rrangel@chromium.org>
---
(no changes since v2)
Changes in v2:
- I chose not to keep the legacy code around since systems without DT or ACPI should be rare.
drivers/input/mouse/elan_i2c_core.c | 16 ----------------
1 file changed, 16 deletions(-)
diff --git a/drivers/input/mouse/elan_i2c_core.c b/drivers/input/mouse/elan_i2c_core.c
index 3947474e93d16a..b25b94aba3e88e 100644
--- a/drivers/input/mouse/elan_i2c_core.c
+++ b/drivers/input/mouse/elan_i2c_core.c
@@ -1332,22 +1332,6 @@ static int elan_probe(struct i2c_client *client,
}
}
- /*
- * Systems using device tree should set up wakeup via DTS,
- * the rest will configure device as wakeup source by default.
- */
- if (!dev->of_node)
- device_init_wakeup(dev, true);
-
- /*
- * The wake IRQ should be declared via device tree instead of assuming
- * the IRQ can wake the system. This is here for legacy reasons and
- * will be removed once the i2c-core supports querying ACPI for wake
- * capabilities.
- */
- if (!dev->power.wakeirq)
- dev_pm_set_wake_irq(dev, client->irq);
-
return 0;
}
--
2.37.3.968.ga6b4b080e4-goog
next prev parent reply other threads:[~2022-09-19 16:01 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-19 15:59 [PATCH v4 00/13] acpi: i2c: Use SharedAndWake and ExclusiveAndWake to enable wake irq Raul E Rangel
2022-09-19 15:59 ` [PATCH v4 01/13] HID: i2c-hid: Use PM subsystem to manage " Raul E Rangel
2022-09-19 15:59 ` [PATCH v4 02/13] Input: elan_i2c - " Raul E Rangel
2022-09-19 15:59 ` [PATCH v4 03/13] Input: elants_i2c " Raul E Rangel
2022-09-19 15:59 ` [PATCH v4 04/13] Input: raydium_ts_i2c " Raul E Rangel
2022-09-19 15:59 ` [PATCH v4 05/13] gpiolib: acpi: Add wake_capable variants of acpi_dev_gpio_irq_get Raul E Rangel
2022-09-19 15:59 ` [PATCH v4 06/13] ACPI: resources: Add wake_capable parameter to acpi_dev_irq_flags Raul E Rangel
2022-09-20 12:35 ` Andy Shevchenko
2022-09-19 15:59 ` [PATCH v4 07/13] i2c: acpi: Use ACPI wake capability bit to set wake_irq Raul E Rangel
2022-09-20 12:32 ` Andy Shevchenko
2022-09-21 15:18 ` Raul Rangel
2022-09-22 9:44 ` Andy Shevchenko
2022-09-19 15:59 ` [PATCH v4 08/13] ACPI: PM: Take wake IRQ into consideration when entering suspend-to-idle Raul E Rangel
2022-09-19 15:59 ` [PATCH v4 09/13] HID: i2c-hid: acpi: Stop setting wakeup_capable Raul E Rangel
2022-09-19 15:59 ` [PATCH v4 10/13] HID: i2c-hid: Don't set wake_capable and wake_irq Raul E Rangel
2022-09-19 15:59 ` Raul E Rangel [this message]
2022-09-19 15:59 ` [PATCH v4 12/13] Input: elants_i2c - " Raul E Rangel
2022-09-19 15:59 ` [PATCH v4 13/13] Input: raydium_ts_i2c " Raul E Rangel
2022-09-20 10:42 ` [PATCH v4 00/13] acpi: i2c: Use SharedAndWake and ExclusiveAndWake to enable wake irq Benjamin Tissoires
2022-09-21 15:33 ` Raul Rangel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220919095504.v4.11.I7309b8f322082437b93581c6e2953886eeb998d7@changeid \
--to=rrangel@chromium.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=dmitry.torokhov@gmail.com \
--cc=hdegoede@redhat.com \
--cc=jingle.wu@emc.com.tw \
--cc=linus.walleij@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=mika.westerberg@linux.intel.com \
--cc=rafael@kernel.org \
--cc=timvp@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).