From: kernel test robot <lkp@intel.com>
To: Yu Kuai <yukuai1@huaweicloud.com>, axboe@kernel.dk
Cc: kbuild-all@lists.01.org, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org, yukuai3@huawei.com,
yukuai1@huaweicloud.com, yi.zhang@huawei.com
Subject: Re: [PATCH -next 1/3] wbt: don't show valid wbt_lat_usec in sysfs while wbt is disabled
Date: Mon, 19 Sep 2022 12:28:15 +0800 [thread overview]
Message-ID: <202209191232.Nwt56uMD-lkp@intel.com> (raw)
In-Reply-To: <20220919014939.175497-2-yukuai1@huaweicloud.com>
Hi Yu,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on next-20220916]
url: https://github.com/intel-lab-lkp/linux/commits/Yu-Kuai/blk-wbt-simple-improvment-to-enable-wbt-correctly/20220919-094019
base: d5538ab91d3a9a237805be6f8c6c272af2987995
config: parisc-randconfig-r021-20220919 (https://download.01.org/0day-ci/archive/20220919/202209191232.Nwt56uMD-lkp@intel.com/config)
compiler: hppa-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/dd5a7be692b8fc9794f29648d0805a2d65b9c4de
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Yu-Kuai/blk-wbt-simple-improvment-to-enable-wbt-correctly/20220919-094019
git checkout dd5a7be692b8fc9794f29648d0805a2d65b9c4de
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=parisc SHELL=/bin/bash
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
block/blk-sysfs.c: In function 'queue_wb_lat_show':
>> block/blk-sysfs.c:475:15: error: implicit declaration of function 'wbt_disabled'; did you mean 'irqs_disabled'? [-Werror=implicit-function-declaration]
475 | lat = wbt_disabled(q) ? 0 : div_u64(wbt_get_min_lat(q), 1000);
| ^~~~~~~~~~~~
| irqs_disabled
cc1: some warnings being treated as errors
vim +475 block/blk-sysfs.c
467
468 static ssize_t queue_wb_lat_show(struct request_queue *q, char *page)
469 {
470 u64 lat;
471
472 if (!wbt_rq_qos(q))
473 return -EINVAL;
474
> 475 lat = wbt_disabled(q) ? 0 : div_u64(wbt_get_min_lat(q), 1000);
476
477 return sprintf(page, "%llu\n", lat);
478 }
479
--
0-DAY CI Kernel Test Service
https://01.org/lkp
next prev parent reply other threads:[~2022-09-19 4:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-19 1:49 [PATCH -next 0/3] blk-wbt: simple improvment to enable wbt correctly Yu Kuai
2022-09-19 1:49 ` [PATCH -next 1/3] wbt: don't show valid wbt_lat_usec in sysfs while wbt is disabled Yu Kuai
2022-09-19 4:28 ` kernel test robot [this message]
2022-09-19 6:34 ` Yu Kuai
2022-09-19 5:49 ` kernel test robot
2022-09-19 1:49 ` [PATCH -next 2/3] block: add a helper to check elevator name Yu Kuai
2022-09-19 1:49 ` [PATCH -next 3/3] blk-wbt: don't enable throttling if default elevator is bfq Yu Kuai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202209191232.Nwt56uMD-lkp@intel.com \
--to=lkp@intel.com \
--cc=axboe@kernel.dk \
--cc=kbuild-all@lists.01.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yi.zhang@huawei.com \
--cc=yukuai1@huaweicloud.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).