From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8CA3ECAAA1 for ; Mon, 19 Sep 2022 17:50:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231206AbiISRut (ORCPT ); Mon, 19 Sep 2022 13:50:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37724 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230337AbiISRuo (ORCPT ); Mon, 19 Sep 2022 13:50:44 -0400 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5D8A241D1F for ; Mon, 19 Sep 2022 10:50:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1663609843; x=1695145843; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=kR8qyX1wDq4ckI2iLTSjTnUv5thwS03UGveFT81cs5I=; b=bV+SLyPSR2LJTDZWaNdmkipzaxSXi5Wkv5/hRxzrA+ufNMRVhuxPNwrz ihcoB9005zZlqqiGUr3lT/dtOIu4Crify0VROGTfqtPMxT5ACiPEZ0AOP Fuk4jVs4Kdu7QzeGNbd9EiGyhiPkRMSem1ji42JD9vooeQ7MqFbdjlpRY aXWFVPCCYnFHlBGR5RzMHqVIzrFYJTHnz58dsj/Hrw1sUJLyc22lpgb0J NbWjWW7jVE4p4cc5EyNg1bfk8KBAWBrsEo9wXfQQIV1x5dQXUJismi4k4 LanL09zwjK/LoLza4jc8kaiLLzVq/zGT6QR8nmh/PD+JQgmqIP+RIFvcj g==; X-IronPort-AV: E=McAfee;i="6500,9779,10475"; a="363429124" X-IronPort-AV: E=Sophos;i="5.93,328,1654585200"; d="scan'208";a="363429124" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Sep 2022 10:50:42 -0700 X-IronPort-AV: E=Sophos;i="5.93,328,1654585200"; d="scan'208";a="863658371" Received: from bard-ubuntu.sh.intel.com ([10.239.185.57]) by fmsmga006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Sep 2022 10:50:41 -0700 From: Bard Liao To: alsa-devel@alsa-project.org, vkoul@kernel.org Cc: vinod.koul@linaro.org, linux-kernel@vger.kernel.org, pierre-louis.bossart@linux.intel.com, bard.liao@intel.com Subject: [PATCH 01/11] soundwire: intel: fix error handling on dai registration issues Date: Tue, 20 Sep 2022 01:57:11 +0800 Message-Id: <20220919175721.354679-2-yung-chuan.liao@linux.intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220919175721.354679-1-yung-chuan.liao@linux.intel.com> References: <20220919175721.354679-1-yung-chuan.liao@linux.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Pierre-Louis Bossart The call to intel_register_dai() may fail because of memory allocation issues or problems reported by the ASoC core. In all cases, when a error is thrown the component is not registered, it's invalid to unregister it. Signed-off-by: Pierre-Louis Bossart Reviewed-by: Rander Wang Signed-off-by: Bard Liao --- drivers/soundwire/intel.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/soundwire/intel.c b/drivers/soundwire/intel.c index 01be62fa6c83..3bb29bc00d5a 100644 --- a/drivers/soundwire/intel.c +++ b/drivers/soundwire/intel.c @@ -1432,7 +1432,6 @@ int intel_link_startup(struct auxiliary_device *auxdev) ret = intel_register_dai(sdw); if (ret) { dev_err(dev, "DAI registration failed: %d\n", ret); - snd_soc_unregister_component(dev); goto err_interrupt; } -- 2.25.1