From: kernel test robot <lkp@intel.com>
To: Liu Shixin <liushixin2@huawei.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org,
Linux Memory Management List <linux-mm@kvack.org>,
linux-kernel@vger.kernel.org, Liu Shixin <liushixin2@huawei.com>,
Kefeng Wang <wangkefeng.wang@huawei.com>
Subject: Re: [PATCH 5/9] mm/mm_init.c: use hotplug_memory_notifier() directly
Date: Tue, 20 Sep 2022 02:54:50 +0800 [thread overview]
Message-ID: <202209200223.T0pXU4pA-lkp@intel.com> (raw)
In-Reply-To: <20220919083152.1824305-6-liushixin2@huawei.com>
Hi Liu,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on akpm-mm/mm-everything]
url: https://github.com/intel-lab-lkp/linux/commits/Liu-Shixin/mm-Use-hotplug_memory_notifier-instead-of-register_hotmemory_notifier/20220919-160043
base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything
config: arm64-randconfig-r036-20220919 (https://download.01.org/0day-ci/archive/20220920/202209200223.T0pXU4pA-lkp@intel.com/config)
compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project 791a7ae1ba3efd6bca96338e10ffde557ba83920)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm64 cross compiling tool for clang build
# apt-get install binutils-aarch64-linux-gnu
# https://github.com/intel-lab-lkp/linux/commit/33c4e50ed97460db120701f262ae1814509ba982
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Liu-Shixin/mm-Use-hotplug_memory_notifier-instead-of-register_hotmemory_notifier/20220919-160043
git checkout 33c4e50ed97460db120701f262ae1814509ba982
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bash
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
>> mm/mm_init.c:184:26: error: expected identifier or '('
hotplug_memory_notifier(&mm_compute_batch_notifier, IPC_CALLBACK_PRI);
^
>> mm/mm_init.c:184:2: error: use of undeclared identifier 'mm_compute_batch_notifier_mem_nb'
hotplug_memory_notifier(&mm_compute_batch_notifier, IPC_CALLBACK_PRI);
^
include/linux/memory.h:167:28: note: expanded from macro 'hotplug_memory_notifier'
register_memory_notifier(&fn##_mem_nb); \
^
<scratch space>:31:1: note: expanded from here
mm_compute_batch_notifier_mem_nb
^
2 errors generated.
vim +184 mm/mm_init.c
180
181 static int __init mm_compute_batch_init(void)
182 {
183 mm_compute_batch(sysctl_overcommit_memory);
> 184 hotplug_memory_notifier(&mm_compute_batch_notifier, IPC_CALLBACK_PRI);
185 return 0;
186 }
187
--
0-DAY CI Kernel Test Service
https://01.org/lkp
next prev parent reply other threads:[~2022-09-19 18:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-19 8:31 [PATCH 0/9] mm: Use hotplug_memory_notifier() instead of register_hotmemory_notifier() Liu Shixin
2022-09-19 8:31 ` [PATCH 1/9] cgroup/cpuset: use hotplug_memory_notifier() directly Liu Shixin
2022-09-19 8:31 ` [PATCH 2/9] fs/proc/kcore.c: " Liu Shixin
2022-09-19 8:31 ` [PATCH 3/9] mm/slub.c: " Liu Shixin
2022-09-19 8:31 ` [PATCH 4/9] mm/mmap: " Liu Shixin
2022-09-19 16:43 ` kernel test robot
2022-09-19 8:31 ` [PATCH 5/9] mm/mm_init.c: " Liu Shixin
2022-09-19 18:54 ` kernel test robot [this message]
2022-09-19 8:31 ` [PATCH 6/9] ACPI: HMAT: " Liu Shixin
2022-09-19 8:31 ` [PATCH 7/9] memory: remove unused register_hotmemory_notifier() Liu Shixin
2022-09-19 8:31 ` [PATCH 8/9] memory: replace IPC_CALLBACK_PRI with MM_BATCH_CALLBACK_PRI Liu Shixin
2022-09-19 8:31 ` [PATCH 9/9] memory: clean up hotplug memory callback priority Liu Shixin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202209200223.T0pXU4pA-lkp@intel.com \
--to=lkp@intel.com \
--cc=akpm@linux-foundation.org \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=liushixin2@huawei.com \
--cc=llvm@lists.linux.dev \
--cc=wangkefeng.wang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).