linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Greg KH <greg@kroah.com>, Johan Hovold <johan@kernel.org>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
	"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
	"Linux Next Mailing List" <linux-next@vger.kernel.org>
Subject: linux-next: manual merge of the tty tree with the usb-serial tree
Date: Wed, 21 Sep 2022 15:11:09 +1000	[thread overview]
Message-ID: <20220921151109.174cad24@canb.auug.org.au> (raw)

[-- Attachment #1: Type: text/plain, Size: 2502 bytes --]

Hi all,

Today's linux-next merge of the tty tree got a conflict in:

  drivers/usb/serial/ftdi_sio.c

between commit:

  a8619505a778 ("USB: serial: ftdi_sio: move driver structure")

from the usb-serial tree and commit:

  f6d47fe5921a ("usb: serial: Make ->set_termios() old ktermios const")

from the tty tree.

I fixed it up (see below) and can carry the fix as necessary. This
is now fixed as far as linux-next is concerned, but any non trivial
conflicts should be mentioned to your upstream maintainer when your tree
is submitted for merging.  You may also want to consider cooperating
with the maintainer of the conflicting tree to minimise any particularly
complex conflicts.

-- 
Cheers,
Stephen Rothwell

diff --cc drivers/usb/serial/ftdi_sio.c
index 31b9b36f3a1c,0a1da579ead5..000000000000
--- a/drivers/usb/serial/ftdi_sio.c
+++ b/drivers/usb/serial/ftdi_sio.c
@@@ -1107,8 -1078,29 +1107,9 @@@ static const char *ftdi_chip_name[] = 
  #define FTDI_STATUS_B1_MASK	(FTDI_RS_BI)
  /* End TIOCMIWAIT */
  
 -/* function prototypes for a FTDI serial converter */
 -static int  ftdi_sio_probe(struct usb_serial *serial,
 -					const struct usb_device_id *id);
 -static int  ftdi_sio_port_probe(struct usb_serial_port *port);
 -static void ftdi_sio_port_remove(struct usb_serial_port *port);
 -static int  ftdi_open(struct tty_struct *tty, struct usb_serial_port *port);
 -static void ftdi_dtr_rts(struct usb_serial_port *port, int on);
 -static void ftdi_process_read_urb(struct urb *urb);
 -static int ftdi_prepare_write_buffer(struct usb_serial_port *port,
 -						void *dest, size_t size);
  static void ftdi_set_termios(struct tty_struct *tty,
- 			struct usb_serial_port *port, struct ktermios *old);
+ 			     struct usb_serial_port *port,
+ 			     const struct ktermios *old_termios);
 -static int  ftdi_tiocmget(struct tty_struct *tty);
 -static int  ftdi_tiocmset(struct tty_struct *tty,
 -			unsigned int set, unsigned int clear);
 -static int  ftdi_ioctl(struct tty_struct *tty,
 -			unsigned int cmd, unsigned long arg);
 -static void get_serial_info(struct tty_struct *tty, struct serial_struct *ss);
 -static int set_serial_info(struct tty_struct *tty,
 -				struct serial_struct *ss);
 -static void ftdi_break_ctl(struct tty_struct *tty, int break_state);
 -static bool ftdi_tx_empty(struct usb_serial_port *port);
  static int ftdi_get_modem_status(struct usb_serial_port *port,
  						unsigned char status[2]);
  

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

             reply	other threads:[~2022-09-21  5:11 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-21  5:11 Stephen Rothwell [this message]
2022-09-21  6:32 ` linux-next: manual merge of the tty tree with the usb-serial tree Johan Hovold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220921151109.174cad24@canb.auug.org.au \
    --to=sfr@canb.auug.org.au \
    --cc=greg@kroah.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=johan@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).