From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Linus Walleij <linus.walleij@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Sricharan R <sricharan@codeaurora.org>,
Stephan Gerhold <stephan@gerhold.net>,
Shawn Guo <shawn.guo@linaro.org>, Vinod Koul <vkoul@kernel.org>,
krishna Lanka <quic_vamslank@quicinc.com>,
Sivaprakash Murugesan <sivaprak@codeaurora.org>,
linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Subject: [PATCH 31/32] dt-bindings: pinctrl: qcom,sc7280: fix matching pin config
Date: Sat, 24 Sep 2022 10:04:58 +0200 [thread overview]
Message-ID: <20220924080459.13084-32-krzysztof.kozlowski@linaro.org> (raw)
In-Reply-To: <20220924080459.13084-1-krzysztof.kozlowski@linaro.org>
The TLMM pin controller follows generic pin-controller bindings, so
should have subnodes with '-state' and '-pins'. Otherwise the subnodes
(level one and two) are not properly matched. This method also unifies
the bindings with other Qualcomm TLMM and LPASS pinctrl bindings.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
.../bindings/pinctrl/qcom,sc7280-pinctrl.yaml | 14 +++++++++++---
1 file changed, 11 insertions(+), 3 deletions(-)
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-pinctrl.yaml
index ad3496784678..4606ca980dc4 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-pinctrl.yaml
@@ -47,9 +47,17 @@ properties:
wakeup-parent: true
-#PIN CONFIGURATION NODES
patternProperties:
- '-pins$':
+ "-state$":
+ oneOf:
+ - $ref: "#/$defs/qcom-sc7280-tlmm-state"
+ - patternProperties:
+ "-pins$":
+ $ref: "#/$defs/qcom-sc7280-tlmm-state"
+ additionalProperties: false
+
+$defs:
+ qcom-sc7280-tlmm-state:
type: object
description:
Pinctrl node's client devices use subnodes for desired pin configuration.
@@ -162,7 +170,7 @@ examples:
gpio-ranges = <&tlmm 0 0 175>;
wakeup-parent = <&pdc>;
- qup_uart5_default: qup-uart5-pins {
+ qup_uart5_default: qup-uart5-state {
pins = "gpio46", "gpio47";
function = "qup13";
drive-strength = <2>;
--
2.34.1
next prev parent reply other threads:[~2022-09-24 8:08 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-24 8:04 [PATCH 00/32] pinctrl/arm64: qcom: continued - fix Qualcomm TLMM pinctrl schema warnings Krzysztof Kozlowski
2022-09-24 8:04 ` [PATCH 01/32] arm64: dts: qcom: ipq6018-cp01-c1: correct blspi1 pins Krzysztof Kozlowski
2022-09-24 8:04 ` [PATCH 02/32] arm64: dts: qcom: ipq6018: align TLMM pin configuration with DT schema Krzysztof Kozlowski
2022-09-24 8:04 ` [PATCH 03/32] ARM: dts: qcom: sdx55: add gpio-ranges to TLMM pinctrl Krzysztof Kozlowski
2022-09-24 8:04 ` [PATCH 04/32] ARM: dts: qcom: sdx55: align TLMM pin configuration with DT schema Krzysztof Kozlowski
2022-09-24 8:04 ` [PATCH 05/32] ARM: dts: qcom: msm8226: " Krzysztof Kozlowski
2022-09-24 8:04 ` [PATCH 06/32] ARM: dts: qcom: msm8974: " Krzysztof Kozlowski
2022-09-24 8:04 ` [PATCH 07/32] dt-bindings: pinctrl: qcom,ipq6018: add qpic_pad function Krzysztof Kozlowski
2022-09-24 8:04 ` [PATCH 08/32] dt-bindings: pinctrl: qcom,ipq6018: increase number of pins in pinmux Krzysztof Kozlowski
2022-09-24 8:04 ` [PATCH 09/32] dt-bindings: pinctrl: qcom,ipq6018: fix matching pin config Krzysztof Kozlowski
2022-09-24 8:04 ` [PATCH 10/32] dt-bindings: pinctrl: qcom,ipq6018: do not require function on non-GPIOs Krzysztof Kozlowski
2022-09-26 23:13 ` Rob Herring
2022-09-24 8:04 ` [PATCH 11/32] dt-bindings: pinctrl: qcom,ipq6018: fix indentation in example Krzysztof Kozlowski
2022-09-24 8:04 ` [PATCH 12/32] dt-bindings: pinctrl: qcom,msm8226: fix matching pin config Krzysztof Kozlowski
2022-09-24 8:04 ` [PATCH 13/32] dt-bindings: pinctrl: qcom,msm8226: do not require function on non-GPIOs Krzysztof Kozlowski
2022-09-26 23:13 ` Rob Herring
2022-09-24 8:04 ` [PATCH 14/32] dt-bindings: pinctrl: qcom,msm8226: add functions and input-enable Krzysztof Kozlowski
2022-09-24 8:04 ` [PATCH 15/32] dt-bindings: pinctrl: qcom,msm8226: fix indentation in example Krzysztof Kozlowski
2022-09-24 8:04 ` [PATCH 16/32] dt-bindings: pinctrl: qcom,msm8909-tlmm: fix matching pin config Krzysztof Kozlowski
2022-09-24 8:04 ` [PATCH 17/32] dt-bindings: pinctrl: qcom,msm8909-tlmm: do not require function on non-GPIOs Krzysztof Kozlowski
2022-09-25 14:00 ` Stephan Gerhold
2022-09-26 6:48 ` Krzysztof Kozlowski
2022-09-24 8:04 ` [PATCH 18/32] dt-bindings: pinctrl: qcom,msm8909-tlmm: fix indentation in example Krzysztof Kozlowski
2022-09-24 8:04 ` [PATCH 19/32] dt-bindings: pinctrl: qcom,msm8953: fix matching pin config Krzysztof Kozlowski
2022-09-24 8:04 ` [PATCH 20/32] dt-bindings: pinctrl: qcom,msm8953: do not require function on non-GPIOs Krzysztof Kozlowski
2022-09-26 23:14 ` Rob Herring
2022-09-24 8:04 ` [PATCH 21/32] dt-bindings: pinctrl: qcom,msm8953: fix indentation in example Krzysztof Kozlowski
2022-09-24 8:04 ` [PATCH 22/32] dt-bindings: pinctrl: qcom,mdm9607: do not require function on non-GPIOs Krzysztof Kozlowski
2022-09-24 8:04 ` [PATCH 23/32] dt-bindings: pinctrl: qcom,mdm9607: fix indentation in example Krzysztof Kozlowski
2022-09-24 8:04 ` [PATCH 24/32] dt-bindings: pinctrl: qcom,qcm2290: fix matching pin config Krzysztof Kozlowski
2022-09-24 8:04 ` [PATCH 25/32] dt-bindings: pinctrl: qcom,qcm2290: do not require function on non-GPIOs Krzysztof Kozlowski
2022-09-26 23:15 ` Rob Herring
2022-09-27 11:38 ` Krzysztof Kozlowski
2022-09-26 23:15 ` Rob Herring
2022-09-27 11:42 ` Dmitry Baryshkov
2022-09-27 13:57 ` Krzysztof Kozlowski
2022-09-24 8:04 ` [PATCH 26/32] dt-bindings: pinctrl: qcom,sdx55: fix matching pin config Krzysztof Kozlowski
2022-09-24 8:04 ` [PATCH 27/32] dt-bindings: pinctrl: qcom,sdx55: do not require function on non-GPIOs Krzysztof Kozlowski
2022-09-26 23:15 ` Rob Herring
2022-09-24 8:04 ` [PATCH 28/32] dt-bindings: pinctrl: qcom,sdx55: fix indentation in example Krzysztof Kozlowski
2022-09-24 8:04 ` [PATCH 29/32] dt-bindings: pinctrl: qcom,sdx65: fix matching pin config Krzysztof Kozlowski
2022-09-24 8:04 ` [PATCH 30/32] dt-bindings: pinctrl: qcom,sdx65: do not require function on non-GPIOs Krzysztof Kozlowski
2022-09-26 23:15 ` Rob Herring
2022-09-24 8:04 ` Krzysztof Kozlowski [this message]
2022-09-24 8:04 ` [PATCH 32/32] dt-bindings: pinctrl: qcom,sc8280xp: fix indentation in example (remaining piece) Krzysztof Kozlowski
2022-10-03 22:01 ` [PATCH 00/32] pinctrl/arm64: qcom: continued - fix Qualcomm TLMM pinctrl schema warnings Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220924080459.13084-32-krzysztof.kozlowski@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_vamslank@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=shawn.guo@linaro.org \
--cc=sivaprak@codeaurora.org \
--cc=sricharan@codeaurora.org \
--cc=stephan@gerhold.net \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).