From: Chukun Pan <amadeus@jmu.edu.cn>
To: linux.amoon@gmail.com
Cc: heiko@sntech.de, krzysztof.kozlowski+dt@linaro.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-rockchip@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
michael.riesch@wolfvision.net, robh+dt@kernel.org,
Chukun Pan <amadeus@jmu.edu.cn>
Subject: Re: [PATCH-next v1] arm64: dts: rockchip: Enable NVM Express PCIe controller on rock3a
Date: Tue, 27 Sep 2022 02:00:59 +0800 [thread overview]
Message-ID: <20220926180102.37614-1-amadeus@jmu.edu.cn> (raw)
In-Reply-To: <20220926061420.1248-1-linux.amoon@gmail.com>
Hi,
On 26-09-22, 06:14, Anand Moon wrote:
> + pcie30_3v3: gpio-regulator {
> + compatible = "regulator-gpio";
> + regulator-name = "pcie30_3v3";
> + regulator-min-microvolt = <100000>;
> + regulator-max-microvolt = <3300000>;
> + gpios = <&gpio0 RK_PD4 GPIO_ACTIVE_HIGH>;
> + gpios-states = <0x1>;
> + states = <100000 0x0>, <3300000 0x1>;
> + };
This is actually no different from vcc3v3-pcie regulator?
> +&pcie30phy {
> + data-lanes = <0 1 2 3>;
> + phy-supply = <&vcc3v3_pi6c_03>;
> + status = "okay";
> +};
It seems that there is no need to define additional data-lanes when
the pcie3x1 node is not enabled, and phy-supply seems unnecessary on
this board.
Excuse me, can you try the patches I posted? Lspci can recognize
pcie3x2 normally, but I don't have a spare nvme hard drive right
now to test if it works.
Thanks, Chukun
---
Chukun Pan (3):
arm64: dts: rockchip: Add regulator suffix to ROCK3 Model A
arm64: dts: rockchip: Rename pinctrl label of pcie2x1 on rock-3a
arm64: dts: rockchip: Add PCIe v3 nodes to rock-3a
.../boot/dts/rockchip/rk3568-rock-3a.dts | 36 ++++++++++++++-----
1 file changed, 27 insertions(+), 9 deletions(-)
--
2.25.1
next prev parent reply other threads:[~2022-09-26 18:22 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-26 6:14 [PATCH-next v1] arm64: dts: rockchip: Enable NVM Express PCIe controller on rock3a Anand Moon
2022-09-26 18:00 ` Chukun Pan [this message]
2022-09-26 18:01 ` [PATCH 1/3] arm64: dts: rockchip: Add regulator suffix to rock-3a Chukun Pan
2022-09-27 5:42 ` Michael Riesch
2022-09-26 18:01 ` [PATCH 2/3] arm64: dts: rockchip: Rename pinctrl label of pcie2x1 on rock-3a Chukun Pan
2022-10-05 7:48 ` Heiko Stübner
2022-09-26 18:01 ` [PATCH 3/3] arm64: dts: rockchip: Add PCIe v3 nodes to rock-3a Chukun Pan
2022-09-27 13:46 ` [PATCH-next v1] arm64: dts: rockchip: Enable NVM Express PCIe controller on rock3a Anand Moon
2022-09-27 17:47 ` Robin Murphy
2022-09-28 10:05 ` Chukun Pan
2022-09-28 10:37 ` Robin Murphy
2022-09-27 18:15 ` Chukun Pan
2022-09-27 18:15 ` [PATCH 3/3] arm64: dts: rockchip: Add PCIe v3 nodes to rock-3a Chukun Pan
2022-09-28 11:04 ` [PATCH-next v1] arm64: dts: rockchip: Enable NVM Express PCIe controller on rock3a Anand Moon
2022-09-30 15:25 ` [PATCH 0/1] " Chukun Pan
2022-10-02 15:46 ` Anand Moon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220926180102.37614-1-amadeus@jmu.edu.cn \
--to=amadeus@jmu.edu.cn \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux.amoon@gmail.com \
--cc=michael.riesch@wolfvision.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).