From: Eugeniu Rosca <erosca@de.adit-jv.com>
To: "Amadeusz Sławiński" <amadeuszx.slawinski@linux.intel.com>
Cc: Eugeniu Rosca <erosca@de.adit-jv.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>, <alsa-devel@alsa-project.org>,
<linux-kernel@vger.kernel.org>,
Yanmin Zhang <yanmin_zhang@linux.intel.com>,
Eugeniu Rosca <roscaeugeniu@gmail.com>,
Jiada Wang <jiada_wang@mentor.com>,
Zhang Yanmin <yanmin.zhang@intel.com>,
Ramesh Babu <ramesh.babu@intel.com>,
Dean Jenkins <Dean_Jenkins@mentor.com>,
Ramesh Babu B <ramesh.babu.b@intel.com>,
xiao jin <jin.xiao@intel.com>,
Cezary Rojewski <cezary.rojewski@intel.com>
Subject: Re: [PATCH] ASoC: soc-pcm: fix fe and be race when accessing substream->runtime
Date: Tue, 27 Sep 2022 13:56:19 +0200 [thread overview]
Message-ID: <20220927115619.GA4547@lxhi-065> (raw)
In-Reply-To: <b54daa61-ba1d-81d4-5238-ca7cc2a41b48@linux.intel.com>
Hello Amadeusz,
On Di, Sep 27, 2022 at 09:34:49 +0200, Amadeusz Sławiński wrote:
> On 9/26/2022 6:35 PM, Eugeniu Rosca wrote:
> >From: xiao jin <jin.xiao@intel.com>
> >
> >After start of fe and be, fe might go to close without triggering
> >STOP, and substream->runtime is freed. However, be is still at
> >START state and its substream->runtime still points to the
> >freed runtime.
> >
>
> Well if it is being freed, maybe pointer should be set to NULL instead in
> place that happens?
>
As soon as the agreement is reached that the patch is still
relevant/useful on the latest vanilla, I think this review
finding will receive proper attention.
Thanks,
Eugeniu
next prev parent reply other threads:[~2022-09-27 11:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1664210154-11552-1-git-send-email-erosca@de.adit-jv.com>
2022-09-27 7:34 ` [PATCH] ASoC: soc-pcm: fix fe and be race when accessing substream->runtime Amadeusz Sławiński
2022-09-27 11:56 ` Eugeniu Rosca [this message]
2022-09-27 7:50 ` Cezary Rojewski
2022-09-27 11:00 ` Eugeniu Rosca
2022-09-28 14:24 ` Cezary Rojewski
2022-09-29 16:25 ` Eugeniu Rosca
2022-09-27 7:51 ` Pierre-Louis Bossart
2022-09-27 12:30 ` Eugeniu Rosca
2022-09-28 8:36 ` Pierre-Louis Bossart
2022-09-29 16:36 ` Eugeniu Rosca
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220927115619.GA4547@lxhi-065 \
--to=erosca@de.adit-jv.com \
--cc=Dean_Jenkins@mentor.com \
--cc=alsa-devel@alsa-project.org \
--cc=amadeuszx.slawinski@linux.intel.com \
--cc=broonie@kernel.org \
--cc=cezary.rojewski@intel.com \
--cc=jiada_wang@mentor.com \
--cc=jin.xiao@intel.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=ramesh.babu.b@intel.com \
--cc=ramesh.babu@intel.com \
--cc=roscaeugeniu@gmail.com \
--cc=tiwai@suse.com \
--cc=yanmin.zhang@intel.com \
--cc=yanmin_zhang@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).