From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2259EC32771 for ; Wed, 28 Sep 2022 09:04:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232994AbiI1JD5 (ORCPT ); Wed, 28 Sep 2022 05:03:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56496 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232524AbiI1JD1 (ORCPT ); Wed, 28 Sep 2022 05:03:27 -0400 Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com [68.232.153.233]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7CCC8DF6BC; Wed, 28 Sep 2022 02:03:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1664355807; x=1695891807; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=Mul5fKbvrZirdXc2DPavwIBXeg0wFX60axpkVvIhWvw=; b=G0UWz0qa0Ikj5qwlsTRDHfZjogHW9Mfk1pvjTRyXgETgPAPBJX78dN0I JdjZtvM/iHmPwbnu2jnh3VeSO+jwIpE9T+PA3KFR5YE+N4xWjjiGPf+hq xOHUdinVk04AwrBKjfrpNZB7k5MBVHhA3YvvUXKRogt8gVvvqIiXtP1TX fYyP7V3UNws+TlU5y6i+jhzTymnzslWog32BZ9qznKbSiYLDRaV0V8jN4 e8HBurQ2uiHNMb1+lld258tkAZNF1vDYUl3mkLzKOvH+HyNja0PLt//vf cetf6L0WBY3/rASyrbS6hmYf+m8AL8MpUVHi+4lBwuYKIdBYToY0Zg/DQ w==; X-IronPort-AV: E=Sophos;i="5.93,351,1654585200"; d="scan'208";a="182292739" Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa5.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 28 Sep 2022 02:03:27 -0700 Received: from chn-vm-ex04.mchp-main.com (10.10.85.152) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.12; Wed, 28 Sep 2022 02:03:25 -0700 Received: from localhost.localdomain (10.10.115.15) by chn-vm-ex04.mchp-main.com (10.10.85.152) with Microsoft SMTP Server id 15.1.2507.12 via Frontend Transport; Wed, 28 Sep 2022 02:03:22 -0700 From: Raju Lakkaraju To: CC: , , , , , , , Subject: [PATCH net V4] eth: lan743x: reject extts for non-pci11x1x devices Date: Wed, 28 Sep 2022 14:33:11 +0530 Message-ID: <20220928090311.93361-1-Raju.Lakkaraju@microchip.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Remove PTP_PF_EXTTS support for non-PCI11x1x devices since they do not support the PTP-IO Input event triggered timestamping mechanisms added Fixes: 60942c397af6 ("Add support for PTP-IO Event Input External Timestamp (extts)") Reviewed-by: Jakub Kicinski Signed-off-by: Raju Lakkaraju --- Changes: ======== V3 -> V4: - Fix the Fixes tag line split V2 -> V3: - Correct the Fixes tag V1 -> V2: - Repost against net with a Fixes tag drivers/net/ethernet/microchip/lan743x_ptp.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/net/ethernet/microchip/lan743x_ptp.c b/drivers/net/ethernet/microchip/lan743x_ptp.c index 6a11e2ceb013..da3ea905adbb 100644 --- a/drivers/net/ethernet/microchip/lan743x_ptp.c +++ b/drivers/net/ethernet/microchip/lan743x_ptp.c @@ -1049,6 +1049,10 @@ static int lan743x_ptpci_verify_pin_config(struct ptp_clock_info *ptp, enum ptp_pin_function func, unsigned int chan) { + struct lan743x_ptp *lan_ptp = + container_of(ptp, struct lan743x_ptp, ptp_clock_info); + struct lan743x_adapter *adapter = + container_of(lan_ptp, struct lan743x_adapter, ptp); int result = 0; /* Confirm the requested function is supported. Parameter @@ -1057,7 +1061,10 @@ static int lan743x_ptpci_verify_pin_config(struct ptp_clock_info *ptp, switch (func) { case PTP_PF_NONE: case PTP_PF_PEROUT: + break; case PTP_PF_EXTTS: + if (!adapter->is_pci11x1x) + result = -1; break; case PTP_PF_PHYSYNC: default: -- 2.25.1