From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5CC6BC4332F for ; Thu, 29 Sep 2022 16:39:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235659AbiI2Qjo (ORCPT ); Thu, 29 Sep 2022 12:39:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37922 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229780AbiI2Qjm (ORCPT ); Thu, 29 Sep 2022 12:39:42 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4DF3C2DDE; Thu, 29 Sep 2022 09:39:35 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id CA81468BFE; Thu, 29 Sep 2022 18:39:31 +0200 (CEST) Date: Thu, 29 Sep 2022 18:39:31 +0200 From: Christoph Hellwig To: Keith Busch Cc: Maxim Levitsky , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Christoph Hellwig , qemu-devel@nongnu.org, kvm@vger.kernel.org, Kevin Wolf Subject: Re: Commit 'iomap: add support for dma aligned direct-io' causes qemu/KVM boot failures Message-ID: <20220929163931.GA10232@lst.de> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 29, 2022 at 10:37:22AM -0600, Keith Busch wrote: > I don't think so. Memory alignment and length granularity are two completely > different concepts. If anything, the kernel's ABI had been that the length > requirement was also required for the memory alignment, not the other way > around. That usage will continue working with this kernel patch. Well, Linus does treat anything that breaks significant userspace as a regression. Qemu certainly is significant, but that might depend on bit how common configurations hitting this issue are.