From: Yu Kuai <yukuai1@huaweicloud.com>
To: jack@suse.cz, hch@infradead.org, ebiggers@kernel.org,
paolo.valente@linaro.org, axboe@kernel.dk
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
yukuai3@huawei.com, yukuai1@huaweicloud.com, yi.zhang@huawei.com
Subject: [PATCH v4 5/6] elevator: add new field flags in struct elevator_queue
Date: Fri, 30 Sep 2022 11:19:05 +0800 [thread overview]
Message-ID: <20220930031906.4164306-6-yukuai1@huaweicloud.com> (raw)
In-Reply-To: <20220930031906.4164306-1-yukuai1@huaweicloud.com>
From: Yu Kuai <yukuai3@huawei.com>
There are only one flag to indicate that elevator is registered currently,
prepare to add a flag to disable wbt if default elevator is bfq.
Signed-off-by: Yu Kuai <yukuai3@huawei.com>
---
block/elevator.c | 6 ++----
block/elevator.h | 4 +++-
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/block/elevator.c b/block/elevator.c
index 20e70fd3f77f..9e12706e8d8c 100644
--- a/block/elevator.c
+++ b/block/elevator.c
@@ -512,7 +512,7 @@ int elv_register_queue(struct request_queue *q, bool uevent)
if (uevent)
kobject_uevent(&e->kobj, KOBJ_ADD);
- e->registered = 1;
+ set_bit(ELEVATOR_FLAG_REGISTERED, &e->flags);
}
return error;
}
@@ -523,11 +523,9 @@ void elv_unregister_queue(struct request_queue *q)
lockdep_assert_held(&q->sysfs_lock);
- if (e && e->registered) {
+ if (e && test_and_clear_bit(ELEVATOR_FLAG_REGISTERED, &e->flags)) {
kobject_uevent(&e->kobj, KOBJ_REMOVE);
kobject_del(&e->kobj);
-
- e->registered = 0;
}
}
diff --git a/block/elevator.h b/block/elevator.h
index 3f0593b3bf9d..ed574bf3e629 100644
--- a/block/elevator.h
+++ b/block/elevator.h
@@ -100,10 +100,12 @@ struct elevator_queue
void *elevator_data;
struct kobject kobj;
struct mutex sysfs_lock;
- unsigned int registered:1;
+ unsigned long flags;
DECLARE_HASHTABLE(hash, ELV_HASH_BITS);
};
+#define ELEVATOR_FLAG_REGISTERED 0
+
/*
* block elevator interface
*/
--
2.31.1
next prev parent reply other threads:[~2022-09-30 2:57 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-30 3:19 [PATCH v4 0/6] blk-wbt: simple improvment to enable wbt correctly Yu Kuai
2022-09-30 3:19 ` [PATCH v4 1/6] elevator: remove redundant code in elv_unregister_queue() Yu Kuai
2022-09-30 3:19 ` [PATCH v4 2/6] blk-wbt: remove unnecessary check in wbt_enable_default() Yu Kuai
2022-10-18 15:43 ` Christoph Hellwig
2022-09-30 3:19 ` [PATCH v4 3/6] blk-wbt: make enable_state more accurate Yu Kuai
2022-10-18 15:47 ` Christoph Hellwig
2022-09-30 3:19 ` [PATCH v4 4/6] blk-wbt: don't show valid wbt_lat_usec in sysfs while wbt is disabled Yu Kuai
2022-10-18 15:49 ` Christoph Hellwig
2022-10-19 1:06 ` Yu Kuai
2022-09-30 3:19 ` Yu Kuai [this message]
2022-10-18 15:49 ` [PATCH v4 5/6] elevator: add new field flags in struct elevator_queue Christoph Hellwig
2022-09-30 3:19 ` [PATCH v4 6/6] blk-wbt: don't enable throttling if default elevator is bfq Yu Kuai
2022-10-18 15:50 ` Christoph Hellwig
2022-10-11 8:06 ` [PATCH v4 0/6] blk-wbt: simple improvment to enable wbt correctly Yu Kuai
2022-10-18 2:28 ` Yu Kuai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220930031906.4164306-6-yukuai1@huaweicloud.com \
--to=yukuai1@huaweicloud.com \
--cc=axboe@kernel.dk \
--cc=ebiggers@kernel.org \
--cc=hch@infradead.org \
--cc=jack@suse.cz \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paolo.valente@linaro.org \
--cc=yi.zhang@huawei.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).