From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6D6DC433F5 for ; Fri, 30 Sep 2022 14:30:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231971AbiI3OaU (ORCPT ); Fri, 30 Sep 2022 10:30:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39646 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231332AbiI3OaN (ORCPT ); Fri, 30 Sep 2022 10:30:13 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 96EB24B993; Fri, 30 Sep 2022 07:29:56 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 37D44B828F4; Fri, 30 Sep 2022 14:29:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9EA5EC433D6; Fri, 30 Sep 2022 14:29:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1664548194; bh=1YSSQKc9IYsNlaO+SLoAcjFZ7kIKPU65vrvkvNyAQA0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=LMPLTR7+R0KuO7NuhDEG7EvRBETpIQfmxgeREwfOHxD5TzQD6pHKChKvUp/PEwf9J iC1AVUFK22V9We03HJ98XrXzBCL2uG8zOzIGSn0yZOnbIfmX1VlVfxEvB+49OXLYNZ 6UxIQqTpfJ5kFbXHHAURuginafo9ZB3ywAftYPYNoHVVgOW7LmcmTQXdEsCPUTtKIy SAJ5E6iPhtS3mHPsPr3Yd0GNBxZ3fuAtNQJSjYP6wwakPec8BB0QAB2xSEr5OATJeV JlOekXVvSUF198ePkeyxXtuWbOT5goC7xxzhjGeU0vohSL1Pt7eHtGtniTyVpqq93s vaVuJJy/uGHxQ== Date: Fri, 30 Sep 2022 07:29:52 -0700 From: Jakub Kicinski To: Jiasheng Jiang , Joe Perches Cc: pabeni@redhat.com, davem@davemloft.net, tchornyi@marvell.com, edumazet@google.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Volodymyr Mytnyk Subject: Re: [PATCH] net: prestera: acl: Add check for kmemdup Message-ID: <20220930072952.2d337b3a@kernel.org> In-Reply-To: <20220930050317.32706-1-jiasheng@iscas.ac.cn> References: <20220930050317.32706-1-jiasheng@iscas.ac.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 30 Sep 2022 13:03:17 +0800 Jiasheng Jiang wrote: > Actually, I used get_maintainer scripts and the results is as follow: > "./scripts/get_maintainer.pl -f drivers/net/ethernet/marvell/prestera/prestera_acl.c" > Taras Chornyi (supporter:MARVELL PRESTERA ETHERNET SWITCH DRIVER) > "David S. Miller" (maintainer:NETWORKING DRIVERS) > Eric Dumazet (maintainer:NETWORKING DRIVERS) > Jakub Kicinski (maintainer:NETWORKING DRIVERS) > Paolo Abeni (maintainer:NETWORKING DRIVERS) > netdev@vger.kernel.org (open list:NETWORKING DRIVERS) > linux-kernel@vger.kernel.org (open list) > > Therefore, I submitted my patch to the above addresses. > > And this time I checked the fixes commit, and found that it has two > authors: > Signed-off-by: Volodymyr Mytnyk > Signed-off-by: David S. Miller > > Maybe there is a problem of the script that misses one. > Anyway, I have already submitted the same patch and added > "vmytnyk@marvell.com" this time. Ha! So you do indeed use it in a way I wasn't expecting :S Thanks for the explanation. Joe, would you be okay to add a "big fat warning" to get_maintainer when people try to use the -f flag? Maybe we can also change the message that's displayed when the script is run without arguments to not mention -f? We're getting quite a few fixes which don't CC author, I'm guessing Jiasheng's approach may be a common one.