From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 974A3C433FE for ; Fri, 30 Sep 2022 13:24:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230365AbiI3NYI (ORCPT ); Fri, 30 Sep 2022 09:24:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36304 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230517AbiI3NYF (ORCPT ); Fri, 30 Sep 2022 09:24:05 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8E97E18C018; Fri, 30 Sep 2022 06:24:03 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 44DA11F8B9; Fri, 30 Sep 2022 13:24:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1664544242; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xjbSbduucevkzQ7gYt/VOMBEvrNsn6UzpmO29QP+wkw=; b=zJoYvgHf1iOzdZBrYAAj24RrE0i6S0lZ9wS35tJWDILpwEePzEQoTK3EyVXha0mnf6okmg 0S08u992lQuOdd+hli/Ykpt7bkJTgBTRTqa4CJnpQ22DX1SPEmY8Kqc8EYtOJ4x+TXpOpq t6udyNw00squOzPGADtAKQO2+VyUsJo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1664544242; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xjbSbduucevkzQ7gYt/VOMBEvrNsn6UzpmO29QP+wkw=; b=H3XeUjbjQ89nRozjBdrCO8zn9yAcpETmozCTCHVwK6cTbMQ4mpqtvHaTJckBV+sINpsrzi ctrjzycwLl2DJkBg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1821513776; Fri, 30 Sep 2022 13:24:02 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id J+yLA/LtNmO1PwAAMHmgww (envelope-from ); Fri, 30 Sep 2022 13:24:02 +0000 Date: Fri, 30 Sep 2022 15:24:00 +0200 From: Jean Delvare To: Mani Milani Cc: LKML , linux-i2c@vger.kernel.org Subject: Re: [PATCH] i2c: i801: Prefer async probe Message-ID: <20220930152400.610987c7@endymion.delvare> In-Reply-To: <20220826074430.1333272-1-mani@chromium.org> References: <20220826074430.1333272-1-mani@chromium.org> Organization: SUSE Linux X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.32; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 26 Aug 2022 17:44:30 +1000, Mani Milani wrote: > This i801 driver probe can take more than ~190ms in some devices, since > the "i2c_register_spd()" call was added inside > "i801_probe_optional_slaves()". > > Prefer async probe so that other drivers can be probed and boot can > continue in parallel while this driver loads, to reduce boot time. There is > no reason to block other drivers from probing while this driver is > loading. > > Signed-off-by: Mani Milani > --- > > drivers/i2c/busses/i2c-i801.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/i2c/busses/i2c-i801.c b/drivers/i2c/busses/i2c-i801.c > index a176296f4fff..e06509edc5f3 100644 > --- a/drivers/i2c/busses/i2c-i801.c > +++ b/drivers/i2c/busses/i2c-i801.c > @@ -1838,6 +1838,7 @@ static struct pci_driver i801_driver = { > .shutdown = i801_shutdown, > .driver = { > .pm = &i801_pm_ops, > + .probe_type = PROBE_PREFER_ASYNCHRONOUS, > }, > }; > Reviewed-by: Jean Delvare -- Jean Delvare SUSE L3 Support