Hi, Thank you for the patch! Yet something to improve: [auto build test ERROR on bluetooth/master] [also build test ERROR on bluetooth-next/master linus/master v6.0-rc7 next-20220929] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/sean-wang-mediatek-com/Bluetooth-btusb-mediatek-use-readx_poll_timeout-instead-of-open-coding/20220930-082512 base: https://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth.git master config: arm-randconfig-r033-20220925 compiler: arm-linux-gnueabi-gcc (GCC) 12.1.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/046dccfde843fe56b2ad741a42d972365bb70b03 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review sean-wang-mediatek-com/Bluetooth-btusb-mediatek-use-readx_poll_timeout-instead-of-open-coding/20220930-082512 git checkout 046dccfde843fe56b2ad741a42d972365bb70b03 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash drivers/bluetooth/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot All errors (new ones prefixed by >>): drivers/bluetooth/btmtk.c: In function 'btmtk_coredump_notify': drivers/bluetooth/btmtk.c:111:14: error: 'HCI_DEVCOREDUMP_ACTIVE' undeclared (first use in this function); did you mean 'BTMTK_COREDUMP_ACTIVE'? 111 | case HCI_DEVCOREDUMP_ACTIVE: | ^~~~~~~~~~~~~~~~~~~~~~ | BTMTK_COREDUMP_ACTIVE drivers/bluetooth/btmtk.c:111:14: note: each undeclared identifier is reported only once for each function it appears in drivers/bluetooth/btmtk.c:114:14: error: 'HCI_DEVCOREDUMP_TIMEOUT' undeclared (first use in this function); did you mean 'HCI_DISCONN_TIMEOUT'? 114 | case HCI_DEVCOREDUMP_TIMEOUT: | ^~~~~~~~~~~~~~~~~~~~~~~ | HCI_DISCONN_TIMEOUT drivers/bluetooth/btmtk.c:115:14: error: 'HCI_DEVCOREDUMP_ABORT' undeclared (first use in this function) 115 | case HCI_DEVCOREDUMP_ABORT: | ^~~~~~~~~~~~~~~~~~~~~ drivers/bluetooth/btmtk.c:116:14: error: 'HCI_DEVCOREDUMP_DONE' undeclared (first use in this function) 116 | case HCI_DEVCOREDUMP_DONE: | ^~~~~~~~~~~~~~~~~~~~ drivers/bluetooth/btmtk.c: In function 'btmtk_register_coredump': drivers/bluetooth/btmtk.c:376:9: error: implicit declaration of function 'hci_devcoredump_register' [-Werror=implicit-function-declaration] 376 | hci_devcoredump_register(hdev, btmtk_coredump, btmtk_coredump_hdr, | ^~~~~~~~~~~~~~~~~~~~~~~~ drivers/bluetooth/btmtk.c: In function 'btmtk_process_coredump': drivers/bluetooth/btmtk.c:393:23: error: implicit declaration of function 'hci_devcoredump_init' [-Werror=implicit-function-declaration] 393 | err = hci_devcoredump_init(hdev, 1024000); | ^~~~~~~~~~~~~~~~~~~~ >> drivers/bluetooth/btmtk.c:397:44: error: 'struct hci_dev' has no member named 'dump' 397 | schedule_delayed_work(&hdev->dump.dump_timeout, | ^~ drivers/bluetooth/btmtk.c:402:23: error: implicit declaration of function 'hci_devcoredump_append' [-Werror=implicit-function-declaration] 402 | err = hci_devcoredump_append(hdev, skb); | ^~~~~~~~~~~~~~~~~~~~~~ drivers/bluetooth/btmtk.c:409:25: error: implicit declaration of function 'hci_devcoredump_complete' [-Werror=implicit-function-declaration] 409 | hci_devcoredump_complete(hdev); | ^~~~~~~~~~~~~~~~~~~~~~~~ cc1: some warnings being treated as errors Kconfig warnings: (for reference only) WARNING: unmet direct dependencies detected for TEGRA20_APB_DMA Depends on [n]: DMADEVICES [=n] && (ARCH_TEGRA [=y] || COMPILE_TEST [=y]) Selected by [y]: - SOC_TEGRA_FUSE [=y] && ARCH_TEGRA [=y] && ARCH_TEGRA_2x_SOC [=y] vim +397 drivers/bluetooth/btmtk.c 380 381 int btmtk_process_coredump(struct hci_dev *hdev, struct sk_buff *skb) 382 { 383 int err; 384 385 if (!IS_ENABLED(CONFIG_DEV_COREDUMP)) 386 return 0; 387 388 switch (coredump_info.state) { 389 case BTMTK_COREDUMP_DISABLED: 390 err = -EINVAL; 391 break; 392 case BTMTK_COREDUMP_INIT: 393 err = hci_devcoredump_init(hdev, 1024000); 394 if (err < 0) 395 break; 396 /* It is supposed coredump can be done within 5 seconds */ > 397 schedule_delayed_work(&hdev->dump.dump_timeout, 398 msecs_to_jiffies(5000)); 399 fallthrough; 400 case BTMTK_COREDUMP_ACTIVE: 401 default: 402 err = hci_devcoredump_append(hdev, skb); 403 if (err < 0) 404 break; 405 406 if (skb->len > 12 && 407 !strncmp((char *)&skb->data[skb->len - 13], 408 MTK_COREDUMP_END, 12)) 409 hci_devcoredump_complete(hdev); 410 411 break; 412 } 413 414 if (err < 0) { 415 coredump_info.state = BTMTK_COREDUMP_DISABLED; 416 kfree_skb(skb); 417 } 418 419 return err; 420 } 421 EXPORT_SYMBOL_GPL(btmtk_process_coredump); 422 -- 0-DAY CI Kernel Test Service https://01.org/lkp