linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Michał Grzelak" <mig@semihalf.com>
To: krzysztof.kozlowski@linaro.org
Cc: davem@davemloft.net, devicetree@vger.kernel.org,
	edumazet@google.com, krzysztof.kozlowski+dt@linaro.org,
	kuba@kernel.org, linux-kernel@vger.kernel.org,
	linux@armlinux.org.uk, mig@semihalf.com, mw@semihalf.com,
	netdev@vger.kernel.org, pabeni@redhat.com, robh+dt@kernel.org,
	upstream@semihalf.com
Subject: Re: [PATCH v2] dt-bindings: net: marvell,pp2: convert to json-schema
Date: Sat,  1 Oct 2022 17:53:53 +0200	[thread overview]
Message-ID: <20221001155353.10211-1-mig@semihalf.com> (raw)
In-Reply-To: <db7055da-b01f-3ca6-20f8-e9bc7ed892bc@linaro.org>

Hi Krzysztof,

Thanks for your comments and time spent on reviewing my patch.
All of those improvements will be included in next version. 
Also, I would like to know your opinion about one. 

>> +
>> +  marvell,system-controller:
>> +    $ref: /schemas/types.yaml#/definitions/phandle
>> +    description: a phandle to the system controller.
>> +
>> +patternProperties:
>> +  '^eth[0-9a-f]*(@.*)?$':
> 
> The name should be "(ethernet-)?port", unless anything depends on
> particular naming?

What do you think about pattern "^(ethernet-)?eth[0-9a-f]+(@.*)?$"?
It resembles pattern found in net/ethernet-phy.yaml like
properties:$nodename:pattern:"^ethernet-phy(@[a-f0-9]+)?$", while 
still passing `dt_binding_check' and `dtbs_check'. It should also 
comply with your comment.

Best regards,
Michał

  reply	other threads:[~2022-10-01 15:54 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-26 23:21 [PATCH v2] dt-bindings: net: marvell,pp2: convert to json-schema Michał Grzelak
2022-09-28  7:47 ` Krzysztof Kozlowski
2022-10-01 15:53   ` Michał Grzelak [this message]
2022-10-02  8:00     ` Krzysztof Kozlowski
2022-10-02 10:23       ` Marcin Wojtas
2022-10-03 17:06         ` Michał Grzelak
2022-10-03 17:23           ` Marcin Wojtas
2022-10-03 17:29           ` Krzysztof Kozlowski
2022-10-11  0:34             ` Marcin Wojtas
2022-10-11  0:38 ` Marcin Wojtas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221001155353.10211-1-mig@semihalf.com \
    --to=mig@semihalf.com \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=edumazet@google.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=mw@semihalf.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=robh+dt@kernel.org \
    --cc=upstream@semihalf.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).