From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D031C433FE for ; Tue, 4 Oct 2022 00:25:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229660AbiJDAZg (ORCPT ); Mon, 3 Oct 2022 20:25:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56482 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230087AbiJDAZ0 (ORCPT ); Mon, 3 Oct 2022 20:25:26 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9346626497; Mon, 3 Oct 2022 17:25:21 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 10B0061211; Tue, 4 Oct 2022 00:25:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 342F5C433C1; Tue, 4 Oct 2022 00:25:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1664843120; bh=w5Bp1yBScSW8L2oy1ePtS/8+FADf1H8Yaj0ecY57PyU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CRzNpSgWI6XFBOHlhR1M/K0ExwlFGKUlGQj40lEoFN3sg9gWEmjkTiV+eDyMStblX SOQrojpQMS0BLUOxPRHkHJYx81EmfIkWbqsjGVM6ctFLtqUX5ME0jZ/KqmFGsUyI34 Z04MFevkaGzb1+6de7cXmeS8/NVjXejKKikOJ4C0s0KvdtolwXU305MuPb6H1mGVD/ 3uJrDyDU8OjgE3DBCKEOLYcZsBrqvKTRQTifyTbVrUYnj6OYt80/7bQ1bJkejBYTRc WrYS/2HrzUprh0WWeQA/Va/Zw3NaEck9GmRzOLX96j3Lv0DjBk1RDzC/awgIZlmNMV 3wGOmu8gaUQzA== Date: Mon, 3 Oct 2022 19:25:16 -0500 From: Bjorn Andersson To: Richard Acayan Cc: linux-arm-msm@vger.kernel.org, Andy Gross , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht Subject: Re: [PATCH v6 1/3] dt-bindings: pinctrl: qcom: add sdm670 pinctrl Message-ID: <20221004002516.2m5mtrw5vbdhcvkv@baldur> References: <20221001210725.60967-1-mailingradian@gmail.com> <20221001210725.60967-2-mailingradian@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221001210725.60967-2-mailingradian@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Oct 01, 2022 at 05:07:23PM -0400, Richard Acayan wrote: > There is a new driver for the Snapdragon 670 TLMM (Top-Level Mode > Multiplexer). Document it. > > Adapted from qcom,sm6350-pinctrl.yaml. > > Signed-off-by: Richard Acayan > Reviewed-by: Krzysztof Kozlowski Reviewed-by: Bjorn Andersson > --- > .../bindings/pinctrl/qcom,sdm670-tlmm.yaml | 129 ++++++++++++++++++ > 1 file changed, 129 insertions(+) > create mode 100644 Documentation/devicetree/bindings/pinctrl/qcom,sdm670-tlmm.yaml > > diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sdm670-tlmm.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sdm670-tlmm.yaml > new file mode 100644 > index 000000000000..e2f563ae6bbf > --- /dev/null > +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sdm670-tlmm.yaml > @@ -0,0 +1,129 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/pinctrl/qcom,sdm670-tlmm.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Qualcomm Technologies, Inc. SDM670 TLMM block > + > +maintainers: > + - Richard Acayan > + > +description: | > + This binding describes the Top Level Mode Multiplexer (TLMM) block found > + in the SDM670 platform. > + > +allOf: > + - $ref: pinctrl.yaml# > + - $ref: /schemas/pinctrl/qcom,tlmm-common.yaml# > + > +properties: > + compatible: > + const: qcom,sdm670-tlmm > + > + reg: > + maxItems: 1 > + > + interrupts: true > + interrupt-controller: true > + '#interrupt-cells': true > + gpio-controller: true > + gpio-reserved-ranges: > + minItems: 1 > + maxItems: 75 > + > + '#gpio-cells': true > + gpio-ranges: true > + wakeup-parent: true > + > +required: > + - compatible > + - reg > + > +additionalProperties: false > + > +patternProperties: > + "-state$": > + oneOf: > + - $ref: "#/$defs/qcom-sdm670-tlmm-state" > + - patternProperties: > + "-pins$": > + $ref: "#/$defs/qcom-sdm670-tlmm-state" > + additionalProperties: false > + > +$defs: > + qcom-sdm670-tlmm-state: > + type: object > + description: > + Pinctrl node's client devices use subnodes for desired pin configuration. > + Client device subnodes use below standard properties. > + $ref: qcom,tlmm-common.yaml#/$defs/qcom-tlmm-state > + > + properties: > + pins: > + description: > + List of gpio pins affected by the properties specified in this > + subnode. > + items: > + oneOf: > + - pattern: "^gpio([0-9]|[1-9][0-9]|1[0-4][0-9])$" > + - enum: [ ufs_reset, sdc1_rclk, sdc1_clk, sdc1_cmd, sdc1_data, > + sdc2_clk, sdc2_cmd, sdc2_data ] > + minItems: 1 > + maxItems: 36 > + > + function: > + description: > + Specify the alternative function to be configured for the specified > + pins. > + > + enum: [ adsp_ext, agera_pll, atest_char, atest_tsens, atest_tsens2, atest_usb1, atest_usb10, > + atest_usb11, atest_usb12, atest_usb13, atest_usb2, atest_usb20, atest_usb21, > + atest_usb22, atest_usb23, cam_mclk, cci_async, cci_i2c, cci_timer0, cci_timer1, > + cci_timer2, cci_timer3, cci_timer4, copy_gp, copy_phase, dbg_out, ddr_bist, > + ddr_pxi0, ddr_pxi1, ddr_pxi2, ddr_pxi3, edp_hot, edp_lcd, gcc_gp1, gcc_gp2, gcc_gp3, > + gp_pdm0, gp_pdm1, gp_pdm2, gpio, gps_tx, jitter_bist, ldo_en, ldo_update, > + lpass_slimbus, m_voc, mdp_vsync, mdp_vsync0, mdp_vsync1, mdp_vsync2, mdp_vsync3, > + mss_lte, nav_pps, pa_indicator, pci_e0, pci_e1, phase_flag, pll_bist, pll_bypassnl, > + pll_reset, pri_mi2s, pri_mi2s_ws, prng_rosc, qdss_cti, qdss, qlink_enable, > + qlink_request, qua_mi2s, qup0, qup1, qup10, qup11, qup12, qup13, qup14, qup15, qup2, > + qup3, qup4, qup5, qup6, qup7, qup8, qup9, qup_l4, qup_l5, qup_l6, sdc4_clk, > + sdc4_cmd, sdc4_data, sd_write, sec_mi2s, ter_mi2s, tgu_ch0, tgu_ch1, tgu_ch2, > + tgu_ch3, tsif1_clk, tsif1_data, tsif1_en, tsif1_error, tsif1_sync, tsif2_clk, > + tsif2_data, tsif2_en, tsif2_error, tsif2_sync, uim1_clk, uim1_data, uim1_present, > + uim1_reset, uim2_clk, uim2_data, uim2_present, uim2_reset, uim_batt, usb_phy, vfr_1, > + vsense_trigger, wlan1_adc0, wlan1_adc1, wlan2_adc0, wlan2_adc1, wsa_clk, wsa_data, ] > + > + > + bias-disable: true > + bias-pull-down: true > + bias-pull-up: true > + drive-strength: true > + input-enable: true > + output-high: true > + output-low: true > + > + required: > + - pins > + > + additionalProperties: false > + > +examples: > + - | > + #include > + pinctrl@3400000 { > + compatible = "qcom,sdm670-tlmm"; > + reg = <0x03400000 0x300000>; > + interrupts = ; > + gpio-controller; > + #gpio-cells = <2>; > + interrupt-controller; > + #interrupt-cells = <2>; > + gpio-ranges = <&tlmm 0 0 151>; > + > + qup-i2c9-state { > + pins = "gpio6", "gpio7"; > + function = "qup9"; > + }; > + }; > +... > -- > 2.37.3 >