linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>
To: Fenghua Yu <fenghua.yu@intel.com>,
	Reinette Chatre <reinette.chatre@intel.com>,
	Shuah Khan <shuah@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
	tan.shaopeng@jp.fujitsu.com
Subject: [PATCH v2 0/4] Some improvements of resctrl selftest
Date: Wed,  5 Oct 2022 10:39:29 +0900	[thread overview]
Message-ID: <20221005013933.1486054-1-tan.shaopeng@jp.fujitsu.com> (raw)

Hello,

The aim of this patch series is to improve the resctrl selftest.
Without these fixes, some unnecessary processing will be executed
and test results will be confusing. 
There is no behavior change in test themselves.

[patch 1] Make write_schemata() run to set up shemata with 100% allocation
	  on first run in MBM test.
[patch 2] The MBA test result message is always output as "ok",
	  make output message to be "not ok" if MBA check result is failed.
[patch 3] Before exiting each test CMT/CAT/MBM/MBA, clear test result 
	  files function cat/cmt/mbm/mba_test_cleanup() are called
	  twice.  Delete once.
[patch 4] When a child process is created by fork(), the buffer of the 
	  parent process is also copied. Flush the buffer before
	  executing fork().

This patch series is based on Linux v6.0-rc7

Difference from v1:
[patch 1] Make write_schemata() always be called, and use 
	  resctrl_val_param->num_of_runs instead of static num_of_runs.
[patch 2] Add Reviewed-by tag.
[patch 3] Remove cat/cmt/mbm/mba_test_cleanup() from run_cmt/mbm/mba_test()
	  and modify changelog.
[patch 4] Add Reviewed-by tag.

Notice that I dropped the one patch from v1 in this series
("[PATCH 4/5] selftests/resctrl: Kill the child process before exiting
the parent process if an exception occurs").
This is because the bug will take some time to fix, I will submit it
separately in the future.

Shaopeng Tan (4):
  selftests/resctrl: Fix set up shemata with 100% allocation on first
    run in MBM test.
  selftests/resctrl: Return MBA check result and make it to output
    message
  selftests/resctrl: Remove duplicate codes that clear each test result
    file
  selftests/resctrl: Flush stdout file buffer before executing fork()

 tools/testing/selftests/resctrl/cat_test.c      | 1 +
 tools/testing/selftests/resctrl/mba_test.c      | 8 ++++----
 tools/testing/selftests/resctrl/mbm_test.c      | 6 +++---
 tools/testing/selftests/resctrl/resctrl_tests.c | 4 ----
 tools/testing/selftests/resctrl/resctrl_val.c   | 1 +
 tools/testing/selftests/resctrl/resctrlfs.c     | 1 +
 6 files changed, 10 insertions(+), 11 deletions(-)

-- 
2.27.0


             reply	other threads:[~2022-10-05  1:44 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-05  1:39 Shaopeng Tan [this message]
2022-10-05  1:39 ` [PATCH v2 1/4] selftests/resctrl: Fix set up shemata with 100% allocation on first run in MBM test Shaopeng Tan
2022-10-05 20:56   ` Reinette Chatre
2022-10-10 20:58   ` kernel test robot
2022-10-05  1:39 ` [PATCH v2 2/4] selftests/resctrl: Return MBA check result and make it to output message Shaopeng Tan
2022-10-05  1:39 ` [PATCH v2 3/4] selftests/resctrl: Remove duplicate codes that clear each test result file Shaopeng Tan
2022-10-05 20:54   ` Reinette Chatre
2022-10-05  1:39 ` [PATCH v2 4/4] selftests/resctrl: Flush stdout file buffer before executing fork() Shaopeng Tan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221005013933.1486054-1-tan.shaopeng@jp.fujitsu.com \
    --to=tan.shaopeng@jp.fujitsu.com \
    --cc=fenghua.yu@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=reinette.chatre@intel.com \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).