From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org,
Ingo Molnar <mingo@redhat.com>,
kernel@pengutronix.de, Wim Van Sebroeck <wim@linux-watchdog.org>,
Guenter Roeck <linux@roeck-us.net>
Subject: Re: [PATCH v2] watchdog: Add tracing events for the most usual watchdog events
Date: Wed, 5 Oct 2022 09:19:46 +0200 [thread overview]
Message-ID: <20221005071946.blttrgv2s5amnrrj@pengutronix.de> (raw)
In-Reply-To: <20221004185146.5d4419ba@gandalf.local.home>
[-- Attachment #1: Type: text/plain, Size: 1597 bytes --]
On Tue, Oct 04, 2022 at 06:51:46PM -0400, Steven Rostedt wrote:
> On Tue, 4 Oct 2022 11:19:49 +0200
> Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote:
>
> > +DEFINE_EVENT(watchdog_template, watchdog_start,
> > + TP_PROTO(struct watchdog_device *wdd, int err),
> > + TP_ARGS(wdd, err));
> > +
> > +TRACE_EVENT(watchdog_set_timeout,
> > +
> > + TP_PROTO(struct watchdog_device *wdd, unsigned int timeout, int err),
> > +
> > + TP_ARGS(wdd, timeout, err),
> > +
> > + TP_STRUCT__entry(
> > + __field(int, id)
> > + __field(unsigned int, timeout)
> > + __field(int, err)
> > + ),
> > +
> > + TP_fast_assign(
> > + __entry->id = wdd->id;
> > + __entry->timeout = timeout;
> > + __entry->err = err;
> > + ),
> > +
> > + TP_printk("watchdog%d timeout=%u err=%d", __entry->id, __entry->timeout, __entry->err)
> > +);
>
> Nit, but I would probably put the above TRACE_EVENT() below the two
> DEFINE_EVENT()s below. That way we have all the DEFINE_EVENT()s for a
> specific DECLARE_EVENT_CLASS() together. Otherwise people may get confused.
I thought about that, too. The argument for the order I chose is that
having start at the start and stop at the end is also intuitive.
But I don't care much and would let the watchdog guys decide what they
prefer.
@Wim+Guenter: Feel free to reorder at application time or ask for a v3
if this v2 doesn't fit your preference.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-10-05 7:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-04 9:19 [PATCH v2] watchdog: Add tracing events for the most usual watchdog events Uwe Kleine-König
2022-10-04 22:51 ` Steven Rostedt
2022-10-05 7:19 ` Uwe Kleine-König [this message]
2022-10-05 19:39 ` Guenter Roeck
2022-10-05 21:11 ` Steven Rostedt
2022-10-08 15:50 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221005071946.blttrgv2s5amnrrj@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).