From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Wolfram Sang <wsa@kernel.org>
Cc: broonie@kernel.org, "Rafael J . Wysocki" <rjw@rjwysocki.net>,
"Daniel Scally" <djrscally@gmail.com>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Linux Next Mailing List" <linux-next@vger.kernel.org>,
"Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Subject: Re: linux-next: manual merge of the pm tree with the i2c tree
Date: Wed, 5 Oct 2022 11:18:36 +1100 [thread overview]
Message-ID: <20221005111836.1d43b228@canb.auug.org.au> (raw)
In-Reply-To: <20220929121853.100271-1-broonie@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 1925 bytes --]
Hi all,
On Thu, 29 Sep 2022 13:18:53 +0100 broonie@kernel.org wrote:
>
> Today's linux-next merge of the pm tree got a conflict in:
>
> drivers/platform/x86/intel/int3472/tps68470.c
>
> between commit:
>
> ed5c2f5fd10dd ("i2c: Make remove callback return void")
>
> from the i2c tree and commit:
>
> 06a659d1f0a0a ("platform/x86: int3472: Support multiple gpio lookups in board data")
>
> from the pm tree.
>
> I fixed it up (see below) and can carry the fix as necessary. This
> is now fixed as far as linux-next is concerned, but any non trivial
> conflicts should be mentioned to your upstream maintainer when your tree
> is submitted for merging. You may also want to consider cooperating
> with the maintainer of the conflicting tree to minimise any particularly
> complex conflicts.
>
> diff --cc drivers/platform/x86/intel/int3472/tps68470.c
> index 5dd81bb05255b,49fc379fe680a..0000000000000
> --- a/drivers/platform/x86/intel/int3472/tps68470.c
> +++ b/drivers/platform/x86/intel/int3472/tps68470.c
> @@@ -178,13 -227,18 +227,16 @@@ static int skl_int3472_tps68470_probe(s
> return ret;
> }
>
> -static int skl_int3472_tps68470_remove(struct i2c_client *client)
> +static void skl_int3472_tps68470_remove(struct i2c_client *client)
> {
> const struct int3472_tps68470_board_data *board_data;
> + int i;
>
> board_data = int3472_tps68470_get_board_data(dev_name(&client->dev));
> - if (board_data)
> - gpiod_remove_lookup_table(board_data->tps68470_gpio_lookup_table);
> + if (board_data) {
> + for (i = 0; i < board_data->n_gpiod_lookups; i++)
> + gpiod_remove_lookup_table(board_data->tps68470_gpio_lookup_tables[i]);
> + }
> -
> - return 0;
> }
>
> static const struct acpi_device_id int3472_device_id[] = {
This is now a conflict between the i2c tree and Linus' tree.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-10-05 0:18 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-29 12:18 linux-next: manual merge of the pm tree with the i2c tree broonie
2022-10-05 0:18 ` Stephen Rothwell [this message]
2022-10-05 7:12 ` Uwe Kleine-König
-- strict thread matches above, loose matches on Subject: below --
2022-02-07 23:11 Stephen Rothwell
2018-10-29 2:09 Stephen Rothwell
2018-10-30 7:32 ` Rafael J. Wysocki
2018-01-11 23:27 Stephen Rothwell
2018-01-12 12:44 ` Rafael J. Wysocki
2016-07-15 2:17 Stephen Rothwell
2016-07-15 2:28 ` Stephen Rothwell
2016-07-15 12:19 ` Rafael J. Wysocki
2016-07-15 12:32 ` Wolfram Sang
2016-07-15 12:40 ` Rafael J. Wysocki
2016-07-15 12:59 ` Rafael J. Wysocki
2016-07-17 18:14 ` Wolfram Sang
2016-07-19 2:41 ` Rafael J. Wysocki
2016-07-19 3:48 ` Wolfram Sang
2016-07-19 12:55 ` Rafael J. Wysocki
2016-07-25 12:03 ` Andy Shevchenko
2016-01-06 1:39 Stephen Rothwell
2016-01-06 2:15 ` Rafael J. Wysocki
2016-01-06 8:20 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221005111836.1d43b228@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=broonie@kernel.org \
--cc=djrscally@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=rjw@rjwysocki.net \
--cc=u.kleine-koenig@pengutronix.de \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).