From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 724F2C433FE for ; Wed, 5 Oct 2022 16:46:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230232AbiJEQqv (ORCPT ); Wed, 5 Oct 2022 12:46:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43962 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229771AbiJEQqs (ORCPT ); Wed, 5 Oct 2022 12:46:48 -0400 Received: from mail-qk1-x736.google.com (mail-qk1-x736.google.com [IPv6:2607:f8b0:4864:20::736]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D2458550AC for ; Wed, 5 Oct 2022 09:46:45 -0700 (PDT) Received: by mail-qk1-x736.google.com with SMTP id g2so10536883qkk.1 for ; Wed, 05 Oct 2022 09:46:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date; bh=Hu+OVpd0/huXrOJ+GKu2yG9DB9Gzph8axQcwOQY12bs=; b=VYnLidyPMfS5NTqFeZ6ttWJQ4mP10seDu1P6JqHrG/pDjjGbtGApkPFkqS2HIDTzpo zkS3RxYis9jbUCTohc6EUokXz269fxSFi4MvcR/0f0Y4IsxYc2TlEO6smw8dCtFbaZlj FVQmXvug6EqnGLfjsLP6UoZK80kacX8yt/oBg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=Hu+OVpd0/huXrOJ+GKu2yG9DB9Gzph8axQcwOQY12bs=; b=AUA0LUn9+p2Yh/g4yk2mV3160hgOh2bS6rv4Zepp4LBXjm49dSPWuazpjWcEJbE2ng rLyGqWAJrjxGhfY5X946wHHjyc02EagsKhsZXTXRpBgDiLRTo6ybQWYKXFAIXCSuH6go HgONIrMjS7j6UN9woenLY/ihjaaI+WmqLSlCFxF/Nsh6AFOFfLNLcI+sXAQGARSwwuDp GYHD9Mj27EP2PkHCEf4ivAV64060GgTeYOvNewmAQXffOkUBFRfCpiH06dhpc1+Lpdzz Wwnj1VUUN6Y1ssChNY3EE4HL1y1wUpCvKIhlDYrkxIqA4ew1bODHlK5O1Kz7A+7UnZi7 UdKQ== X-Gm-Message-State: ACrzQf2+ucuACSwW4D1epVGM4LfsqjVx39EksZAwv29xZZ4qvoxMa8H6 63XjJrhaSUdyrFUG6I2S+erTvyAn3J8tqw== X-Google-Smtp-Source: AMsMyM7xsfKwCg7c8POu4KN/cW/upOGM1YgB6+8M2Up1acHTJ/cyVsXwqyg6sPsa9yBin5GqXt5WpA== X-Received: by 2002:a05:620a:b51:b0:6cf:68b2:d86e with SMTP id x17-20020a05620a0b5100b006cf68b2d86emr390536qkg.176.1664988404901; Wed, 05 Oct 2022 09:46:44 -0700 (PDT) Received: from meerkat.local (bras-base-mtrlpq5031w-grc-33-142-113-79-147.dsl.bell.ca. [142.113.79.147]) by smtp.gmail.com with ESMTPSA id x22-20020a05620a0b5600b006b5c061844fsm16459715qkg.49.2022.10.05.09.46.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Oct 2022 09:46:44 -0700 (PDT) Date: Wed, 5 Oct 2022 12:46:42 -0400 From: Konstantin Ryabitsev To: Dave Chinner Cc: "Darrick J. Wong" , Stephen Rothwell , linux-xfs@vger.kernel.org, Stephen Zhang , Shida Zhang , Linux Kernel Mailing List , Linux Next Mailing List Subject: Re: linux-next: Signed-off-by missing for commit in the xfs tree Message-ID: <20221005164642.qhzyfmsekgqrerhd@meerkat.local> References: <20221004072302.345bfd4a@canb.auug.org.au> <20221003222103.GM3600936@dread.disaster.area> <20221004225012.501e11ed@canb.auug.org.au> <20221004210400.GO3600936@dread.disaster.area> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20221004210400.GO3600936@dread.disaster.area> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 05, 2022 at 08:04:00AM +1100, Dave Chinner wrote: > > That said... I think we should get in the habit of asking patch authors > > to make sure that at least one of the email or name strings match > > between the From and SOB tags. I can see how people who grok even less > > about how Chinese names work than I do (read: lawyers) might get fussy > > about this kind of thing. > > As per above, the normal solution is an explicit "From: " line > that matches the SOB. It's just annoying that our new-fangled tools > haven't encoded this long-standing convention to warn us when we > pull a patch with a from-tag that doesn't match a sob-tag. This is the case of "there's multiple opinions of what's right" here. The logic for matching "person tags" is as follows: - check that entire email matches (a.smith@intel.com == a.smith@intel.com) - failing that, check that the name is a full match ("Alex Smith" == "Alex Smith") - failing that, check if there's a comma in the From and swap it around ("Smith, Alex" == "Alex Smith") The last two checks were added based on a request, I'm pretty sure. Before that we only did full email check and complained about trailer mismatches if it was failing. If the previous behaviour was "more right" then I'm happy to roll back or put this up for a "what is more correct" vote. -K