Re: [PATCH v6 4/4] mm/hwpoison: introduce per-memory_block hwpoison counter

From: "HORIGUCHI NAOYA(堀口　直也)" <naoya.horiguchi@nec.com>
To: Naoya Horiguchi <naoya.horiguchi@linux.dev>
Cc: "linux-mm@kvack.org" <linux-mm@kvack.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Miaohe Lin <linmiaohe@huawei.com>,
	David Hildenbrand <david@redhat.com>,
	Mike Kravetz <mike.kravetz@oracle.com>,
	Yang Shi <shy828301@gmail.com>,
	Oscar Salvador <osalvador@suse.de>,
	Muchun Song <songmuchun@bytedance.com>,
	Jane Chu <jane.chu@oracle.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v6 4/4] mm/hwpoison: introduce per-memory_block hwpoison counter
Date: Fri, 7 Oct 2022 04:34:38 +0000	[thread overview]
Message-ID: <20221007043437.GA3236835@hori.linux.bs1.fc.nec.co.jp> (raw)
In-Reply-To: <20221007010706.2916472-5-naoya.horiguchi@linux.dev>

On Fri, Oct 07, 2022 at 10:07:06AM +0900, Naoya Horiguchi wrote:
...
> diff --git a/drivers/base/memory.c b/drivers/base/memory.c
> index 9aa0da991cfb..5d00d8a14c79 100644
> --- a/drivers/base/memory.c
> +++ b/drivers/base/memory.c
> @@ -175,6 +175,17 @@ int memory_notify(unsigned long val, void *v)
>  	return blocking_notifier_call_chain(&memory_chain, val, v);
>  }
>  
> +#if defined(CONFIG_MEMORY_FAILURE) && defined(CONFIG_MEMORY_HOTPLUG)

> +void memblk_nr_poison_inc(unsigned long pfn);
> +void memblk_nr_poison_sub(unsigned long pfn, long i);

Sorry again, these prototypes should not be necessary. I'll remove these
when I need resubmit the patch series.

It seems that scripts/checkpatch.pl shows the following warning by these.

  WARNING: externs should be avoided in .c files
  #59: FILE: drivers/base/memory.c:180:
  +void memblk_nr_poison_sub(unsigned long pfn, long i);

This disappears by removing the prototypes.

Thanks,
Naoya Horiguchi