[GIT PULL] gfs2 fixes

[GIT PULL] gfs2 fixes

[Andreas Gruenbacher]

Hi Linus,

please consider pulling the following gfs2 fixes.

We have a second small set of changes queued up on top of these fixes [*]; second
pull request to follow.

[*] https://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2.git/log/?h=for-next.nopid

Thank you very much,
Andreas

The following changes since commit 1c23f9e627a7b412978b4e852793c5e3c3efc555:

  Linux 6.0-rc2 (2022-08-21 17:32:54 -0700)

are available in the Git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2.git tags/gfs2-v6.0-rc2-fixes

for you to fetch changes up to 74b1b10e29b1f25e1a081fa82733baea65429d53:

  gfs2: Register fs after creating workqueues (2022-09-20 17:53:54 +0200)

----------------------------------------------------------------
gfs2 fixes

- Make sure to initialize the filesystem work queues before registering
  the filesystem; this prevents them from being used uninitialized.

- On filesystem withdraw: prevent a a double iput() and immediately
  reject pending locking requests that can no longer succeed.

- Use TRY lock in gfs2_inode_lookup() to prevent a rare glock hang
  during evict.

- During filesystem mount, explicitly make sure that the sb_bsize and
  sb_bsize_shift super block fields are consistent with each other.
  This prevents messy error messages during fuzz testing.

- Switch from strlcpy to strscpy.

----------------------------------------------------------------
Andreas Gruenbacher (1):
      gfs2: Switch from strlcpy to strscpy

Andrew Price (1):
      gfs2: Check sb_bsize_shift after reading superblock

Bob Peterson (5):
      gfs2: Use TRY lock in gfs2_inode_lookup for UNLINKED inodes
      gfs2: Prevent double iput for journal on error
      gfs2: Dequeue waiters when withdrawn
      gfs2: Clear flags when withdraw prevents xmote
      gfs2: Register fs after creating workqueues

 fs/gfs2/glock.c      | 44 +++++++++++++++++++++++++++++++++++++++-----
 fs/gfs2/glock.h      |  1 +
 fs/gfs2/inode.c      | 10 ++++++++--
 fs/gfs2/main.c       | 24 ++++++++++++------------
 fs/gfs2/ops_fstype.c | 17 +++++++++++------
 fs/gfs2/util.c       |  6 ++++++
 6 files changed, 77 insertions(+), 25 deletions(-)

Re: [GIT PULL] gfs2 fixes

[pr-tracker-bot]

The pull request you sent on Sun,  9 Oct 2022 12:45:39 +0200:

> git://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2.git tags/gfs2-v6.0-rc2-fixes

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/c7d7d2d345697eb3781198e58a22504feb74af63

Thank you!

-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/prtracker.html

Re: [GIT PULL] gfs2 fixes

[Linus Torvalds]

On Tue, 7 Nov 2023 at 14:18, Andreas Grünbacher
<andreas.gruenbacher@gmail.com> wrote:
>
> I apologize for referring to the entire set of commits as fixes when
> it's really fixes and various other things. I've said so in the tag
> description, but I realize now that that's not good enough. Lying
> about what those commits are wasn't my intention though.

.. and hey, sorry about my outburst.

Your pull request was the first one this merge window where I reacted
to how many of the commits weren't in my copy of the linux-next tree,
and there wasn't any reason why in the description. So I reacted very
strongly.

It didn't help that I had a headache. Rather than look at how many
other of the pending pull requests I have that ended up coming in in
the last 24 hours have the same issue, I decided to lie down in a dark
room for a few hours.

                  Linus

Re: [GIT PULL] gfs2 fixes

[Andreas Grünbacher]

Am Di., 7. Nov. 2023 um 21:31 Uhr schrieb Linus Torvalds
<torvalds@linux-foundation.org>:
> On Tue, 7 Nov 2023 at 06:22, Andreas Gruenbacher <agruenba@redhat.com> wrote:
> >
> > please consider pulling the following gfs2 fixes.
>
> You are officially on my shit-list for
>
>  (a) claiming it's fixes
>
>  (b) apparently lying about that fact to make it appear that it's ok
> that this wasn't in linux-next and was committed within the last few
> days
>
> about half of the commits in that pull request are very recent,
> weren't in linux-next when the merge window started, and while a
> couple of of them are fixes, most of them are just minor cleanups.
>
> DON'T LIE ABOUT THINGS. It only annoys the hell out of me when I
> notice that somebody was trying to pull wool over my eyes.

I apologize for referring to the entire set of commits as fixes when
it's really fixes and various other things. I've said so in the tag
description, but I realize now that that's not good enough. Lying
about what those commits are wasn't my intention though.

And I apologize for the last -minute changes. There is one commit that
removes a single line of dead code which could easily have waited. The
rest are fixes, but they should have been completed much sooner.
That's entirely my fault.

> I've pulled this and I'll let it be (because I already merged other
> stuff on top), but dammit, just be honest about what happened, don't
> try to claim this is somehow "fixes" and thus ok to not have gone
> through linux-next.
>
> Or, better yet, get your ducks actually lined up before the merge window.
>
>                         Linus

Thanks,
Andreas

Re: [GIT PULL] gfs2 fixes

[pr-tracker-bot]

The pull request you sent on Tue,  7 Nov 2023 15:21:53 +0100:

> git://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2.git tags/gfs2-v6.6-rc2-fixes

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/1a0507d8780e2902c4c17c5a4c45d298bd7048af

Thank you!

-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/prtracker.html

Re: [GIT PULL] gfs2 fixes

[Linus Torvalds]

On Tue, 7 Nov 2023 at 06:22, Andreas Gruenbacher <agruenba@redhat.com> wrote:
>
> please consider pulling the following gfs2 fixes.

You are officially on my shit-list for

 (a) claiming it's fixes

 (b) apparently lying about that fact to make it appear that it's ok
that this wasn't in linux-next and was committed within the last few
days

about half of the commits in that pull request are very recent,
weren't in linux-next when the merge window started, and while a
couple of of them are fixes, most of them are just minor cleanups.

DON'T LIE ABOUT THINGS. It only annoys the hell out of me when I
notice that somebody was trying to pull wool over my eyes.

I've pulled this and I'll let it be (because I already merged other
stuff on top), but dammit, just be honest about what happened, don't
try to claim this is somehow "fixes" and thus ok to not have gone
through linux-next.

Or, better yet, get your ducks actually lined up before the merge window.

                        Linus

[GIT PULL] gfs2 fixes

[Andreas Gruenbacher]

Hi Linus,

please consider pulling the following gfs2 fixes.

Thank you very much,
Andreas

The following changes since commit a49d273e579615ed63d0347f94075dd22b9458a3:

  Merge tag 'gfs2-v6.6-rc1-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2 (2023-09-18 11:59:38 -0700)

are available in the Git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2.git tags/gfs2-v6.6-rc2-fixes

for you to fetch changes up to 0cdc6f44e9fdc2d20d720145bf99a39f611f6d61:

  gfs2: don't withdraw if init_threads() got interrupted (2023-11-06 01:51:26 +0100)

----------------------------------------------------------------
gfs2 fixes

- Don't update inode timestamps for direct writes (performance regression fix).

- Skip no-op quota records instead of panicing.

- Fix a RCU race in gfs2_permission().

- Various other smaller fixes and cleanups all over the place.

----------------------------------------------------------------
Al Viro (1):
      gfs2: fix an oops in gfs2_permission

Amir Goldstein (1):
      gfs2: fs: derive f_fsid from s_uuid

Andreas Gruenbacher (19):
      gfs2: Simplify function gfs2_upgrade_iopen_glock
      gfs2: Remove freeze_go_demote_ok
      gfs2: Remove unused gfs2_extent_length argument
      gfs2: Get rid of the gfs2_glock_is_held_* helpers
      gfs2: Don't update inode timestamps for direct writes
      gfs2: setattr_chown: Add missing initialization
      gfs2: Stop using GFS2_BASIC_BLOCK and GFS2_BASIC_BLOCK_SHIFT
      gfs2: Two quota=account mode fixes
      gfs2: Clean up gfs2_alloc_parms initializers
      gfs2: Clean up quota.c:print_message
      gfs2: Add metapath_dibh helper
      gfs2: Get rid of gfs2_alloc_blocks generation parameter
      gfs2: Minor gfs2_write_jdata_batch PAGE_SIZE cleanup
      gfs2: Convert stuffed_readpage to folios
      gfs2: Convert gfs2_internal_read to folios
      gfs2: Rename gfs2_lookup_{ simple => meta }
      gfs2: No longer use 'extern' in function declarations
      gfs2: Silence "suspicious RCU usage in gfs2_permission" warning
      gfs2: don't withdraw if init_threads() got interrupted

Bob Peterson (1):
      gfs2: ignore negated quota changes

Juntong Deng (1):
      gfs2: Fix slab-use-after-free in gfs2_qd_dealloc

Su Hui (1):
      gfs2: remove dead code in add_to_queue

 fs/gfs2/acl.h        |   8 ++--
 fs/gfs2/aops.c       |  72 ++++++++++++++++----------------
 fs/gfs2/aops.h       |   6 +--
 fs/gfs2/bmap.c       |  17 +++++---
 fs/gfs2/bmap.h       |  38 ++++++++---------
 fs/gfs2/dir.c        |   2 +-
 fs/gfs2/dir.h        |  38 ++++++++---------
 fs/gfs2/file.c       |  18 +++++---
 fs/gfs2/glock.c      |   1 -
 fs/gfs2/glock.h      | 113 ++++++++++++++++++++++-----------------------------
 fs/gfs2/glops.c      |  13 ------
 fs/gfs2/glops.h      |   4 +-
 fs/gfs2/incore.h     |   2 +-
 fs/gfs2/inode.c      |  33 +++++++++------
 fs/gfs2/inode.h      |  60 +++++++++++++--------------
 fs/gfs2/log.h        |  46 ++++++++++-----------
 fs/gfs2/lops.h       |  22 +++++-----
 fs/gfs2/meta_io.h    |  20 ++++-----
 fs/gfs2/ops_fstype.c |  28 ++++++-------
 fs/gfs2/quota.c      |  31 +++++++++-----
 fs/gfs2/quota.h      |  38 ++++++++---------
 fs/gfs2/recovery.h   |  18 ++++----
 fs/gfs2/rgrp.c       |  12 +++---
 fs/gfs2/rgrp.h       |  85 +++++++++++++++++++-------------------
 fs/gfs2/super.c      |  29 +++++--------
 fs/gfs2/super.h      |  50 +++++++++++------------
 fs/gfs2/trans.h      |  24 +++++------
 fs/gfs2/util.h       |   8 ++--
 fs/gfs2/xattr.c      |   6 +--
 fs/gfs2/xattr.h      |  12 +++---
 30 files changed, 421 insertions(+), 433 deletions(-)

Re: [GIT PULL] gfs2 fixes

[pr-tracker-bot]

The pull request you sent on Mon, 18 Sep 2023 16:34:38 +0200:

> git://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2.git tags/gfs2-v6.6-rc1-fixes

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/a49d273e579615ed63d0347f94075dd22b9458a3

Thank you!

-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/prtracker.html

[GIT PULL] gfs2 fixes

[Andreas Gruenbacher]

Hello Linus,

pleae consider pulling the following gfs2 fixes.

Thank you,
Andreas

The following changes since commit 65d6e954e37872fd9afb5ef3fc0481bb3c2f20f4:

  Merge tag 'gfs2-v6.5-rc5-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2 (2023-09-05 13:00:28 -0700)

are available in the Git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2.git tags/gfs2-v6.6-rc1-fixes

for you to fetch changes up to fb95d536080e6c1db099f0023f59cd55adcc5d87:

  gfs2: Fix quota=quiet oversight (2023-09-18 16:26:24 +0200)

----------------------------------------------------------------
gfs2 fixes

- Fix another freeze/thaw hang

- Fix glock cache shrinking

- Fix the quota=quiet mount option.

----------------------------------------------------------------
Andreas Gruenbacher (1):
      gfs2: Fix another freeze/thaw hang

Bob Peterson (2):
      gfs2: fix glock shrinker ref issues
      gfs2: Fix quota=quiet oversight

 fs/gfs2/glock.c | 4 +++-
 fs/gfs2/glops.c | 9 +++++----
 fs/gfs2/quota.h | 3 ++-
 3 files changed, 10 insertions(+), 6 deletions(-)

Re: [GIT PULL] gfs2 fixes

[pr-tracker-bot]

The pull request you sent on Tue,  5 Sep 2023 18:12:46 +0200:

> git://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2.git tags/gfs2-v6.5-rc5-fixes

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/65d6e954e37872fd9afb5ef3fc0481bb3c2f20f4

Thank you!

-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/prtracker.html

[GIT PULL] gfs2 fixes

[Andreas Gruenbacher]

Hi Linus,

please consider pulling the following gfs2 fixes (*) into the current merge window.

(*) Technically, this updates the address of the shared gfs2 and dlm mailing list
    so this affects dlm as well; I've coordinated this change with David Teigland.

Thanks,
Andreas

The following changes since commit 02aee814d37c563e24b73bcd0f9cb608fbd403d4:

  Merge tag 'gfs2-v6.4-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2 (2023-08-08 09:27:08 -0700)

are available in the Git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2.git tags/gfs2-v6.5-rc5-fixes

for you to fetch changes up to 2938fd750e8b73a6dac4d9339fb6f7f1cd624a2d:

  MAINTAINERS: Update dlm mailing list (2023-09-05 17:43:07 +0200)

----------------------------------------------------------------
gfs2 fixes

- Fix a glock state (non-)transition bug when a dlm request times out
  and is canceled, and we have locking requests that can now be granted
  immediately.

- Various fixes and cleanups in how the logd and quotad daemons are
  woken up and terminated.

- Fix several bugs in the quota data reference counting and shrinking.
  Free quota data objects synchronously in put_super() instead of
  letting call_rcu() run wild.

- Make sure not to deallocate quota data during a withdraw; rather, defer
  quota data deallocation to put_super().  Withdraws can happen in
  contexts in which callers on the stack are holding quota data references.

- Many minor quota fixes and cleanups by Bob.

- Update the the mailing list address for gfs2 and dlm.  (It's the same
  list for both and we are moving it to gfs2@lists.linux.dev.)

- Various other minor cleanups.

----------------------------------------------------------------
Andreas Gruenbacher (24):
      gfs2: Use mapping->gfp_mask for metadata inodes
      gfs: Don't use GFP_NOFS in gfs2_unstuff_dinode
      gfs2: do_promote cleanup
      gfs2: Remove LM_FLAG_PRIORITY flag
      gfs2: Switch to wait_event in gfs2_logd
      gfs2: low-memory forced flush fixes
      gfs2: Fix logd wakeup on I/O error
      gfs2: journal flush threshold fixes and cleanup
      gfs2: Rename sd_{ glock => kill }_wait
      gfs2: Rename SDF_DEACTIVATING to SDF_KILL
      gfs2: Fix wrong quota shrinker return value
      gfs2: Use gfs2_qd_dispose in gfs2_quota_cleanup
      gfs2: Factor out duplicate quota data disposal code
      gfs2: No more quota complaints after withdraw
      gfs2: Fix initial quota data refcount
      gfs2: Free quota data objects synchronously
      gfs2: Stop using gfs2_make_fs_ro for withdraw
      gfs2: Fix asynchronous thread destruction
      gfs2: Switch to wait_event in gfs2_quotad
      gfs2: Sanitize kthread stopping
      gfs2: Fix withdraw race
      gfs2: Rename "gfs_recovery" workqueue to "gfs2_recovery"
      gfs2: Rename "freeze_workqueue" to "gfs2_freeze"
      gfs2: Add device name to gfs2_logd and gfs2_quotad

Andrew Price (2):
      MAINTAINERS: Update gfs2 mailing list
      MAINTAINERS: Update dlm mailing list

Bob Peterson (24):
      gfs2: conversion deadlock do_promote bypass
      gfs2: Use qd_sbd more consequently
      gfs2: Introduce new quota=quiet mount option
      gfs2: remove dead code for quota writes
      gfs2: Pass sdp to gfs2_adjust_quota
      gfs2: pass sdp in to gfs2_write_disk_quota
      gfs2: pass sdp to gfs2_write_buf_to_page
      gfs2: remove unneeded variable done
      gfs2: remove unneeded pg_oflow variable
      gfs2: Simplify function need_sync
      gfs2: Don't try to sync non-changes
      gfs2: improvements to sysfs status
      gfs2: move qdsb_put and reduce redundancy
      gfs2: Small gfs2_quota_lock cleanup
      gfs2: Remove useless err set
      gfs2: Set qd_sync_gen in do_sync
      gfs2: use constant for array size
      gfs2: Remove quota allocation info from quota file
      gfs2: introduce qd_bh_get_or_undo
      gfs2: Simplify qd2offset
      gfs2: simplify slot_get
      gfs2: Remove useless assignment
      gfs2: check for no eligible quota changes
      gfs2: change qd_slot_count to qd_slot_ref

Minjie Du (1):
      gfs2: increase usage of folio_next_index() helper

 Documentation/filesystems/gfs2-glocks.rst |   3 +-
 MAINTAINERS                               |   4 +-
 fs/gfs2/aops.c                            |   7 +-
 fs/gfs2/bmap.c                            |   2 +-
 fs/gfs2/glock.c                           |  47 ++--
 fs/gfs2/glock.h                           |   9 -
 fs/gfs2/glops.c                           |   2 +-
 fs/gfs2/incore.h                          |   7 +-
 fs/gfs2/inode.c                           |  14 +-
 fs/gfs2/lock_dlm.c                        |   5 -
 fs/gfs2/log.c                             |  69 +++---
 fs/gfs2/lops.c                            |   7 +-
 fs/gfs2/main.c                            |  10 +-
 fs/gfs2/ops_fstype.c                      |  42 ++--
 fs/gfs2/quota.c                           | 368 ++++++++++++++++--------------
 fs/gfs2/recovery.c                        |   4 +-
 fs/gfs2/recovery.h                        |   2 +-
 fs/gfs2/super.c                           |  28 +--
 fs/gfs2/super.h                           |   1 +
 fs/gfs2/sys.c                             |  12 +-
 fs/gfs2/util.c                            |  34 +--
 21 files changed, 347 insertions(+), 330 deletions(-)

[GIT PULL] gfs2 fixes

[Andreas Gruenbacher]

Hi Linus,

please consider pulling the following two gfs2 fixes.

Thanks,
Andreas

The following changes since commit 94c76955e86a5a4f16a1d690b66dcc268c156e6a:

  Merge tag 'gfs2-v6.4-rc5-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2 (2023-07-04 11:45:16 -0700)

are available in the Git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2.git tags/gfs2-v6.4-fixes

for you to fetch changes up to 0be8432166a61abc537e1247e530f4b85970b56b:

  gfs2: Don't use filemap_splice_read (2023-08-07 18:42:04 +0200)

----------------------------------------------------------------
gfs2 fixes

- Fix a freeze consistency check in gfs2_trans_add_meta().

- Don't use filemap_splice_read as it can cause deadlocks on gfs2.

----------------------------------------------------------------
Andreas Gruenbacher (1):
      gfs2: Fix freeze consistency check in gfs2_trans_add_meta

Bob Peterson (1):
      gfs2: Don't use filemap_splice_read

 fs/gfs2/file.c  |  4 ++--
 fs/gfs2/trans.c | 14 ++++++++++----
 2 files changed, 12 insertions(+), 6 deletions(-)

Re: [GIT PULL] gfs2 fixes

[pr-tracker-bot]

The pull request you sent on Tue,  4 Jul 2023 14:51:11 +0200:

> git://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2.git tags/gfs2-v6.4-rc5-fixes

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/94c76955e86a5a4f16a1d690b66dcc268c156e6a

Thank you!

-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/prtracker.html

[GIT PULL] gfs2 fixes

[Andreas Gruenbacher]

Hi Linus,

please consider pulling the following gfs2 fixes.

Thanks a lot,
Andreas

The following changes since commit 0bdd0f0bf17c5aac16f348ee4b1ebf23d1ec1649:

  Merge tag 'gfs2-v6.4-rc4-fix' of git://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2 (2023-06-06 05:49:06 -0700)

are available in the Git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2.git tags/gfs2-v6.4-rc5-fixes

for you to fetch changes up to 432928c9377959684c748a9bc6553ed2d3c2ea4f:

  gfs2: Add quota_change type (2023-07-03 22:30:48 +0200)

----------------------------------------------------------------
gfs2 fixes

- Move the freeze/thaw logic from glock callback context to process /
  worker thread context to prevent deadlocks.

- Fix a quota reference couting bug in do_qc().

- Carry on deallocating inodes even when gfs2_rindex_update() fails.

- Retry filesystem-internal reads when they are interruped by a signal.

- Eliminate kmap_atomic() in favor of kmap_local_page() /
  memcpy_{from,to}_page().

- Get rid of noop_direct_IO.

- And a few more minor fixes and cleanups.

----------------------------------------------------------------
Andreas Gruenbacher (12):
      gfs2: retry interrupted internal reads
      gfs2: Rename remaining "transaction" glock references
      gfs2: Rename the {freeze,thaw}_super callbacks
      gfs2: Rename gfs2_freeze_lock{ => _shared }
      gfs2: Reconfiguring frozen filesystem already rejected
      gfs2: Rename SDF_{FS_FROZEN => FREEZE_INITIATOR}
      gfs2: Rework freeze / thaw logic
      gfs2: Replace sd_freeze_state with SDF_FROZEN flag
      gfs2: gfs2_freeze_lock_shared cleanup
      gfs: Get rid of unnucessary locking in inode_go_dump
      gfs2: Convert remaining kmap_atomic calls to kmap_local_page
      gfs2: Use memcpy_{from,to}_page where appropriate

Bob Peterson (8):
      gfs2: simplify gdlm_put_lock with out_free label
      gfs2: fix minor comment typos
      gfs2: ignore rindex_update failure in dinode_dealloc
      gfs2: Fix gfs2_qa_get imbalance in gfs2_quota_hold
      gfs2: Update rl_unlinked before releasing rgrp lock
      gfs2: Don't remember delete unless it's successful
      gfs2: Fix duplicate should_fault_in_pages() call
      gfs2: Add quota_change type

Christoph Hellwig (1):
      gfs2: set FMODE_CAN_ODIRECT instead of a dummy direct_IO method

Deepak R Varma (1):
      gfs2: Replace deprecated kmap_atomic with kmap_local_page

Tuo Li (1):
      gfs2: Fix possible data races in gfs2_show_options()

 fs/gfs2/aops.c       |  19 +++--
 fs/gfs2/bmap.c       |   4 +-
 fs/gfs2/file.c       |   5 +-
 fs/gfs2/glock.c      |   4 +-
 fs/gfs2/glops.c      |  69 ++++++-----------
 fs/gfs2/incore.h     |  12 +--
 fs/gfs2/lock_dlm.c   |  23 +++---
 fs/gfs2/log.c        |  11 +--
 fs/gfs2/lops.c       |  21 +++--
 fs/gfs2/ops_fstype.c |  15 +---
 fs/gfs2/quota.c      |  26 ++++---
 fs/gfs2/recovery.c   |  28 +++----
 fs/gfs2/rgrp.c       |   2 +-
 fs/gfs2/super.c      | 215 ++++++++++++++++++++++++++++++++++++---------------
 fs/gfs2/super.h      |   1 +
 fs/gfs2/sys.c        |   4 +-
 fs/gfs2/trans.c      |   3 +-
 fs/gfs2/util.c       |  49 ++++--------
 fs/gfs2/util.h       |   3 +-
 19 files changed, 277 insertions(+), 237 deletions(-)

Re: [GIT PULL] gfs2 fixes

[pr-tracker-bot]

The pull request you sent on Wed, 22 Feb 2023 13:01:06 +0100:

> git://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2.git tags/gfs2-v6.2-rc5-fixes

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/b7ee88128242b3460b0016a7e42207c9799f73b7

Thank you!

-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/prtracker.html

[GIT PULL] gfs2 fixes

[Andreas Gruenbacher]

Hi Linus,

please consider pulling the following gfs2 fixes.

These fixes are based on the latest iomap-for-next branch, for which
Darrick has sent a pull request earlier today:

https://lore.kernel.org/linux-fsdevel/167703901677.1909640.1798642413122202835.stg-ugh@magnolia/

Thanks,
Andreas


The following changes since commit 63510d9f2f6e6337960499a3d72d5a457b19c287:

  Merge branch 'iomap-for-next' of git://git.kernel.org/pub/scm/fs/xfs/xfs-linux.git (2023-01-24 12:51:39 +0100)

are available in the Git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2.git tags/gfs2-v6.2-rc5-fixes

for you to fetch changes up to c1b0c3cfcbad25d2c412863c27638c933f1d911b:

  gfs2: Convert gfs2_page_add_databufs to folios (2023-02-22 12:06:20 +0100)

----------------------------------------------------------------
gfs2 fixes

- Fix a race when disassociating inodes from their glocks after
  iget_failed().

- On filesystems with a block size smaller than the page size, make
  sure that ->writepages() writes out all buffers of journaled inodes.

- Various improvements to the way the delete workqueue is drained to
  speed up unmount and prevent leftover inodes.  At unmount time, evict
  deleted inodes cooperatively across the cluster to avoid unnecessary
  timeouts.

- Various minor cleanups and fixes.

----------------------------------------------------------------
Andreas Gruenbacher (12):
      gfs2: gl_object races fix
      gfs2: Improve gfs2_upgrade_iopen_glock comment
      gfs2: Clean up gfs2_scan_glock_lru
      gfs2: Make glock lru list scanning safer
      gfs2: Get rid of GLF_PENDING_DELETE flag
      gfs2: Move delete workqueue into super block
      gfs2: Split the two kinds of glock "delete" work
      gfs2: Flush delete work before shrinking inode cache
      gfs2: Evict inodes cooperatively
      gfs2: Improve gfs2_make_fs_rw error handling
      gfs2: jdata writepage fix
      gfs2: Convert gfs2_page_add_databufs to folios

Bob Peterson (4):
      gfs2: check gl_object in rgrp glops
      gfs2: Add SDF_DEACTIVATING super block flag
      gfs2: Cease delete work during unmount
      Revert "GFS2: free disk inode which is deleted by remote node -V2"

 fs/gfs2/aops.c       |   9 ++--
 fs/gfs2/aops.h       |   4 +-
 fs/gfs2/bmap.c       |   4 +-
 fs/gfs2/dentry.c     |  18 --------
 fs/gfs2/glock.c      | 128 +++++++++++++++++++++++++--------------------------
 fs/gfs2/glock.h      |   4 +-
 fs/gfs2/glops.c      |  21 ++++-----
 fs/gfs2/incore.h     |  11 ++++-
 fs/gfs2/inode.c      |   8 ++++
 fs/gfs2/ops_fstype.c |  71 +++++++++++++++++++++++++++-
 fs/gfs2/rgrp.c       |   2 +-
 fs/gfs2/super.c      |  49 ++++++++++++++------
 fs/gfs2/sys.c        |   2 +
 13 files changed, 204 insertions(+), 127 deletions(-)

Re: [GIT PULL] gfs2 fixes

[pr-tracker-bot]

The pull request you sent on Fri, 16 Dec 2022 15:33:17 +0100:

> git://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2.git tags/gfs2-v6.1-rc7-fixes

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/6830d50325ee27fbf0150f77cbec1ed304a5b8f6

Thank you!

-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/prtracker.html

[GIT PULL] gfs2 fixes

[Andreas Gruenbacher]

Hi Linus,

please consider pulling the following gfs2 fixes.

Thank you very much,
Andreas


The following changes since commit b7b275e60bcd5f89771e865a8239325f86d9927d:

  Linux 6.1-rc7 (2022-11-27 13:31:48 -0800)

are available in the Git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2.git tags/gfs2-v6.1-rc7-fixes

for you to fetch changes up to 6b46a06100dd0e0ebe400573e94ccd09163bfd5b:

  gfs2: Remove support for glock holder auto-demotion (2) (2022-12-15 12:41:22 +0100)

----------------------------------------------------------------
gfs2 fixes

- Revert a change to delete_work_func() that has gone wrong in commit
  c412a97cf6c5 ("gfs2: Use TRY lock in gfs2_inode_lookup for UNLINKED
  inodes").

- Avoid dequeuing GL_ASYNC glock holders twice by first checking if the
  holder is still queued.

- gfs2: Always check the inode size of inline inodes when reading in
  inodes to prevent corrupt filesystem images from causing weid errors.

- Properly handle a race between gfs2_create_inode() and
  gfs2_inode_lookup() that causes insert_inode_locked4() to return
  -EBUSY.

- Fix and clean up the interaction between gfs2_create_inode() and
  gfs2_evict_inode() by completely handling the inode deallocation and
 destruction in gfs2_evict_inode().

- Remove support for glock holder auto-demotion as we have no current
  plans of using this feature again.

- And a few more minor cleanups and clarifications.

----------------------------------------------------------------
Andreas Gruenbacher (17):
      gfs2: Add extra error check in alloc_dinode
      gfs2: Get rid of ghs[] in gfs2_create_inode
      gfs2: Clean up initialization of "ip" in gfs2_create_inode
      gfs2: Fix and clean up create / evict interaction
      gfs2: Handle -EBUSY result of insert_inode_locked4
      gfs2: Cosmetic gfs2_dinode_{in,out} cleanup
      gfs2: Always check inode size of inline inodes
      gfs2: Make gfs2_glock_hold return its glock argument
      gfs2: Avoid dequeuing GL_ASYNC glock holders twice
      gfs2: Clean up after gfs2_create_inode rework
      gfs2: Simply dequeue iopen glock in gfs2_evict_inode
      gfs2: Uninline and improve glock_{set,clear}_object
      gfs2: Add gfs2_inode_lookup comment
      gfs2: Partially revert gfs2_inode_lookup change
      gfs2: Minor gfs2_try_evict cleanup
      gfs2: Remove support for glock holder auto-demotion
      gfs2: Remove support for glock holder auto-demotion (2)

 fs/gfs2/aops.c    |   2 -
 fs/gfs2/bmap.c    |   3 -
 fs/gfs2/file.c    |   3 +-
 fs/gfs2/glock.c   | 269 ++++++++++++++++++++----------------------------------
 fs/gfs2/glock.h   |  65 +------------
 fs/gfs2/glops.c   |  44 +++++----
 fs/gfs2/incore.h  |   1 -
 fs/gfs2/inode.c   |  64 +++++++------
 fs/gfs2/meta_io.c |   6 ++
 fs/gfs2/super.c   |  84 +++++++++--------
 fs/gfs2/xattr.c   |  26 +++---
 11 files changed, 234 insertions(+), 333 deletions(-)

Re: [GIT PULL] gfs2 fixes

[pr-tracker-bot]

The pull request you sent on Fri,  5 Aug 2022 22:12:48 +0200:

> git://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2.git tags/gfs2-v5.19-rc4-fixes

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/c42b729ef6bfc72fed56f81f589a39298b9d12c8

Thank you!

-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/prtracker.html

[GIT PULL] gfs2 fixes

[Andreas Gruenbacher]

Hi Linus,

please consider pulling the following gfs2 fixes.

Thank you very much,
Andreas

The following changes since commit 03c765b0e3b4cb5063276b086c76f7a612856a9a:

  Linux 5.19-rc4 (2022-06-26 14:22:10 -0700)

are available in the Git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2.git tags/gfs2-v5.19-rc4-fixes

for you to fetch changes up to 446279168e030fd0ed68e2bba336bef8bb3da352:

  Merge part of branch 'for-next.instantiate' into for-next (2022-08-05 18:37:03 +0200)

----------------------------------------------------------------
gfs2 fixes

- Instantiate glocks ouside of the glock state engine, in the contect of
  the process taking the glock.  This moves unnecessary complexity out
  of the core glock code.  Clean up the instantiate logic to be more
  sensible.

- In gfs2_glock_async_wait(), cancel pending locking request upon
  failure.  Make sure all glocks are left in a consistent state.

- Various other minor cleanups and fixes.

----------------------------------------------------------------
Andreas Gruenbacher (9):
      gfs2: Minor gfs2_glock_nq_m cleanup
      gfs2: Fix up gfs2_glock_async_wait
      gfs2: Instantiate glocks ouside of glock state engine
      gfs2: Revert 'Fix "truncate in progress" hang'
      gfs2: Add new go_held glock operation
      gfs2: Make go_instantiate take a glock
      gfs2: Use better variable name
      gfs2: List traversal in do_promote is safe
      Merge part of branch 'for-next.instantiate' into for-next

Bob Peterson (2):
      gfs2: Rewrap overlong comment in do_promote
      gfs2: do_promote glock holder stealing fix

Minghao Chi (1):
      gfs2: Remove redundant NULL check before kfree

Zhang Jiaming (1):
      gfs2: Fix spelling mistake in comment

 fs/gfs2/dir.c        |   2 +-
 fs/gfs2/file.c       |   3 +-
 fs/gfs2/glock.c      | 200 ++++++++++++++++++++-------------------------------
 fs/gfs2/glock.h      |   2 +-
 fs/gfs2/glops.c      |  31 ++++----
 fs/gfs2/incore.h     |   6 +-
 fs/gfs2/lock_dlm.c   |   2 +-
 fs/gfs2/main.c       |   1 -
 fs/gfs2/ops_fstype.c |   2 -
 fs/gfs2/quota.c      |  28 +-------
 fs/gfs2/rgrp.c       |  12 ++--
 fs/gfs2/rgrp.h       |   5 +-
 fs/gfs2/super.c      |   2 +-
 fs/gfs2/xattr.c      |   2 +-
 14 files changed, 111 insertions(+), 187 deletions(-)

Re: [GIT PULL] gfs2 fixes

[pr-tracker-bot]

The pull request you sent on Tue, 24 May 2022 21:41:45 +0200:

> git://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2.git tags/gfs2-v5.18-rc6-fixes

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/7208c9842c50f97327aac20be62edc8ad230f05c

Thank you!

-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/prtracker.html

[GIT PULL] gfs2 fixes

[Andreas Gruenbacher]

Hi Linus,

please consider pulling the following gfs2 fixes for 5.19.

Thank you very much,
Andreas

The following changes since commit d928e8f3af38abc8d2d56d9329a8280f7af5f10e:

  Merge tag 'gfs2-v5.18-rc4-fix3' of git://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2 (2022-05-13 14:32:53 -0700)

are available in the Git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2.git tags/gfs2-v5.18-rc6-fixes

for you to fetch changes up to c360abbb9db298d0548b31e1a86a48ebb157d7cd:

  gfs2: Convert function bh_get to use iomap (2022-05-24 21:29:14 +0200)

----------------------------------------------------------------
gfs2 fixes

- Clean up the allocation of glocks that have an address space attached.
- Quota locking fix and quota iomap conversion.
- Fix the FITRIM error reporting.
- Some list iterator cleanups.

----------------------------------------------------------------
Andreas Gruenbacher (1):
      gfs2: Explain some direct I/O oddities

Andrew Price (1):
      gfs2: Return more useful errors from gfs2_rgrp_send_discards()

Bob Peterson (2):
      gfs2: use i_lock spin_lock for inode qadata
      gfs2: Convert function bh_get to use iomap

Jakob Koschel (1):
      gfs2: replace 'found' with dedicated list iterator variable

Kees Cook (1):
      gfs2: Use container_of() for gfs2_glock(aspace)

 fs/gfs2/file.c     |  4 ++++
 fs/gfs2/glock.c    | 35 ++++++++++++++++--------------
 fs/gfs2/glock.h    | 12 +++++++++--
 fs/gfs2/main.c     | 10 ++++-----
 fs/gfs2/meta_io.h  |  8 ++++---
 fs/gfs2/quota.c    | 62 ++++++++++++++++++++++++++++++++----------------------
 fs/gfs2/recovery.c | 22 +++++++++----------
 fs/gfs2/rgrp.c     |  4 ++--
 8 files changed, 91 insertions(+), 66 deletions(-)

Re: [GIT PULL] gfs2 fixes

[pr-tracker-bot]

The pull request you sent on Fri, 13 May 2022 23:07:10 +0200:

> https://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2.git tags/gfs2-v5.18-rc4-fix3

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/d928e8f3af38abc8d2d56d9329a8280f7af5f10e

Thank you!

-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/prtracker.html

Re: [GIT PULL] gfs2 fixes

[Linus Torvalds]

On Fri, May 13, 2022 at 2:07 PM Andreas Gruenbacher <agruenba@redhat.com> wrote:
>
> Would you like to still pull these fixes for v5.18, or should we send them in
> the next merge window?

I've pulled them. Any filesystem corruption issue sounds scary enough
that it doesn't sound very sane to delay fixes.

            Linus

[GIT PULL] gfs2 fixes

[Andreas Gruenbacher]

Hi Linus,

we've finally identified commit dc732906c245 ("gfs2: Introduce flag for glock
holder auto-demotion") to be the other cause of the filesystem corruption we've
been seeing.  This feature isn't strictly necessary anymore, so we've decided
to stop using it for now.  With this and the gfs_iomap_end rounding fix you've
already seen ("gfs2: Fix filesystem block deallocation for short writes" in
this pull request), we're corruption free again now.

Would you like to still pull these fixes for v5.18, or should we send them in
the next merge window?

Thanks again for all the help you've provided.

Andreas

The following changes since commit 4a2316a1eda4ef3ced18c7f08f7cb3726bcae44b:

  Merge tag 'gfs2-v5.18-rc4-fix2' of git://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2 (2022-04-28 09:50:29 -0700)

are available in the Git repository at:

  https://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2.git tags/gfs2-v5.18-rc4-fix3

for you to fetch changes up to e1fa9ea85ce89207d2ac0316da35a4a7736801f9:

  gfs2: Stop using glock holder auto-demotion for now (2022-05-13 22:32:52 +0200)

----------------------------------------------------------------
gfs2 fixes

- Fix filesystem block deallocation for short writes.
- Stop using glock holder auto-demotion for now.
- Get rid of buffered writes inefficiencies due to page
  faults being disabled.
- Minor other cleanups.

----------------------------------------------------------------
Andreas Gruenbacher (7):
      gfs2: Fix filesystem block deallocation for short writes
      gfs2: Variable rename
      gfs2: Clean up use of fault_in_iov_iter_{read,write}able
      gfs2: Pull return value test out of should_fault_in_pages
      gfs2: Align read and write chunks to the page cache
      gfs2: buffered write prefaulting
      gfs2: Stop using glock holder auto-demotion for now

 fs/gfs2/bmap.c |  11 +++--
 fs/gfs2/file.c | 139 ++++++++++++++++++++++++++-------------------------------
 2 files changed, 68 insertions(+), 82 deletions(-)

Re: [GIT PULL] gfs2 fixes

[Andreas Gruenbacher]

On Fri, Feb 11, 2022 at 8:48 PM Linus Torvalds
<torvalds@linux-foundation.org> wrote:
> On Fri, Feb 11, 2022 at 9:05 AM Andreas Gruenbacher <agruenba@redhat.com> wrote:
> >
> > * Revert debug commit that causes unexpected data corruption.
>
> Well, apparently not just unexpected, but unexplained too.
>
> That's a bit worrisome. It sounds like the corruption cause is still
> there, just hidden by the lack of __cond_resched()?

Yes, that's what it looks like. My initial suspicion was that we're
somewhere using gfs2_glock_dq() in non-sleepable context when we know
that we're not dropping the last reference and so gfs2_glock_dq()
won't sleep, but there's no such instance in the code, and testing
would also have revealed such cases. The corruption we've seen always
affects whole pages/blocks. Maybe it's an ordering / memory barrier
issue.

Thanks,
Andreas

Re: [GIT PULL] gfs2 fixes

[pr-tracker-bot]

The pull request you sent on Fri, 11 Feb 2022 18:05:22 +0100:

> git://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2.git tags/gfs2-v5.16-rc3-fixes2

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/8ce964b520ad0ad626cb1ee93a444aedceed5425

Thank you!

-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/prtracker.html

Re: [GIT PULL] gfs2 fixes

[Linus Torvalds]

On Fri, Feb 11, 2022 at 9:05 AM Andreas Gruenbacher <agruenba@redhat.com> wrote:
>
> * Revert debug commit that causes unexpected data corruption.

Well, apparently not just unexpected, but unexplained too.

That's a bit worrisome. It sounds like the corruption cause is still
there, just hidden by the lack of __cond_resched()?

                Linus

[GIT PULL] gfs2 fixes

[Andreas Gruenbacher]

Hi Linus,

please consider pulling the following two gfs2 fixes for 5.17-rc4.

Thanks,
Andreas

The following changes since commit 74382e277ae97b4bcfac6f8b61df7a500d392500:

  gfs2: dump inode object for iopen glocks (2022-01-11 16:52:44 +0100)

are available in the Git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2.git tags/gfs2-v5.16-rc3-fixes2

for you to fetch changes up to d3add1a9519dcacd6e644ecac741c56cf18b67f5:

  gfs2: Fix gfs2_release for non-writers regression (2022-02-11 17:44:42 +0100)

----------------------------------------------------------------
gfs2 fixes:
* Revert debug commit that causes unexpected data corruption.
* Fix muti-block reservation regression.

----------------------------------------------------------------
Andreas Gruenbacher (1):
      Revert "gfs2: check context in gfs2_glock_put"

Bob Peterson (1):
      gfs2: Fix gfs2_release for non-writers regression

 fs/gfs2/file.c  | 7 ++++---
 fs/gfs2/glock.c | 3 ---
 2 files changed, 4 insertions(+), 6 deletions(-)