From: "Pali Rohár" <pali@kernel.org>
To: Michael Ellerman <mpe@ellerman.id.au>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>
Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] powerpc/fsl-pci: Choose PCI host bridge with alias pci0 as the primary
Date: Sun, 9 Oct 2022 13:08:08 +0200 [thread overview]
Message-ID: <20221009110808.agfixtgneshui47o@pali> (raw)
In-Reply-To: <20220820123327.20551-1-pali@kernel.org>
Hello! Any opinion on this patch?
On Saturday 20 August 2022 14:33:27 Pali Rohár wrote:
> If there's no PCI host bridge with ISA then check for PCI host bridge with
> alias "pci0" (first PCI host bridge) and if it exists then choose it as the
> primary PCI host bridge.
>
> This makes choice of primary PCI host bridge more stable across boots and
> updates as the last fallback candidate for primary PCI host bridge (if
> there is no choice) is selected arbitrary.
>
> Signed-off-by: Pali Rohár <pali@kernel.org>
> ---
> arch/powerpc/sysdev/fsl_pci.c | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/arch/powerpc/sysdev/fsl_pci.c b/arch/powerpc/sysdev/fsl_pci.c
> index 1011cfea2e32..e4b703943dd3 100644
> --- a/arch/powerpc/sysdev/fsl_pci.c
> +++ b/arch/powerpc/sysdev/fsl_pci.c
> @@ -1125,6 +1125,19 @@ void __init fsl_pci_assign_primary(void)
> return;
> }
>
> + /*
> + * If there's no PCI host bridge with ISA then check for
> + * PCI host bridge with alias "pci0" (first PCI host bridge).
> + */
> + np = of_find_node_by_path("pci0");
> + if (np && of_match_node(pci_ids, np) && of_device_is_available(np)) {
> + fsl_pci_primary = np;
> + of_node_put(np);
> + return;
> + }
> + if (np)
> + of_node_put(np);
> +
> /*
> * If there's no PCI host bridge with ISA, arbitrarily
> * designate one as primary. This can go away once
> --
> 2.20.1
>
next prev parent reply other threads:[~2022-10-09 11:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-20 12:33 [PATCH] powerpc/fsl-pci: Choose PCI host bridge with alias pci0 as the primary Pali Rohár
2022-10-09 11:08 ` Pali Rohár [this message]
2022-11-01 22:19 ` Pali Rohár
2022-11-26 16:23 ` Pali Rohár
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221009110808.agfixtgneshui47o@pali \
--to=pali@kernel.org \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).