From: Vipin Sharma <vipinsh@google.com>
To: seanjc@google.com, pbonzini@redhat.com, dmatlack@google.com
Cc: andrew.jones@linux.dev, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org, Vipin Sharma <vipinsh@google.com>
Subject: [PATCH v5 0/5] dirty_log_perf_test vCPU pinning
Date: Mon, 10 Oct 2022 15:05:33 -0700 [thread overview]
Message-ID: <20221010220538.1154054-1-vipinsh@google.com> (raw)
Pin vCPUs to a host physical CPUs (pCPUs) in dirty_log_perf_test and
optionally pin the main application thread to a physical cpu if
provided. All tests based on perf_test_util framework can take advantage
of it if needed.
While at it, I changed atoi() to atoi_paranoid(), atoi_positive,
atoi_non_negative() in other tests, sorted command line options
alphabetically in dirty_log_perf_test, and added break between -e and -g
which was missed in original commit when -e was introduced.
v5:
- Added atoi_postive() and atoi_non_negative() APIs for string parsing.
- Using sched_getaffinity() to verify if a pCPU is allowed or not.
- Changed Suggested-by to add only person came up with original idea of
pinning.
- Updated strings and commit messages.
v4: https://lore.kernel.org/lkml/20221006171133.372359-1-vipinsh@google.com/
- Moved boolean to check vCPUs pinning from perf_test_vcpu_args to
perf_test_args.
- Changed assert statements to make error more descriptive.
- Modified break statement between 'e' and 'g' option in v3 by not copying
dirty_log_manual_caps = 0 to 'e'.
v3: https://lore.kernel.org/lkml/20220826184500.1940077-1-vipinsh@google.com
- Moved atoi_paranoid() to test_util.c and replaced all atoi() usage
with atoi_paranoid()
- Sorted command line options alphabetically.
- Instead of creating a vcpu thread on a specific pcpu the thread will
migrate to the provided pcpu after its creation.
- Decoupled -e and -g option.
v2: https://lore.kernel.org/lkml/20220819210737.763135-1-vipinsh@google.com/
- Removed -d option.
- One cpu list passed as option, cpus for vcpus, followed by
application thread cpu.
- Added paranoid cousin of atoi().
v1: https://lore.kernel.org/lkml/20220817152956.4056410-1-vipinsh@google.com
Vipin Sharma (5):
KVM: selftests: Add missing break between -e and -g option in
dirty_log_perf_test
KVM: selftests: Put command line options in alphabetical order in
dirty_log_perf_test
KVM: selftests: Add atoi_paranoid() to catch errors missed by atoi()
KVM: selftests: Add atoi_positive() and atoi_non_negative() for input
validation
KVM: selftests: Run dirty_log_perf_test on specific CPUs
.../selftests/kvm/aarch64/arch_timer.c | 25 ++-----
.../testing/selftests/kvm/aarch64/vgic_irq.c | 6 +-
.../selftests/kvm/access_tracking_perf_test.c | 2 +-
.../selftests/kvm/demand_paging_test.c | 4 +-
.../selftests/kvm/dirty_log_perf_test.c | 62 ++++++++++++------
.../selftests/kvm/include/perf_test_util.h | 6 ++
.../testing/selftests/kvm/include/test_util.h | 4 ++
.../selftests/kvm/kvm_page_table_test.c | 4 +-
.../selftests/kvm/lib/perf_test_util.c | 65 ++++++++++++++++++-
tools/testing/selftests/kvm/lib/test_util.c | 35 ++++++++++
.../selftests/kvm/max_guest_memory_test.c | 7 +-
.../kvm/memslot_modification_stress_test.c | 6 +-
.../testing/selftests/kvm/memslot_perf_test.c | 24 ++-----
.../selftests/kvm/set_memory_region_test.c | 2 +-
.../selftests/kvm/x86_64/nx_huge_pages_test.c | 4 +-
15 files changed, 178 insertions(+), 78 deletions(-)
--
2.38.0.rc1.362.ged0d419d3c-goog
next reply other threads:[~2022-10-10 22:05 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-10 22:05 Vipin Sharma [this message]
2022-10-10 22:05 ` [PATCH v5 1/5] KVM: selftests: Add missing break between -e and -g option in dirty_log_perf_test Vipin Sharma
2022-10-10 22:05 ` [PATCH v5 2/5] KVM: selftests: Put command line options in alphabetical order " Vipin Sharma
2022-10-10 22:05 ` [PATCH v5 3/5] KVM: selftests: Add atoi_paranoid() to catch errors missed by atoi() Vipin Sharma
2022-10-10 22:05 ` [PATCH v5 4/5] KVM: selftests: Add atoi_positive() and atoi_non_negative() for input validation Vipin Sharma
2022-10-10 22:05 ` [PATCH v5 5/5] KVM: selftests: Run dirty_log_perf_test on specific CPUs Vipin Sharma
2022-10-20 21:42 ` Sean Christopherson
2022-10-20 21:44 ` Sean Christopherson
2022-10-14 15:12 ` [PATCH v5 0/5] dirty_log_perf_test vCPU pinning Wang, Wei W
2022-10-14 15:16 ` Wang, Wei W
2022-10-14 16:34 ` Sean Christopherson
2022-10-14 16:55 ` David Matlack
2022-10-14 18:26 ` Vipin Sharma
2022-10-14 19:02 ` Sean Christopherson
2022-10-14 21:21 ` Vipin Sharma
2022-10-17 0:47 ` Wang, Wei W
2022-10-20 21:46 ` Sean Christopherson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221010220538.1154054-1-vipinsh@google.com \
--to=vipinsh@google.com \
--cc=andrew.jones@linux.dev \
--cc=dmatlack@google.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=seanjc@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).