From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B670CC43217 for ; Thu, 1 Dec 2022 08:45:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229922AbiLAIpQ (ORCPT ); Thu, 1 Dec 2022 03:45:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43768 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229918AbiLAIob (ORCPT ); Thu, 1 Dec 2022 03:44:31 -0500 Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DB12E8C69E for ; Thu, 1 Dec 2022 00:44:15 -0800 (PST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 4C1645C01AE; Thu, 1 Dec 2022 03:44:15 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Thu, 01 Dec 2022 03:44:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h=cc :cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1669884255; x= 1669970655; bh=1vlWw3HWcseVhvxGIduvYvORASnSFa/0anA5xMkzYTs=; b=A IMDJY/TOTF3FYZzKSFfSABapNtMgtstVZZwPeU5tKwfQ/u+pFUVhSViIyij4b0wO zbi7B659HN/qnkihiSgKXKhtZ69me94ozqbcO2OiB7a3i9yA60qkLT4TKW1eEVW1 fqwKC34AGKgw7uiTCkwIuUkCRDD27e0W49U0OJ2poV45otO2cZTdutwKYYKgxz6O xprIf2xbVxeuLCqjjh5uEXBCnn51PY12qzbs4GM/1jSkZamnTjBBCLAPLCXVv1xY DJGtTbvq1clXMBYNtYOeYDq64LjMez+oS6L3X4QNWzuR00no+Dpbq06xhZBfouJJ eT+VM+DEY4a4TtrjnmI0Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1669884255; x= 1669970655; bh=1vlWw3HWcseVhvxGIduvYvORASnSFa/0anA5xMkzYTs=; b=n ttMxKjSzh6M1U2J8XdbUvNH5nZj+9szvM34E4c08/kAKIZBCDAId0EDZ3C9YEK+J TzrafALHEbox1ajJW0Q/1Er88htT2sfmcE1Tl59bs6XdTMwsSb0xLQKTdfYjV/L6 DYCqw8rEM6aE7z/SQmxXURuWwiX2m0vyXcI7HpKg2sMeWSdeoZhJFae4L8xGwwfP Xh6EV25U4a7xvFExDK1w1SAzSHp7Rp51EbEZc5J1wjXnjNLeW211AAqDhzCu7ZVp GzQsVozVLrT+NT5vciZTyquUNC3FOt37D+hHuJa7vcZLz533nHSxGK1guqTS5vKh V11TURURvDZXPcYlFGCsA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrtdeggdduvdeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephfffufggtgfgkfhfjgfvvefosehtkeertdertdejnecuhfhrohhmpeforgig ihhmvgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrf grthhtvghrnhepudduudfhveejteefgedvffdvvedvjedugedukeejhedtlefhffevtefh jeeltdevnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh epmhgrgihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Feedback-ID: i8771445c:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 1 Dec 2022 03:44:14 -0500 (EST) From: Maxime Ripard Date: Thu, 01 Dec 2022 09:42:51 +0100 Subject: [PATCH v3 6/7] drm/vc4: dpi: Change the default DPI format to being 18bpp, not 24. MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Message-Id: <20221013-rpi-dpi-improvements-v3-6-eb76e26a772d@cerno.tech> References: <20221013-rpi-dpi-improvements-v3-0-eb76e26a772d@cerno.tech> In-Reply-To: <20221013-rpi-dpi-improvements-v3-0-eb76e26a772d@cerno.tech> To: Maxime Ripard , Daniel Vetter , Rob Herring , David Airlie , Emma Anholt , Eric Anholt Cc: Dave Stevenson , Maxime Ripard , dri-devel@lists.freedesktop.org, Laurent Pinchart , Chris Morgan , Laurent Pinchart , Joerg Quinten , linux-kernel@vger.kernel.org X-Mailer: b4 0.10.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1321; i=maxime@cerno.tech; h=from:subject:message-id; bh=Cj2SqCiv0e+hjTKV6Xz2WDeMWOb4ZCwlvcwXbXBSakE=; b=owGbwMvMwCX2+D1vfrpE4FHG02pJDMkdmeziL3SX7zTrdP5+OHjOkrnCmxbrdmXuj3bKLXVqEgs8 c6ejo5SFQYyLQVZMkSVG2HxJ3KlZrzvZ+ObBzGFlAhnCwMUpABOJm8DIcGpr/V/O79tuXdWqbfmh6n W57GFLhYNumMCrp72Xi9e/j2ZkmJZQ/Ovcls2bZx8IEhXgTPszQeDy78sbk56V/r5y2eyvPysA X-Developer-Key: i=maxime@cerno.tech; a=openpgp; fpr=BE5675C37E818C8B5764241C254BCFC56BF6CE8D Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dave Stevenson DPI hasn't really been used up until now, so the default has been meaningless. In theory we should be able to pass the desired format for the adjacent bridge chip through, but framework seems to be missing for that. As the main device to use DPI is the VGA666 or Adafruit Kippah, both of which use RGB666, change the default to being RGB666 instead of RGB888. Signed-off-by: Dave Stevenson Reviewed-by: Laurent Pinchart Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_dpi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/vc4/vc4_dpi.c b/drivers/gpu/drm/vc4/vc4_dpi.c index ecbe4cd87036..fdae02760b6d 100644 --- a/drivers/gpu/drm/vc4/vc4_dpi.c +++ b/drivers/gpu/drm/vc4/vc4_dpi.c @@ -150,8 +150,8 @@ static void vc4_dpi_encoder_enable(struct drm_encoder *encoder) } drm_connector_list_iter_end(&conn_iter); - /* Default to 24bit if no connector or format found. */ - dpi_c |= VC4_SET_FIELD(DPI_FORMAT_24BIT_888_RGB, DPI_FORMAT); + /* Default to 18bit if no connector or format found. */ + dpi_c |= VC4_SET_FIELD(DPI_FORMAT_18BIT_666_RGB_1, DPI_FORMAT); if (connector) { if (connector->display_info.num_bus_formats) { -- b4 0.10.1