From: Marijn Suijten <marijn.suijten@somainline.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Linus Walleij <linus.walleij@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 10/16] arm64: dts: qcom: sm6125: align TLMM pin configuration with DT schema
Date: Thu, 13 Oct 2022 11:47:42 +0200 [thread overview]
Message-ID: <20221013094742.fftcbdkjipkw3pub@SoMainline.org> (raw)
In-Reply-To: <112ada96-f742-8d06-dc90-a422d3636e06@linaro.org>
On 2022-10-11 08:06:55, Krzysztof Kozlowski wrote:
> On 11/10/2022 03:45, Marijn Suijten wrote:
> > On 2022-09-30 21:29:48, Krzysztof Kozlowski wrote:
> >> DT schema expects TLMM pin configuration nodes to be named with
> >> '-state' suffix and their optional children with '-pins' suffix.
> >>
> >> Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org>
> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> >
> > Thanks!
> >
> > Reviewed-by: Marijn Suijten <marijn.suijten@somainline.org>
> >
> > Perhaps mention more clearly that this is fixing up an earlier patch
> > that tried to address missing `-pins`?
>
> It is not fixing only that patch, but also nodes added later without suffix.
Afaik the node was already there when [1] was applied, it just
accidentally added -pins to cmd twice instead of once to clk and cmd
separately. But feel free to stick to a generic commit message.
[1]: https://lore.kernel.org/all/20220912061746.6311-35-krzysztof.kozlowski@linaro.org/
- Marijn
next prev parent reply other threads:[~2022-10-13 9:47 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-30 19:29 [PATCH v2 00/16] pinctrl/arm64: qcom: 4th set of Qualcomm TLMM pinctrl schema warnings Krzysztof Kozlowski
2022-09-30 19:29 ` [PATCH v2 01/16] arm64: dts: qcom: sm8250: align TLMM pin configuration with DT schema Krzysztof Kozlowski
2022-09-30 19:29 ` [PATCH v2 02/16] arm64: dts: qcom: sm8250-sony-xperia-edo: fix touchscreen bias-disable Krzysztof Kozlowski
2022-09-30 19:29 ` [PATCH v2 03/16] arm64: dts: qcom: sc8280xp: align TLMM pin configuration with DT schema Krzysztof Kozlowski
2022-09-30 19:29 ` [PATCH v2 04/16] arm64: dts: qcom: sc7280: align TLMM pin configuration with DT schema (really) Krzysztof Kozlowski
2022-09-30 19:29 ` [PATCH v2 05/16] arm64: dts: qcom: sc7280-herobrine: correct number of gpio-line-names Krzysztof Kozlowski
2022-09-30 19:29 ` [PATCH v2 06/16] arm64: dts: qcom: sc7280-idp-ec-h1: add missing QUP GPIO functions Krzysztof Kozlowski
2022-09-30 19:29 ` [PATCH v2 07/16] arm64: dts: qcom: msm8953: align TLMM pin configuration with DT schema Krzysztof Kozlowski
2022-09-30 19:29 ` [PATCH v2 08/16] arm64: dts: qcom: sdm845: " Krzysztof Kozlowski
2022-09-30 19:29 ` [PATCH v2 09/16] arm64: dts: qcom: sm6125-sony-xperia: add missing SD CD GPIO functions Krzysztof Kozlowski
2022-09-30 19:29 ` [PATCH v2 10/16] arm64: dts: qcom: sm6125: align TLMM pin configuration with DT schema Krzysztof Kozlowski
2022-10-11 7:45 ` Marijn Suijten
2022-10-11 12:06 ` Krzysztof Kozlowski
2022-10-13 9:47 ` Marijn Suijten [this message]
2022-09-30 19:29 ` [PATCH v2 11/16] dt-bindings: pinctrl: qcom,sm8250: add gpio-reserved-ranges and gpio-line-names Krzysztof Kozlowski
2022-10-07 3:15 ` Bjorn Andersson
2022-09-30 19:29 ` [PATCH v2 12/16] dt-bindings: pinctrl: qcom,sm8250: drop checks used in common TLMM Krzysztof Kozlowski
2022-10-03 17:08 ` Rob Herring
2022-10-07 3:15 ` Bjorn Andersson
2022-09-30 19:29 ` [PATCH v2 13/16] dt-bindings: pinctrl: qcom,sm8250: fix matching pin config Krzysztof Kozlowski
2022-10-03 17:08 ` Rob Herring
2022-10-07 3:17 ` Bjorn Andersson
2022-09-30 19:29 ` [PATCH v2 14/16] dt-bindings: pinctrl: qcom,sm8250: add input-enable Krzysztof Kozlowski
2022-10-07 3:17 ` Bjorn Andersson
2022-09-30 19:29 ` [PATCH v2 15/16] dt-bindings: pinctrl: qcom,sc7280: add bias-bus-hold and input-enable Krzysztof Kozlowski
2022-10-07 3:17 ` Bjorn Andersson
2022-09-30 19:29 ` [PATCH v2 16/16] dt-bindings: pinctrl: qcom,sc7280: correct number of GPIOs Krzysztof Kozlowski
2022-10-07 3:18 ` Bjorn Andersson
2022-10-18 3:05 ` (subset) [PATCH v2 00/16] pinctrl/arm64: qcom: 4th set of Qualcomm TLMM pinctrl schema warnings Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221013094742.fftcbdkjipkw3pub@SoMainline.org \
--to=marijn.suijten@somainline.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).