From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D93EFC433FE for ; Sun, 16 Oct 2022 16:37:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229607AbiJPQhA (ORCPT ); Sun, 16 Oct 2022 12:37:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35368 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229597AbiJPQg6 (ORCPT ); Sun, 16 Oct 2022 12:36:58 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E31153684C; Sun, 16 Oct 2022 09:36:57 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id A2C5BB80B67; Sun, 16 Oct 2022 16:36:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7DCA6C433D6; Sun, 16 Oct 2022 16:36:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1665938215; bh=JCCTbWupmkrNEddZayM59JFGMIafAlFS8/eA55XBEDk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=FIxi0/mPqWefzgRNZImNyUt4qv9xQMT+g1xc6K5iF1oRhqi+Yj9IY31lkJ/FVTs+4 o3TL3ykXLtdDMQ0oZ1ipDPYg4JvzVULmh5RSrkakDWXfMYV7Q5aPdwNRiShmtr+R+1 g6LFHyN49Ca0WGaTBcFD83SI2z8YqivvP/BtWBq3VL44iuluLjxB7ZJhfe5CXdDkNd 6f2vrrRxyWVzYgr+iAxvTmzutKajHyq4RHpVPgR1iQHErmRnRL0HtdegywH3zAphqt xTupcR09YBaExDiRlLaLAnyKVJA+P+GE1pma09w3kO5P+h2SmWiT1ExPIw+MzHtFUu 3VCQDR3JOoGdg== Date: Sun, 16 Oct 2022 17:37:23 +0100 From: Jonathan Cameron To: "Sa, Nuno" Cc: Matti Vaittinen , Matti Vaittinen , Lars-Peter Clausen , Alexandru Ardelean , "linux-iio@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v3 13/14] iio: max1363: simplify using devm_regulator_get_enable() Message-ID: <20221016173723.31edc35d@jic23-huawei> In-Reply-To: <20221016171838.22669a2a@jic23-huawei> References: <1286ea127d190e5708a0aaff271819b2d3f8802d.1660934107.git.mazziesaccount@gmail.com> <20221016171838.22669a2a@jic23-huawei> X-Mailer: Claws Mail 4.1.0 (GTK 3.24.34; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 16 Oct 2022 17:18:38 +0100 Jonathan Cameron wrote: > On Tue, 30 Aug 2022 11:50:05 +0000 > "Sa, Nuno" wrote: >=20 > > > -----Original Message----- > > > From: Matti Vaittinen > > > Sent: Friday, August 19, 2022 9:21 PM > > > To: Matti Vaittinen ; Matti Vaittinen > > > > > > Cc: Jonathan Cameron ; Lars-Peter Clausen > > > ; Matti Vaittinen ; > > > Alexandru Ardelean ; linux- > > > iio@vger.kernel.org; linux-kernel@vger.kernel.org > > > Subject: [PATCH v3 13/14] iio: max1363: simplify using > > > devm_regulator_get_enable() > > >=20 > > > [External] > > >=20 > > > Drop open-coded pattern: 'devm_regulator_get(), regulator_enable(), > > > add_action_or_reset(regulator_disable)' and use the > > > devm_regulator_get_enable() and drop the pointer to the regulator. > > > This simplifies code and makes it less tempting to add manual control > > > for the regulator which is also controlled by devm. > > >=20 > > > Signed-off-by: Matti Vaittinen > > >=20 > > > --- =20 > >=20 > > Acked-by: Nuno S=C3=A1 =20 >=20 > Applied. This one was missing cleaning up the docs as well. fixed up.