From: Dorota Czaplejewicz <dorota.czaplejewicz@puri.sm>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Steve Longerbeam <slongerbeam@gmail.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, kernel@puri.sm,
phone-devel@vger.kernel.org
Subject: Re: [PATCHv3 1/1 RESEND] media: imx: Round line size to 4 bytes
Date: Mon, 17 Oct 2022 16:30:59 +0200 [thread overview]
Message-ID: <20221017163059.377ac677.dorota.czaplejewicz@puri.sm> (raw)
In-Reply-To: <Y00SSRMFuL3Drjd4@pendragon.ideasonboard.com>
[-- Attachment #1: Type: text/plain, Size: 2523 bytes --]
Hi,
On Mon, 17 Oct 2022 11:28:57 +0300
Laurent Pinchart <laurent.pinchart@ideasonboard.com> wrote:
> Hi Dorota,
>
> Thank you for the patch.
>
> On Sun, Oct 16, 2022 at 04:39:28PM +0200, Dorota Czaplejewicz wrote:
> > Section 13.7.6.13 "CSI Image Parameter Register" of the
> > i.MX 8M Quad Applications Processors Reference Manual
> > states that the line size should be divisible by 8 bytes.
> > However, the hardware also accepts sizes divisible by 4 bytes,
> > which are needed to fully utilize the S5K3L6XX sensors.
> >
> > This patch accepts line sizes divisible by 4 bytes.
>
> The patch itself looks fine, but I always worry when we depart from the
> documentation (sometimes that's a worry about documentation inaccuracies
> :-)). In this particular case, we need to test the change on i.MX7 too,
> as the alignment constraints could be platform-specific.
>
I don't have access to any i.MX7 hardware, unfortunately. I can help anyone who does and wants to test this.
> I would also very much appreciate feedback from NXP on this. There's a
> risk of ill side-effects that I would prefer ruling out very clearly.
I posted a question on the NXP forum: https://community.nxp.com/t5/i-MX-Processors/i-MX8MQ-CSI-line-size-constraint-documentation-mistake/m-p/1538629#M196448
--Dorota
>
> > Signed-off-by: Dorota Czaplejewicz <dorota.czaplejewicz@puri.sm>
> > ---
> > Hello,
> >
> > the Librem 5 is using an out-of-tree driver for s5k3l6xx, and rounding to 4 is optimal to operate it.
> >
> > This revision improves the commit message.
> >
> > Cheers,
> > Dorota Czaplejewicz
> >
> > drivers/staging/media/imx/imx7-media-csi.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/staging/media/imx/imx7-media-csi.c b/drivers/staging/media/imx/imx7-media-csi.c
> > index a0553c24cce4..af821b410c3f 100644
> > --- a/drivers/staging/media/imx/imx7-media-csi.c
> > +++ b/drivers/staging/media/imx/imx7-media-csi.c
> > @@ -999,10 +999,10 @@ static int imx7_csi_mbus_fmt_to_pix_fmt(struct v4l2_pix_format *pix,
> > }
> >
> > /* Round up width for minimum burst size */
> > - width = round_up(mbus->width, 8);
> > + width = round_up(mbus->width, 4);
> >
> > /* Round up stride for IDMAC line start address alignment */
> > - stride = round_up((width * cc->bpp) >> 3, 8);
> > + stride = round_up((width * cc->bpp) >> 3, 4);
> >
> > pix->width = width;
> > pix->height = mbus->height;
>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-10-17 14:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-16 14:39 [PATCHv3 1/1 RESEND] media: imx: Round line size to 4 bytes Dorota Czaplejewicz
2022-10-17 8:28 ` Laurent Pinchart
2022-10-17 14:30 ` Dorota Czaplejewicz [this message]
2022-11-01 12:38 ` Dorota Czaplejewicz
2022-11-24 11:30 ` Laurent Pinchart
2022-11-24 12:35 ` Dorota Czaplejewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221017163059.377ac677.dorota.czaplejewicz@puri.sm \
--to=dorota.czaplejewicz@puri.sm \
--cc=festevam@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel@pengutronix.de \
--cc=kernel@puri.sm \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=phone-devel@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=slongerbeam@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).