From: Andrew Morton <akpm@linux-foundation.org>
To: Sergey Senozhatsky <senozhatsky@chromium.org>
Cc: Minchan Kim <minchan@kernel.org>, Nitin Gupta <ngupta@vflare.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCHv3 4/8] zram: Introduce recompress sysfs knob
Date: Mon, 17 Oct 2022 17:08:50 -0700 [thread overview]
Message-ID: <20221017170850.034705ad83c54b92236d14f7@linux-foundation.org> (raw)
In-Reply-To: <20221009090720.1040633-5-senozhatsky@chromium.org>
On Sun, 9 Oct 2022 18:07:16 +0900 Sergey Senozhatsky <senozhatsky@chromium.org> wrote:
> Allow zram to recompress (using secondary compression streams)
> pages. We support three modes:
>
> 1) IDLE pages recompression is activated by `idle` mode
>
> echo idle > /sys/block/zram0/recompress
>
> 2) Since there may be many idle pages user-space may pass a size
> watermark value and we will recompress IDLE pages only of equal
> or greater size:
>
> echo 888 > /sys/block/zram0/recompress
It's helpful to describe the units ("bytes") here and in the
docmentation.
> 3) HUGE pages recompression is activated by `huge` mode
>
> echo huge > /sys/block/zram0/recompress
>
> 4) HUGE_IDLE pages recompression is activated by `huge_idle` mode
>
> echo huge_idle > /sys/block/zram0/recompress
>
> ...
>
> + if (IS_ERR((void *)handle_next)) {
IS_ERR_VALUE() avoids castsing back and forth.
next prev parent reply other threads:[~2022-10-18 0:12 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-09 9:07 [PATCHv3 0/8] zram: Support multiple compression streams Sergey Senozhatsky
2022-10-09 9:07 ` [PATCHv3 1/8] zram: Preparation for multi-zcomp support Sergey Senozhatsky
2022-10-09 9:07 ` [PATCHv3 2/8] zram: Add recompression algorithm sysfs knob Sergey Senozhatsky
2022-10-09 9:07 ` [PATCHv3 3/8] zram: Factor out WB and non-WB zram read functions Sergey Senozhatsky
2022-10-09 9:07 ` [PATCHv3 4/8] zram: Introduce recompress sysfs knob Sergey Senozhatsky
2022-10-18 0:08 ` Andrew Morton [this message]
2022-10-18 2:12 ` Sergey Senozhatsky
2022-10-18 2:42 ` Sergey Senozhatsky
2022-10-09 9:07 ` [PATCHv3 5/8] documentation: Add recompression documentation Sergey Senozhatsky
2022-10-18 2:22 ` Sergey Senozhatsky
2022-10-18 3:11 ` Andrew Morton
2022-10-18 2:50 ` Sergey Senozhatsky
2022-10-09 9:07 ` [PATCHv3 6/8] zram: Add recompression algorithm choice to Kconfig Sergey Senozhatsky
2022-10-18 3:07 ` Sergey Senozhatsky
2022-10-09 9:07 ` [PATCHv3 7/8] zram: Add recompress flag to read_block_state() Sergey Senozhatsky
2022-10-09 9:07 ` [PATCHv3 8/8] zram: correct typos Sergey Senozhatsky
2022-10-18 0:08 ` Andrew Morton
2022-10-18 2:10 ` Sergey Senozhatsky
2022-10-18 3:11 ` [PATCHv3 0/8] zram: Support multiple compression streams Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221017170850.034705ad83c54b92236d14f7@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=ngupta@vflare.org \
--cc=senozhatsky@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).