From: Andrew Halaney <ahalaney@redhat.com>
To: Johan Hovold <johan+linaro@kernel.org>
Cc: Bjorn Andersson <andersson@kernel.org>,
Andy Gross <agross@kernel.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] arm64: dts: qcom: sc8280xp: fix USB0 PHY PCS_MISC registers
Date: Mon, 17 Oct 2022 15:50:43 -0500 [thread overview]
Message-ID: <20221017205043.wgys4c7ybb4ga4o7@halaney-x13s> (raw)
In-Reply-To: <20220919094454.1574-2-johan+linaro@kernel.org>
Hi,
On Mon, Sep 19, 2022 at 11:44:51AM +0200, Johan Hovold wrote:
> The USB0 SS PHY node had the PCS_MISC register block (0x1200) replaced
> with PCS_USB (0x1700).
>
> Fixes: 152d1faf1e2f ("arm64: dts: qcom: add SC8280XP platform")
> Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
Reviewed-by: Andrew Halaney <ahalaney@redhat.com>
Thanks for the patch, I think this patch makes sense from what I'm
seeing of upstream's expectations (that register space should be
PCS_MISC's) downstream, register names, and offsets.
Being verbose because it took me a little bit to figure out, but here's
the offset and registers I found downstream which correlate to
your change:
/* Module: USB3_PCS_MISC_USB3_PCS_MISC_USB3_PCS_MISC */
#define USB3_PCS_MISC_TYPEC_CTRL 0x1200
#define USB3_PCS_MISC_TYPEC_PWRDN_CTRL 0x1204
#define USB3_PCS_MISC_PCS_MISC_CONFIG1 0x1208
#define USB3_PCS_MISC_CLAMP_ENABLE 0x120C
#define USB3_PCS_MISC_TYPEC_STATUS 0x1210
#define USB3_PCS_MISC_PLACEHOLDER_STATUS 0x1214
Your description of the PCS_USB region accidentally being used in the
prior version also adds up with what I see.
Thanks,
Andrew
> ---
> arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
> index 49ea8b5612fc..e8905445ca19 100644
> --- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
> @@ -1184,7 +1184,7 @@ usb_0_ssphy: usb3-phy@88eb400 {
> <0 0x088ec400 0 0x1f0>,
> <0 0x088eba00 0 0x100>,
> <0 0x088ebc00 0 0x3ec>,
> - <0 0x088ec700 0 0x64>;
> + <0 0x088ec200 0 0x18>;
> #phy-cells = <0>;
> #clock-cells = <0>;
> clocks = <&gcc GCC_USB3_PRIM_PHY_PIPE_CLK>;
> --
> 2.35.1
>
next prev parent reply other threads:[~2022-10-17 20:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-19 9:44 [PATCH 0/4] arm64: dts: qcom: sc8280xp: fix USB/DP PHYs Johan Hovold
2022-09-19 9:44 ` [PATCH 1/4] arm64: dts: qcom: sc8280xp: fix USB0 PHY PCS_MISC registers Johan Hovold
2022-10-17 20:50 ` Andrew Halaney [this message]
2022-09-19 9:44 ` [PATCH 2/4] arm64: dts: qcom: sc8280xp: fix USB1 PHY RX1 registers Johan Hovold
2022-10-17 20:56 ` Andrew Halaney
2022-09-19 9:44 ` [PATCH 3/4] arm64: dts: qcom: sc8280xp: fix USB PHY PCS registers Johan Hovold
2022-10-17 20:59 ` Andrew Halaney
2022-09-19 9:44 ` [PATCH 4/4] arm64: dts: qcom: sc8280xp: drop broken DP PHY nodes Johan Hovold
2022-10-18 3:05 ` [PATCH 0/4] arm64: dts: qcom: sc8280xp: fix USB/DP PHYs Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221017205043.wgys4c7ybb4ga4o7@halaney-x13s \
--to=ahalaney@redhat.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=johan+linaro@kernel.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).