From: Vivek Yadav <vivek.2311@samsung.com>
To: rcsekar@samsung.com, wg@grandegger.com, mkl@pengutronix.de,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, pankaj.dubey@samsung.com,
ravi.patel@samsung.com
Cc: linux-can@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
Vivek Yadav <vivek.2311@samsung.com>
Subject: [PATCH v4] can: mcan: Add support for handling DLEC error on CAN FD
Date: Tue, 18 Oct 2022 10:03:33 +0530 [thread overview]
Message-ID: <20221018043333.38858-1-vivek.2311@samsung.com> (raw)
In-Reply-To: CGME20221018050046epcas5p1ff6339e8394597948f9b26aecb4b51a9@epcas5p1.samsung.com
When a frame in CAN FD format has reached the data phase, the next
CAN event (error or valid frame) will be shown in DLEC.
Utilizes the dedicated flag (Data Phase Last Error Code: DLEC flag) to
determine the type of last error that occurred in the data phase
of a CAN FD frame and handle the bus errors.
Signed-off-by: Vivek Yadav <vivek.2311@samsung.com>
---
This patch is dependent on following patch from Marc:
[1]: https://lore.kernel.org/all/20221012074205.691384-1-mkl@pengutronix.de/
drivers/net/can/m_can/m_can.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/drivers/net/can/m_can/m_can.c b/drivers/net/can/m_can/m_can.c
index 18a138fdfa66..98cc98564ab4 100644
--- a/drivers/net/can/m_can/m_can.c
+++ b/drivers/net/can/m_can/m_can.c
@@ -156,6 +156,7 @@ enum m_can_reg {
#define PSR_EW BIT(6)
#define PSR_EP BIT(5)
#define PSR_LEC_MASK GENMASK(2, 0)
+#define PSR_DLEC_MASK GENMASK(8, 10)
/* Interrupt Register (IR) */
#define IR_ALL_INT 0xffffffff
@@ -868,6 +869,7 @@ static int m_can_handle_bus_errors(struct net_device *dev, u32 irqstatus,
{
struct m_can_classdev *cdev = netdev_priv(dev);
int work_done = 0;
+ u8 dlec = 0;
if (irqstatus & IR_RF0L)
work_done += m_can_handle_lost_msg(dev);
@@ -878,6 +880,13 @@ static int m_can_handle_bus_errors(struct net_device *dev, u32 irqstatus,
if (is_lec_err(lec))
work_done += m_can_handle_lec_err(dev, lec);
+
+ dlec = FIELD_GET(PSR_DLEC_MASK, psr);
+
+ if (is_lec_err(dlec)) {
+ netdev_dbg(dev, "Data phase error detected\n");
+ work_done += m_can_handle_lec_err(dev, dlec);
+ }
}
/* handle protocol errors in arbitration phase */
--
2.17.1
next parent reply other threads:[~2022-10-18 5:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20221018050046epcas5p1ff6339e8394597948f9b26aecb4b51a9@epcas5p1.samsung.com>
2022-10-18 4:33 ` Vivek Yadav [this message]
2022-10-18 6:15 ` [PATCH v4] can: mcan: Add support for handling DLEC error on CAN FD Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221018043333.38858-1-vivek.2311@samsung.com \
--to=vivek.2311@samsung.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pankaj.dubey@samsung.com \
--cc=ravi.patel@samsung.com \
--cc=rcsekar@samsung.com \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).